Re: [aur-general] graphviz perl module package
hi everyone, thanks the quickly response for all (and sorry the top posting =p) I modified the PKGBUILD based on your suggestions. I added the graphviz package as a dependecy (I have forgoten that because I already had it installed). I do not know the diference between makedepends and depends arrays. It is good now to upload? take a look at: http://paste.xinu.at/MAKtX/ abracos Antonio Lucas
Re: [aur-general] graphviz perl module package
Am 13.11.2010 19:04, schrieb Stéphane Gaudreault:
> Le samedi 13 novembre 2010 12:15:35, Lukas Fleischer a écrit :
>> On Sat, Nov 13, 2010 at 06:06:13PM +0100, Florian Pritz wrote:
>>> You should:
>>> - move everything after make into package()
>>> - remove || return 1
>>> - replace $startdir/{pkg,src} by ${pkg,src}dir
>>> - remove the 3rd line (useless comment)
>>>
>>> That should look similar to this http://paste.xinu.at/oksL2/
>>
>> Optimally also put directories containing variables (especially
>> "${srcdir}" or "${pkgdir}") in double quotes ('""').
>
> Most of these "errors" are present in the wiki template. I just changed it.
>
> By the way, Abs templates in /usr/share/pacman/ are also old style PKGBUILD.
> I
> will see with Allan to change that.
>
> Stéphane
>
Hello,
maybe that article should be merged with
https://wiki.archlinux.org/index.php/Perl_Package_Guidelines
as suggested in the "discussion" tab.
Regards Stefan
Re: [aur-general] graphviz perl module package
Le samedi 13 novembre 2010 12:15:35, Lukas Fleischer a écrit :
> On Sat, Nov 13, 2010 at 06:06:13PM +0100, Florian Pritz wrote:
> > You should:
> > - move everything after make into package()
> > - remove || return 1
> > - replace $startdir/{pkg,src} by ${pkg,src}dir
> > - remove the 3rd line (useless comment)
> >
> > That should look similar to this http://paste.xinu.at/oksL2/
>
> Optimally also put directories containing variables (especially
> "${srcdir}" or "${pkgdir}") in double quotes ('""').
Most of these "errors" are present in the wiki template. I just changed it.
By the way, Abs templates in /usr/share/pacman/ are also old style PKGBUILD. I
will see with Allan to change that.
Stéphane
Re: [aur-general] graphviz perl module package
Am 13.11.2010 18:33, schrieb Stefan Husmann: > Maybe arch should be 'any'? > (answering to myself after testing) Yes, it should be!
Re: [aur-general] graphviz perl module package
Am 13.11.2010 17:54, schrieb Antonio Lucas: > Hi, > > I did this PKGBUILD for graphviz, and I think it is OK. But I would like > someone more experienced (I never did a PKGBUILD) took a look and tell me if > it is really OK and I can upload it to aur. > > I based it on this sample found on the wiki: > https://wiki.archlinux.org/index.php/Perl_Policy#Sample_Vendor_PKGBUILD > > thanks in advice > > abracos > Antonio Lucas Hello, the package needs the program "dot" from the graphviz package, at least at build time. So it should be a (make-)dependency. Maybe arch should be 'any'? Regards Stefan
Re: [aur-general] graphviz perl module package
On Sat, Nov 13, 2010 at 06:06:13PM +0100, Florian Pritz wrote:
> You should:
> - move everything after make into package()
> - remove || return 1
> - replace $startdir/{pkg,src} by ${pkg,src}dir
> - remove the 3rd line (useless comment)
>
> That should look similar to this http://paste.xinu.at/oksL2/
Optimally also put directories containing variables (especially
"${srcdir}" or "${pkgdir}") in double quotes ('""').
Re: [aur-general] graphviz perl module package
On 13.11.2010 17:54, Antonio Lucas wrote:
> I did this PKGBUILD for graphviz, and I think it is OK. But I would like
> someone more experienced (I never did a PKGBUILD) took a look and tell me if
> it is really OK and I can upload it to aur.
You should:
- move everything after make into package()
- remove || return 1
- replace $startdir/{pkg,src} by ${pkg,src}dir
- remove the 3rd line (useless comment)
That should look similar to this http://paste.xinu.at/oksL2/
--
Florian Pritz -- {flo,bluewi...@server-speed.net
signature.asc
Description: OpenPGP digital signature
[aur-general] graphviz perl module package
Hi, I did this PKGBUILD for graphviz, and I think it is OK. But I would like someone more experienced (I never did a PKGBUILD) took a look and tell me if it is really OK and I can upload it to aur. I based it on this sample found on the wiki: https://wiki.archlinux.org/index.php/Perl_Policy#Sample_Vendor_PKGBUILD thanks in advice abracos Antonio Lucas PKGBUILD Description: Binary data
