Re: [aur-general] maynard-git package review request
On Sun, Aug 21, 2016 at 11:15:16PM -0400, Eli Schwartz via aur-general wrote:
> To quote the Wiki[1]...
>
> Both methods can also be combined, to support repositories that start
> without a tag but get tagged later on (uses a bashism):
>
> ```
> pkgver() {
> cd "$pkgname"
> ( set -o pipefail
> git describe --long 2>/dev/null | sed 's/\([^-]*-g\)/r\1/;s/-/./g' ||
> printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse
> --short HEAD)"
> )
> }
> ```
For now, I'll stick to use no-tag version. Tagged version will be
considered when the time comes.
>
> > I think configure flag --libexecdir is needed to put maynard executable
> > under /usr/lib/maynard. Without libexecdir, the resulting executable is
> > placed under /usr/libexec/maynard and it's kind of messy.
> >
> > I should have tested the PKGBUILD under clean chroot to specify exact
> > dependencies.
> >
> > Thanks for your feedback.
> >
>
> Hmm, maybe -- I haven't tried it, so I wouldn't know. But libexecdir
> does ring a bell...
> What about bindir, libdir, and sysconfdir though? IIRC those should
> already have the right default values.
Removing bindir, libdir, and sysconfdir flags creates no problems so
far. It put the binaries and libraries in the right place according to
Arch Linux packaging standards.
>
> --
> Eli Schwartz
>
>
> [1] https://wiki.archlinux.org/index.php/VCS_package_guidelines#Git
Re: [aur-general] maynard-git package review request
On 08/21/2016 10:59 PM, Alive 4ever wrote:
> I intentinally put the comments from PGBUILD-vcs.proto, thinking that
> someday there will be git tag. Currently, there is no tag available.
> `git describe` shows no output. I should clean this mess up.
To quote the Wiki[1]...
Both methods can also be combined, to support repositories that start
without a tag but get tagged later on (uses a bashism):
```
pkgver() {
cd "$pkgname"
( set -o pipefail
git describe --long 2>/dev/null | sed 's/\([^-]*-g\)/r\1/;s/-/./g' ||
printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse
--short HEAD)"
)
}
```
> I think configure flag --libexecdir is needed to put maynard executable
> under /usr/lib/maynard. Without libexecdir, the resulting executable is
> placed under /usr/libexec/maynard and it's kind of messy.
>
> I should have tested the PKGBUILD under clean chroot to specify exact
> dependencies.
>
> Thanks for your feedback.
>
Hmm, maybe -- I haven't tried it, so I wouldn't know. But libexecdir
does ring a bell...
What about bindir, libdir, and sysconfdir though? IIRC those should
already have the right default values.
--
Eli Schwartz
[1] https://wiki.archlinux.org/index.php/VCS_package_guidelines#Git
Re: [aur-general] maynard-git package review request
On Sun, Aug 21, 2016 at 10:16:44AM -0400, Eli Schwartz via aur-general wrote:
> On 08/21/2016 06:39 AM, Alive 4ever wrote:
> > Feel free to test this package. Remember to submit bug reports and
> > feedback upstream. Patches and suggestions for improving PKGBUILD are
> > welcome.
>
> Why so many comments?
>
> Other than that, it looks fine except for your usage of ${pkgname%-VCS}
> instead of ${pkgname%-git} -- did you forget to customize that?
>
> I would also include an empty line in between the Maintainer line and
> the body of the PKGBUILD, for readability. Additionally, you can again
> use ${pkgname%-git} in the url, to highlight the connection between the
> upstream url and the package name, and use ${url} in the sources array.
>
> Also note that git will by default clone the repo into the last url
> component with the ".git" part trimmed off, so no need to manually
> specify it.
>
> ...
>
> How many of those configure flags are necessary? Most projects only need
> the --prefix to be specified...
I intentinally put the comments from PGBUILD-vcs.proto, thinking that
someday there will be git tag. Currently, there is no tag available.
`git describe` shows no output. I should clean this mess up.
About leftover ${pkgname%-VCS}, I just forgot to change it to git.
I think configure flag --libexecdir is needed to put maynard executable
under /usr/lib/maynard. Without libexecdir, the resulting executable is
placed under /usr/libexec/maynard and it's kind of messy.
I should have tested the PKGBUILD under clean chroot to specify exact
dependencies.
Thanks for your feedback.
Re: [aur-general] maynard-git package review request
On 08/21/2016 06:39 AM, Alive 4ever wrote:
> Feel free to test this package. Remember to submit bug reports and
> feedback upstream. Patches and suggestions for improving PKGBUILD are
> welcome.
Why so many comments?
Other than that, it looks fine except for your usage of ${pkgname%-VCS}
instead of ${pkgname%-git} -- did you forget to customize that?
I would also include an empty line in between the Maintainer line and
the body of the PKGBUILD, for readability. Additionally, you can again
use ${pkgname%-git} in the url, to highlight the connection between the
upstream url and the package name, and use ${url} in the sources array.
Also note that git will by default clone the repo into the last url
component with the ".git" part trimmed off, so no need to manually
specify it.
...
How many of those configure flags are necessary? Most projects only need
the --prefix to be specified...
--
Eli Schwartz
[aur-general] maynard-git package review request
Hi aur! I am creating a new PKGBUILD[1] for maynard[2]. It's a new desktop shell for use with wayland display protocol. It's not a complete desktop environment. It's just a shell for use with weston compositor. The resulting pkg.tar.xz file is just 32KB. Maynard crashes frequently, so I wouldn't recommend it for use with important files. Some actions that triggered the crash: 1. Dragging any application window. 2. Interaction with Libreoffice menu using mouse pointer. 3. Another random mouse action. Feel free to test this package. Remember to submit bug reports and feedback upstream. Patches and suggestions for improving PKGBUILD are welcome. [1] https://aur.archlinux.org/packages/maynard-git/ [2] https://github.com/raspberrypi/maynard
