Re: TU Application - Antiz

[Robin Candau]

Le 16/01/2023 à 12:12, Jan Alexander Steffens (heftig) a écrit :
On Tue, Jan 3, 2023 at 12:03 PM Robin Candau 
 wrote:


- I maintain a few packages in the AUR with what I think are
high-quality/clean PKGBUILDs [1].

[1]

https://aur.archlinux.org/packages?O=0=M=Antiz==p=d=50=Go




Hi Robin,

Hi Jan!


I looked at your PKGBUILDs. In general, they look very good! I have a 
few questions:


Regarding clipboard and clipboard-git:
Doesn't setting CMAKE_C_FLAGS or CMAKE_CXX_FLAGS make it ignore the 
CFLAGS and CXXFLAGS in the environment?


Regarding unrar-free:
Doesn't passing CFLAGS to configure make it ignore the CFLAGS in the 
environment?


Indeed, I think you're right!

I corrected the clipboard, clipboard-git and unrar-free PKGBUILDs 
according to that, by adding the necessary flags to the existing 
environment variable in the build function like so: `export 
CFLAGS=${CLAFGS} -NEEDED_FLAG"`


Thanks for raising this!



Regarding ame and ame-git:
You export 'RUSTUP_TOOLCHAIN=nightly'. Does Amethyst require nightly 
Rust to build?


If it doesn't, it would break building on systems using rustup but 
only the stable toolchain installed.


If it does, I think you should makedepend on rustup and ensure the 
nightly toolchain is installed in prepare(). This would also allow it 
to build in clean chroots.


Regarding malachite:
You export 'RUSTUP_TOOLCHAIN=stable'. I think you should just let it 
use the default toolchain because the stable toolchain might not be 
installed and using a newer toolchain shouldn't break the build. (In 
general, I would expect the stable toolchain to be the default, to 
match the rust package.)


I discussed that subject with upstream and it appears that pointing to a 
specific toolchain for the build was initially implemented because it 
was historically needed for older versions of those packages. As seen 
with them, this is not required anymore so I could delete the "export 
RUSTUP_TOOLCHAIN" in both the "ame(-git)" and the "malachite" PKGBUILDs 
in order to use the default toolchain.


Once again, thanks for the suggestion!


Greetings,
Jan


--
Regards,
Robin



OpenPGP_0xD33FAA16B937F3B2.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature

Re: TU Application - Antiz

[Jan Alexander Steffens (heftig)]

On Tue, Jan 3, 2023 at 12:03 PM Robin Candau 
wrote:

> - I maintain a few packages in the AUR with what I think are
> high-quality/clean PKGBUILDs [1].
>
> [1]
> https://aur.archlinux.org/packages?O=0=M=Antiz==p=d=50=Go


Hi Robin,

I looked at your PKGBUILDs. In general, they look very good! I have a few
questions:

Regarding clipboard and clipboard-git:
Doesn't setting CMAKE_C_FLAGS or CMAKE_CXX_FLAGS make it ignore the CFLAGS
and CXXFLAGS in the environment?

Regarding unrar-free:
Doesn't passing CFLAGS to configure make it ignore the CFLAGS in the
environment?

Regarding ame and ame-git:
You export 'RUSTUP_TOOLCHAIN=nightly'. Does Amethyst require nightly Rust
to build?

If it doesn't, it would break building on systems using rustup but only the
stable toolchain installed.

If it does, I think you should makedepend on rustup and ensure the nightly
toolchain is installed in prepare(). This would also allow it to build in
clean chroots.

Regarding malachite:
You export 'RUSTUP_TOOLCHAIN=stable'. I think you should just let it use
the default toolchain because the stable toolchain might not be installed
and using a newer toolchain shouldn't break the build. (In general, I would
expect the stable toolchain to be the default, to match the rust package.)

Greetings,
Jan