Re: [aur-general] TU application: grawlinson

2021-04-20 Thread George Rawlinson via aur-general
On 21-04-19 18:52, Brett Cornwall via aur-general wrote:
> Hello, George! Nice to meet you.

Nice to meet you too! :)

> I took a look at some of your packages and have some feedback for you!
> 
> ansible-pacman_key
> 
> - I like that you added PGP signing since you're upstream as well.
> - License is GPL3, not GPL, which means GPLv2 or any later version [1].
> Just a nitpick.

Thanks for pointing that out, just updated the package.

I'm in the process of upstreaming this module into the community.general
collections, so hopefully it makes the cut soon. I just need a lot more
time. :)
 
> leocad
> 
> - Your cleanup commit makes great improvements when you adopted it.

I really enjoyed cleaning that particular package up. Nice to see my
adjustments are well received.
 
> libiconv
> 
> - Nice job adding PGP verification when adopting
> - HTTPS source can be used instead of HTTP

Updated source protocol, as well as leaving a note in the PKGBUILD
regarding the expired PGP signature. The last release was made prior to
the signature expiring, so hopefully upstream has a new signature by the
next release. It's a fairly stable package, so I don't expect a new
release anytime soon.
 
> The rest of the packages I viewed left me without comment, which is good.
> You've got a good grasp on best practices for packaging! I particularly like
> how you've heeded the tip on the PKGBUILD wiki page and extracted out an MIT
> license from a readme for a package without a dedicated file. :)

Trial and error. Mostly lots of error. I view packaging as a sort of
puzzle to solve iteratively. It is enjoyable most of the time.

> Overall, it looks very good! I've noticed that your commit messages are
> generally unhelpful, though: They often use a stock "upgpkg: blah" rather
> than actually telling what work was done.

That's actually a fair criticism, which I've used to improve the git log
for the package updates that I've specifically mentioned above.

> I also took a look at the packages you maintain and intend on bringing into
> [community]. Most of those Go packages download vendor libraries on
> buildtime. The Go package guidelines [2] make no mention of vendoring so I'd
> like to get some clarification from someone else on whether or not this is
> kosher.

About that ... ^W^W^W

I see Foxboron has answered that for me. \o/


signature.asc
Description: PGP signature


Re: [aur-general] TU application: grawlinson

2021-04-20 Thread Morten Linderud via aur-general
On Mon, Apr 19, 2021 at 06:52:27PM -0700, Brett Cornwall via aur-general wrote:
> I also took a look at the packages you maintain and intend on bringing into
> [community]. Most of those Go packages download vendor libraries on
> buildtime. The Go package guidelines [2] make no mention of vendoring so I'd
> like to get some clarification from someone else on whether or not this is
> kosher.

Go is in the same camp as with other modern languages like Rust. Devendoring
libraries is simply (sadly?) too much effort to be reasonably handled by a
distribution without spending a *lot* of effort on tooling to deal with it
appropriately. It's not a good development but you would be fighting against the
ecosystem.

Completely kosher in other words :)

-- 
Morten Linderud
PGP: 9C02FF419FECBE16


signature.asc
Description: PGP signature


Re: [aur-general] TU application: grawlinson

2021-04-19 Thread Brett Cornwall via aur-general

On 2021-04-11 03:21, George Rawlinson via aur-general wrote:

Hello everyone!

My name is George Rawlinson (grawlinson), and I am applying to be a
Trusted User. My sponsors are Morten Linderud (Foxboron) and
Sven-Hendrik Haase (svenstaro). They have evaluated my PKGBUILDs and
quickly come to the conclusion that they are considered a crime against
humanity, but feel free to offer your own opinions. Feedback is always
great! Especially if there's something I've overlooked.
[...]


Hello, George! Nice to meet you.

I took a look at some of your packages and have some feedback for you!

ansible-pacman_key

- I like that you added PGP signing since you're upstream as well.
- License is GPL3, not GPL, which means GPLv2 or any later version [1]. 
  Just a nitpick.


leocad

- Your cleanup commit makes great improvements when you adopted it.

libiconv

- Nice job adding PGP verification when adopting
- HTTPS source can be used instead of HTTP


The rest of the packages I viewed left me without comment, which is 
good. You've got a good grasp on best practices for packaging! I 
particularly like how you've heeded the tip on the PKGBUILD wiki page 
and extracted out an MIT license from a readme for a package without a 
dedicated file. :)


Overall, it looks very good! I've noticed that your commit messages are 
generally unhelpful, though: They often use a stock "upgpkg: blah" 
rather than actually telling what work was done.



I also took a look at the packages you maintain and intend on bringing 
into [community]. Most of those Go packages download vendor libraries on 
buildtime. The Go package guidelines [2] make no mention of vendoring so 
I'd like to get some clarification from someone else on whether or not 
this is kosher.





[1] https://wiki.archlinux.org/index.php/PKGBUILD#license
[2] https://wiki.archlinux.org/index.php/Go_package_guidelines


signature.asc
Description: PGP signature


Re: [aur-general] TU application: grawlinson

2021-04-11 Thread Sven-Hendrik Haase via aur-general

On 11.04.21 05:21, George Rawlinson via aur-general wrote:

Hello everyone!

My name is George Rawlinson (grawlinson), and I am applying to be a
Trusted User. My sponsors are Morten Linderud (Foxboron) and
Sven-Hendrik Haase (svenstaro). They have evaluated my PKGBUILDs and
quickly come to the conclusion that they are considered a crime against
humanity, but feel free to offer your own opinions. Feedback is always
great! Especially if there's something I've overlooked.

I've been distro hopping too many times to count, but have comfortably
settled on Arch Linux since circa 2015. I have always loved tinkering
with software, and Linux provides one of the best ecosystems for that.
It all started back in 2009 when I started self-hosting my mail
domain(s) on a Debian VPS, which was migrated over to Arch once I became
proficient/comfortable enough. My Arch-specific installations have since
ballooned from that one VPS to an ex-enterprise server at home, running
a large set of LXD containers that provide a variety of services to make
my life somewhat easier.

I maintain my own pacman repository for convenience; it is essentially a
private git repository made up of git submodules (for AUR packages) as
well as forked/new packages. To make maintenance easier I extensively
rely on nvchecker, to keep on top of new releases. aurutils/devtools to
build/test packages in a clean chroot. Additionally, namcap helps me
figure out when I've invoked Cthulhu.

Contributions:

- Maintainer of some AUR packages since 2016[0]
- Hosted a Tier-2 mirror from 2017[1] to 2019[2] on a Hetzner VPS
- Flung some patches at the namcap & infrastructure repos
- Filed bug reports/patches for various upstream projects and on
   the Arch bug tracker
- Member of the Arch Testing Team since sometime last year (2020)

Packages to (hopefully) transfer to community:

- distrobuilder (would be co-maintained with Foxboron)
- promscale & promscale_extension
- prometheus-apcupsd-exporter
- prometheus-snmp-exporter
- prometheus-ipmi-exporter (and its freeipmi dependency, which
   I also co-maintain)

There are some things I'd like to become more involved in:

- Monitoring the bug tracker for issues that I can help with
- Co-maintaining some LX{C,D} and Prometheus/Timescale related packages
- Learning more about the overall tasks that TUs perform so I can decide
   where I can best focus my efforts.

It all comes down to Arch having made such a positive impact in my life,
and I believe it is past due that I start contributing back.

Regards,
George Rawlinson

[0]: https://aur.archlinux.org/packages/?SeB=M=grawlinson
[1]: https://bugs.archlinux.org/task/52852
[2]: 
https://lists.archlinux.org/pipermail/arch-mirrors-announce/2019-May/33.html


I confirm my sponsorship!




OpenPGP_signature
Description: OpenPGP digital signature


Re: [aur-general] TU application: grawlinson

2021-04-11 Thread Morten Linderud via aur-general
On Sun, Apr 11, 2021 at 03:21:37AM +, George Rawlinson via aur-general 
wrote:
> Hello everyone!
> 
> My name is George Rawlinson (grawlinson), and I am applying to be a
> Trusted User. My sponsors are Morten Linderud (Foxboron) and
> Sven-Hendrik Haase (svenstaro). They have evaluated my PKGBUILDs and
> quickly come to the conclusion that they are considered a crime against
> humanity, but feel free to offer your own opinions. Feedback is always
> great! Especially if there's something I've overlooked.
> 
> I've been distro hopping too many times to count, but have comfortably
> settled on Arch Linux since circa 2015. I have always loved tinkering
> with software, and Linux provides one of the best ecosystems for that.
> It all started back in 2009 when I started self-hosting my mail
> domain(s) on a Debian VPS, which was migrated over to Arch once I became
> proficient/comfortable enough. My Arch-specific installations have since
> ballooned from that one VPS to an ex-enterprise server at home, running
> a large set of LXD containers that provide a variety of services to make
> my life somewhat easier.
> 
> I maintain my own pacman repository for convenience; it is essentially a
> private git repository made up of git submodules (for AUR packages) as
> well as forked/new packages. To make maintenance easier I extensively
> rely on nvchecker, to keep on top of new releases. aurutils/devtools to
> build/test packages in a clean chroot. Additionally, namcap helps me
> figure out when I've invoked Cthulhu.
> 
> Contributions:
> 
> - Maintainer of some AUR packages since 2016[0]
> - Hosted a Tier-2 mirror from 2017[1] to 2019[2] on a Hetzner VPS
> - Flung some patches at the namcap & infrastructure repos
> - Filed bug reports/patches for various upstream projects and on
>   the Arch bug tracker
> - Member of the Arch Testing Team since sometime last year (2020)
> 
> Packages to (hopefully) transfer to community:
> 
> - distrobuilder (would be co-maintained with Foxboron)
> - promscale & promscale_extension
> - prometheus-apcupsd-exporter
> - prometheus-snmp-exporter
> - prometheus-ipmi-exporter (and its freeipmi dependency, which
>   I also co-maintain)
> 
> There are some things I'd like to become more involved in:
> 
> - Monitoring the bug tracker for issues that I can help with
> - Co-maintaining some LX{C,D} and Prometheus/Timescale related packages
> - Learning more about the overall tasks that TUs perform so I can decide
>   where I can best focus my efforts.
> 
> It all comes down to Arch having made such a positive impact in my life,
> and I believe it is past due that I start contributing back.
> 
> Regards,
> George Rawlinson
> 
> [0]: https://aur.archlinux.org/packages/?SeB=M=grawlinson
> [1]: https://bugs.archlinux.org/task/52852
> [2]: 
> https://lists.archlinux.org/pipermail/arch-mirrors-announce/2019-May/33.html


I confirm my sponsorship :) 

George has helped test lxd when I was doing the original packages for the
repositories and has generally been maintaining several packages in the AUR i
have adopted into the repositories. The overall quality is good and he seems
like a great person.

I'm confident they are going to make a good addition to the team!

-- 
Morten Linderud
PGP: 9C02FF419FECBE16


signature.asc
Description: PGP signature