Re: permissions on autom4te.cache/ ?

2009-11-26 Thread Olly Betts
On 2009-11-24, Ralf Wildenhues ralf.wildenh...@gmx.de wrote:
 -mkdir $cache, 0755
 +mkdir $cache

The umask argument to mkdir is required by older versions of Perl.  I think
it became optional in 5.6.  I'm not sure if automake has a minimum Perl
version it aims to support (it doesn't seem to declare on in the script
itself in the latest version I have installed), but I notice NEWS says a
Perl-5.6-ism was fixed in 1.8.3.

Anyway, omitting the argument is documented as being the same as passing
0777 for it, so it's probably better to just specify it...

Cheers,
Olly





Re: permissions on autom4te.cache/ ?

2009-11-24 Thread Ralf Wildenhues
[ adding autoconf-patches ]

Hello Harlan,

thanks for the report.

* Harlan Stenn wrote on Sat, Nov 14, 2009 at 08:28:18AM CET:
 I'm real careful to set my umask to 2, as it is Important that
 directories and files I create are able to be modified by others in the
 group.
 
 autom4te.cache/ is created with 755 perms.
 
 Is there a good reason why my umask is being ignored when this directory
 is being created?
 
 This is definitely going on with 2.59, 2.61, and 2.64.

The
  mkdir $cache, 0755

line has been in autom4te.in ever since that file was written.  I'm not
sure why.  Surely the user can just adjust her umask if she wants more
restrictive permissions, and should probably do so if she puts the cache
directory below, say, /tmp.

As a workaround, you should be able to just pre-create the cache
directory, or turn off caching altogether, see 'info Autoconf
Customizing autom4te'.

OK to install?

Cheers,
Ralf

Let umask govern permissions for autom4te.cache directory.

* bin/autom4te.in: Do not pass 0755 permissions to mkdir of
the cache directory.
Report by Harlan Stenn.

diff --git a/bin/autom4te.in b/bin/autom4te.in
index 2e7fc04..a51fa99 100644
--- a/bin/autom4te.in
+++ b/bin/autom4te.in
@@ -972,7 +972,7 @@ if ($freeze)
 # We need our cache directory.  Don't fail with parallel creation.
 if (! -d $cache)
   {
-mkdir $cache, 0755
+mkdir $cache
   or -d $cache
   or fatal cannot create $cache: $!;
   }




Re: permissions on autom4te.cache/ ?

2009-11-24 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

According to Ralf Wildenhues on 11/24/2009 7:44 AM:
 The
   mkdir $cache, 0755
 
 line has been in autom4te.in ever since that file was written.

 OK to install?
 
 Cheers,
 Ralf
 
 Let umask govern permissions for autom4te.cache directory.

Looks fine to me, but it probably warrants a NEWS entry.

- --
Don't work too hard, make some time for fun as well!

Eric Blake e...@byu.net
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksMvqAACgkQ84KuGfSFAYA+2gCgk1OuW8AXqCrN/oZj98S+nJNM
kJMAoMmMsKlOVYiUn6ZR6CTej/qG1WCG
=MZoZ
-END PGP SIGNATURE-