Re: [PATCH] Output files with LF only

[Akim Demaille]

> "Morten" == Morten Eriksen <[EMAIL PROTECTED]> writes:

Morten> Hi, someone mis-applied my patch so that ``binmode'' was set

s/someone/akim/

Morten> _after_ Automake had opened a file for writing.

Sorry Morten, I'm applying your patch.  Thanks!

[PATCH] Output files with LF only

[Morten Eriksen]

Hi,

someone mis-applied my patch so that ``binmode'' was set _after_
Automake had opened a file for writing.

Regards,
Morten



Index: ChangeLog
===
RCS file: /cvs/automake/automake/ChangeLog,v
retrieving revision 1.904
diff -u -r1.904 ChangeLog
--- ChangeLog   2000/10/23 18:58:33 1.904
+++ ChangeLog   2000/11/15 11:41:42
@@ -1,3 +1,8 @@
+2000-11-15  Morten Eriksen  <[EMAIL PROTECTED]>
+
+   * aclocal.in (write_aclocal): Set ``binmode'' after file has been
+   opened, otherwise it has no effect.
+
 2000-10-23  Morten Eriksen  <[EMAIL PROTECTED]>
 
* aclocal.in (write_aclocal): Don't write aclocal.m4 with
Index: aclocal.in
===
RCS file: /cvs/automake/automake/aclocal.in,v
retrieving revision 1.49
diff -u -r1.49 aclocal.in
--- aclocal.in  2000/10/23 18:58:33 1.49
+++ aclocal.in  2000/11/15 11:41:44
@@ -427,6 +427,8 @@
 
 print STDERR "Writing $output_file\n" if $verbosity;
 
+open (ACLOCAL, "> " . $output_file)
+   || die "aclocal: couldn't open \`$output_file' for writing: $!\n";
 
 # In case we're running under MSWindows, don't write with CRLF.
 # (This circumvents a bug in at least Cygwin bash where the shell
@@ -434,8 +436,6 @@
 # and CRLF.)
 binmode ACLOCAL;
 
-open (ACLOCAL, "> " . $output_file)
-   || die "aclocal: couldn't open \`$output_file' for writing: $!\n";
 print ACLOCAL "# $output_file generated automatically by aclocal $VERSION\n";
 print ACLOCAL "\
 # Copyright 1994, 1995, 1996, 1997, 1998, 1999, 2000