Re: Patch 3 of 4: Avoid 8+3 filename trouble
Tom Tromey wrote: > > "Tim" == Tim Van Holder <[EMAIL PROTECTED]> writes: > > Tim> 2001-02-10 Tim Van Holder <[EMAIL PROTECTED]> > > Tim>* remake-hdr.am (@STAMP@): Use .T as suffix for the > Tim>temporary file. > > I don't think this is sufficient. I think you also have to change > AM_CONFIG_HEADER as well. See m4/header.m4. Which is already broken and effectively unused. The only reason things were working is that the make targets recreated the stamp files anyhow. I've submitted a patch to fix this already. Derek -- Derek Price CVS Solutions Architect ( http://CVSHome.org ) mailto:[EMAIL PROTECTED] OpenAvenue ( http://OpenAvenue.com ) -- "It's difficult to work in a group when you're omnipotent." -Q, "Deja Q"
Re: Patch 3 of 4: Avoid 8+3 filename trouble
> "Tim" == Tim Van Holder <[EMAIL PROTECTED]> writes: Tim> 2001-02-10 Tim Van Holder <[EMAIL PROTECTED]> Tim>* remake-hdr.am (@STAMP@): Use .T as suffix for the Tim>temporary file. I don't think this is sufficient. I think you also have to change AM_CONFIG_HEADER as well. See m4/header.m4. Tom
Re: Small autoreconf patch (was Re: Patch 3 of 4: Avoid 8+3 filename trouble)
On Feb 11, 2001, "Tim Van Holder" <[EMAIL PROTECTED]> wrote:
>> >* remake-hdr.am (@STAMP@): Use .T as suffix for the
>> >temporary file.
>>
>> You should probably patch autoconf's autoreconf too.
> What part would need patching?
The one that choose stamp file names like those created by automake.
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicampoliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist*Please* write to mailing lists, not to me
Small autoreconf patch (was Re: Patch 3 of 4: Avoid 8+3 filename trouble)
> > * remake-hdr.am (@STAMP@): Use .T as suffix for the
> > temporary file.
>
> You should probably patch autoconf's autoreconf too.
What part would need patching? AFAICS, it does not use
names with multiple dots or with conflicting 8+3 names.
The only changes my local autoreconf currently has are
listed below; I don't think they're critical, but they
might as well go in.
2001-02-11 Tim Van Holder <[EMAIL PROTECTED]>
* autoreconf.sh: Improve support for DOS paths.
Index: autoreconf.sh
===
RCS file: /cvs/autoconf/autoreconf.sh,v
retrieving revision 1.67
diff -u -r1.67 autoreconf.sh
--- autoreconf.sh 2001/02/01 23:23:57 1.67
+++ autoreconf.sh 2001/02/11 19:44:00
@@ -17,7 +17,7 @@
# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
# 02111-1307, USA.
-me=`echo "$0" | sed -e 's,.*/,,'`
+me=`echo "$0" | sed -e 's,.*[\\/],,'`
usage="\
Usage: $0 [OPTION] ... [TEMPLATE-FILE]
@@ -91,7 +91,7 @@
# Variables.
: ${autoconf_dir=${AC_MACRODIR=@datadir@}}
debug=false
-dir=`echo "$0" | sed -e 's,[^/]*$,,'`
+dir=`echo "$0" | sed -e 's,[^\\/]*$,,'`
force=false
# --install -- as --add-missing in other tools.
install=false
@@ -375,6 +375,7 @@
templates=`$autoconf -t 'AC_CONFIG_HEADERS:$1'`
if test -n "$templates"; then
tcount=`set -- $templates; echo $#`
+# This will likely need some patching for DOS paths
template=`set -- $templates; echo $1 | sed '
s/.*://
t colon
@@ -382,7 +383,7 @@
: colon
s/:.*//
'`
-template_dir=`echo $template | sed 's,/*[^/]*$,,;s,^$,.,'`
+template_dir=`echo $template | sed -e 's,[\\/]*[^\\/]*$,,;s,^$,.,'`
stamp_num=`test "$tcount" -gt 1 && echo "$tcount"`
stamp=$template_dir/stamp-h$stamp_num.in
# If config.hin exists, don't override it unless it was really
Re: Patch 3 of 4: Avoid 8+3 filename trouble
On Feb 10, 2001, "Tim Van Holder" <[EMAIL PROTECTED]> wrote:
> * remake-hdr.am (@STAMP@): Use .T as suffix for the
> temporary file.
You should probably patch autoconf's autoreconf too.
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicampoliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist*Please* write to mailing lists, not to me
Patch 3 of 4: Avoid 8+3 filename trouble
stamp-h1 and stamp-h1T resolve to the same file name on MSDOS, so use stamp-h1.T instead. Note that problems will still arise if stamp-h1 and stamp-h10 need to be present in the same directory. 2001-02-10 Tim Van Holder <[EMAIL PROTECTED]> * remake-hdr.am (@STAMP@): Use .T as suffix for the temporary file. Index: remake-hdr.am === RCS file: /cvs/automake/remake-hdr.am,v retrieving revision 1.30 diff -u -r1.30 remake-hdr.am --- remake-hdr.am 2001/01/16 11:15:21 1.30 +++ remake-hdr.am 2001/02/10 21:25:16 @@ -23,17 +23,17 @@ else :; fi ## Explicitly look in srcdir for benefit of non-GNU makes. @STAMP@: $(srcdir)/@CONFIG_HEADER_IN@ $(top_builddir)/config.status - @rm -f @STAMP@ @STAMP@T + @rm -f @STAMP@ @STAMP@.T ## We used to try to get a real timestamp here. But the fear is that ## that will cause unnecessary cvs conflicts - @echo timestamp > @STAMP@T 2> /dev/null + @echo timestamp > @STAMP@.T 2> /dev/null cd $(top_builddir) \ && CONFIG_FILES= CONFIG_HEADERS=@CONFIG_HEADER_FULL@ \ $(SHELL) ./config.status ## Creating the timestamp first, and moving it later, helps ensure that ## it will be older than the header file, avoiding needless triggering ## of the rebuild rule. - @mv @STAMP@T @STAMP@ + @mv @STAMP@.T @STAMP@ ## Explicitly look in srcdir for benefit of non-GNU makes. ## SRC_STAMP takes into account a possible subdir where CONFIG_HEADER_IN is $(srcdir)/@CONFIG_HEADER_IN@: @MAINTAINER_MODE_TRUE@$(srcdir)/@SRC_STAMP@.in
