Re: Small autoreconf patch
> "Tim" == Tim Van Holder <[EMAIL PROTECTED]> writes: Tim> a) how likely is it that tcount becomes 10 or more? Very unlikely. Tim> b) what impact does using a different name (e.g. st-h-$stamp.in) Tim> have? Probably none. Unless of course somebody is relying on the names and we don't know. Tom
Re: Small autoreconf patch
Tim Van Holder wrote: > >> >* remake-hdr.am (@STAMP@): Use .T as suffix for the > >> >temporary file. > >> > >> You should probably patch autoconf's autoreconf too. > > > > > What part would need patching? > > > > The one that choose stamp file names like those created by automake. > > Right - I hadn't noticed this: > > stamp_num=`test "$tcount" -gt 1 && echo "$tcount"` > stamp=$template_dir/stamp-h$stamp_num.in > > once tcount becomes larger than 9, there are potential problems. > > Now: > a) how likely is it that tcount becomes 10 or more? When AM_CONFIG_HEADER is called on more than 9 headers. > b) what impact does using a different name (e.g. st-h-$stamp.in) > have? Jut namespace impact and aestetic concerns, I believe, but you may want to hear from someone else on this one. Derek -- Derek Price CVS Solutions Architect ( http://CVSHome.org ) mailto:[EMAIL PROTECTED] OpenAvenue ( http://OpenAvenue.com ) -- I don't know what's right any longer! You have to think for both of us - for all of us! - Ingrid Bergman as Elsa, _Casablanca_
Re: Small autoreconf patch
>> >* remake-hdr.am (@STAMP@): Use .T as suffix for the >> >temporary file. >> >> You should probably patch autoconf's autoreconf too. > > > What part would need patching? > > The one that choose stamp file names like those created by automake. Right - I hadn't noticed this: stamp_num=`test "$tcount" -gt 1 && echo "$tcount"` stamp=$template_dir/stamp-h$stamp_num.in once tcount becomes larger than 9, there are potential problems. Now: a) how likely is it that tcount becomes 10 or more? b) what impact does using a different name (e.g. st-h-$stamp.in) have?
Re: Small autoreconf patch (was Re: Patch 3 of 4: Avoid 8+3 filename trouble)
On Feb 11, 2001, "Tim Van Holder" <[EMAIL PROTECTED]> wrote:
>> >* remake-hdr.am (@STAMP@): Use .T as suffix for the
>> >temporary file.
>>
>> You should probably patch autoconf's autoreconf too.
> What part would need patching?
The one that choose stamp file names like those created by automake.
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicampoliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist*Please* write to mailing lists, not to me
Small autoreconf patch (was Re: Patch 3 of 4: Avoid 8+3 filename trouble)
> > * remake-hdr.am (@STAMP@): Use .T as suffix for the
> > temporary file.
>
> You should probably patch autoconf's autoreconf too.
What part would need patching? AFAICS, it does not use
names with multiple dots or with conflicting 8+3 names.
The only changes my local autoreconf currently has are
listed below; I don't think they're critical, but they
might as well go in.
2001-02-11 Tim Van Holder <[EMAIL PROTECTED]>
* autoreconf.sh: Improve support for DOS paths.
Index: autoreconf.sh
===
RCS file: /cvs/autoconf/autoreconf.sh,v
retrieving revision 1.67
diff -u -r1.67 autoreconf.sh
--- autoreconf.sh 2001/02/01 23:23:57 1.67
+++ autoreconf.sh 2001/02/11 19:44:00
@@ -17,7 +17,7 @@
# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
# 02111-1307, USA.
-me=`echo "$0" | sed -e 's,.*/,,'`
+me=`echo "$0" | sed -e 's,.*[\\/],,'`
usage="\
Usage: $0 [OPTION] ... [TEMPLATE-FILE]
@@ -91,7 +91,7 @@
# Variables.
: ${autoconf_dir=${AC_MACRODIR=@datadir@}}
debug=false
-dir=`echo "$0" | sed -e 's,[^/]*$,,'`
+dir=`echo "$0" | sed -e 's,[^\\/]*$,,'`
force=false
# --install -- as --add-missing in other tools.
install=false
@@ -375,6 +375,7 @@
templates=`$autoconf -t 'AC_CONFIG_HEADERS:$1'`
if test -n "$templates"; then
tcount=`set -- $templates; echo $#`
+# This will likely need some patching for DOS paths
template=`set -- $templates; echo $1 | sed '
s/.*://
t colon
@@ -382,7 +383,7 @@
: colon
s/:.*//
'`
-template_dir=`echo $template | sed 's,/*[^/]*$,,;s,^$,.,'`
+template_dir=`echo $template | sed -e 's,[\\/]*[^\\/]*$,,;s,^$,.,'`
stamp_num=`test "$tcount" -gt 1 && echo "$tcount"`
stamp=$template_dir/stamp-h$stamp_num.in
# If config.hin exists, don't override it unless it was really
