Re: armflang: error: unknown argument: '-soname'

2023-10-22 Thread Shterenlikht, Anton


> On 22 Oct 2023, at 22:28, Karl Berry  wrote:
> 
>While libtool has a new maintainer (Alex Ameen), essentially nothing
>happens, which is quite unfortunate...
> 
> 1) libtool 2.4.7 was released in March 2022

correct.
However https://www.gnu.org/software/libtool/
still says:

Latest stable release:  libtool-2.4.6.tar.gz

Anton



smime.p7s
Description: S/MIME cryptographic signature


Re: armflang: error: unknown argument: '-soname'

2023-10-22 Thread Werner LEMBERG


> While libtool has a new maintainer (Alex Ameen), essentially
> nothing happens, which is quite unfortunate...
> 
> 1) libtool 2.4.7 was released in March 2022 (I don't know if Alex did
>it),

He did.

> 2) When a package appears to be unmaintained, the first thing to do
>[...]

Thanks for this guide.  Hopefully, people who want to have patches
added to the libtool git repository will follow this.


Werner



Re: armflang: error: unknown argument: '-soname'

2023-10-22 Thread Karl Berry
While libtool has a new maintainer (Alex Ameen), essentially nothing
happens, which is quite unfortunate...

1) libtool 2.4.7 was released in March 2022 (I don't know if Alex did
it), which isn't so terribly long ago. Sure, maintainers should at least
confirm bug reports and patches, even if releases don't happen quickly
(pace my own efforts with automake), but ...

2) When a package appears to be unmaintained, the first thing to do is
simply write the maintainer to see what the story is. If there is no
response, the next step is to write maintain...@gnu.org. It's their
responsibility to make continued efforts to contact the maintainer, up
to and including sending paper mail. And look for a new maintainer if
need be.

3) If that also fails, the final fallback is to write
gnu-advis...@gnu.org and/or r...@gnu.org.

Best,
Karl



Re: armflang: error: unknown argument: '-soname'

2023-10-22 Thread Anthony Scemama
Great! Thanks!

On Sun, 2023-10-22 at 15:02 +, Shterenlikht, Anton wrote:
> I confirm that the patch still works against
> today's git version:
> 
> $ libtool --version
> libtool (GNU libtool) 2.4.7.4-1ec8f
> 
> I just added "flang*" in addition to "armflang*":
> 
> https://savannah.gnu.org/support/index.php?110947
> 
> I'm also asking in libt...@gnu.org why 2.4.6 is still
> the latest stable relase, if the dev branch is
> already at 2.4.7.4.
> 
> Anton
> 
> 
> 
> > On 22 Oct 2023, at 14:22, Werner LEMBERG  wrote:
> > 
> > 
> > > here is a patch for libtool that Francois Coppens and I submitted
> > > to
> > > libtool in February. I think we did something went wrong in the
> > > PR
> > > process because it has still not been included... [...]
> > 
> > While libtool has a new maintainer (Alex Ameen), essentially
> > nothing
> > happens, which is quite unfortunate...
> > 
> > 
> >Werner




Re: armflang: error: unknown argument: '-soname'

2023-10-22 Thread Shterenlikht, Anton
I confirm that the patch still works against
today's git version:

$ libtool --version
libtool (GNU libtool) 2.4.7.4-1ec8f

I just added "flang*" in addition to "armflang*":

https://savannah.gnu.org/support/index.php?110947

I'm also asking in libt...@gnu.org why 2.4.6 is still
the latest stable relase, if the dev branch is
already at 2.4.7.4.

Anton



> On 22 Oct 2023, at 14:22, Werner LEMBERG  wrote:
> 
> 
>> here is a patch for libtool that Francois Coppens and I submitted to
>> libtool in February. I think we did something went wrong in the PR
>> process because it has still not been included... [...]
> 
> While libtool has a new maintainer (Alex Ameen), essentially nothing
> happens, which is quite unfortunate...
> 
> 
>Werner



smime.p7s
Description: S/MIME cryptographic signature


Re: armflang: error: unknown argument: '-soname'

2023-10-22 Thread Werner LEMBERG


> here is a patch for libtool that Francois Coppens and I submitted to
> libtool in February. I think we did something went wrong in the PR
> process because it has still not been included... [...]

While libtool has a new maintainer (Alex Ameen), essentially nothing
happens, which is quite unfortunate...


Werner



Re: armflang: error: unknown argument: '-soname'

2023-10-22 Thread Anthony Scemama
Dear Anton,

here is a patch for libtool that Francois Coppens and I submitted to
libtool in February. I think we did something went wrong in the PR
process because it has still not been included... Maybe you can submit
it again to the libtool team, it is not a big change and it is quite
important for us too to have this patch included.

best,

Anthony


$ git diff 1ec8fa28dcb29500d485c136db28315671ec4c3b
diff --git a/m4/libtool.m4 b/m4/libtool.m4
index 79a2451e..df1a7860 100644
--- a/m4/libtool.m4
+++ b/m4/libtool.m4
@@ -4719,6 +4719,12 @@ m4_if([$1], [CXX], [
_LT_TAGVAR(lt_prog_compiler_pic, $1)='-fPIC'
_LT_TAGVAR(lt_prog_compiler_static, $1)='-static'
 ;;
+  # ARM flang
+  armflang*)
+_LT_TAGVAR(lt_prog_compiler_wl, $1)='-Wl,'
+_LT_TAGVAR(lt_prog_compiler_pic, $1)='-fPIC'
+_LT_TAGVAR(lt_prog_compiler_static, $1)='-static'
+;;
   # Lahey Fortran 8.1.
   lf95*)
_LT_TAGVAR(lt_prog_compiler_wl, $1)='-Wl,'





On Fri, 2023-10-20 at 10:47 +, Shterenlikht, Anton wrote:
> This seems like an automake issue, not libtool.
> 
> The libtool produced by running configure has:
> 
> 11661 # ### BEGIN LIBTOOL TAG CONFIG: FC
> 11662 
> 11663 # The linker used to build libraries.
> 11664 LD="/arm-compiler-for-linux_23.10_AmazonLinux-2/gcc-
> 12.2.0_AmazonLinux-2/aarch64-linux-gnu/bin/ld"
> 11665 
> 11666 # How to create reloadable object files.
> 11667 reload_flag=" -r"
> 11668 reload_cmds="\$LD\$reload_flag -o \$output\$reload_objs"
> 11669 
> 11670 # Commands used to build an old-style archive.
> 11671 old_archive_cmds="\$AR \$AR_FLAGS \$oldlib\$oldobjs~\$RANLIB
> \$tool_oldlib"
> 11672 
> 11673 # A language specific compiler.
> 11674 CC="armflang"
> 11675 
> 11676 # Is the compiler the GNU compiler?
> 11677 with_gcc=no
> 11678 
> 11679 # Compiler flag to turn off builtin functions.
> 11680 no_builtin_flag=""
> 11681 
> 11682 # Additional compiler flags for building library objects.
> 11683 pic_flag=""
> 11684 
> 11685 # How to pass a linker flag through the compiler.
> 11686 wl=""
> 
> Note that wl= is emtpy.
> 
> Compare with the portion of this file for C compiler:
> 
>   317 # A language specific compiler.
>   318 CC="mpicc"
>   319 
>   320 # Is the compiler the GNU compiler?
>   321 with_gcc=yes
>   322 
>   323 # Compiler flag to turn off builtin functions.
>   324 no_builtin_flag=" -fno-builtin -fno-rtti -fno-exceptions"
>   325 
>   326 # Additional compiler flags for building library objects.
>   327 pic_flag=" -fPIC -DPIC"
>   328 
>   329 # How to pass a linker flag through the compiler.
>   330 wl="-Wl,"
> 
> 
> This simple patch works:
> 
> sed -i 's|wl=""|wl="-Wl,"|' libtool
> 
> and gives:
> 
> libtool: link: armflang -shared   -g -fopenmp
> -mcpu=neoverse-512tvb -march=armv8.4-a+sve   -fopenmp -Wl,-soname
> -Wl,libp2.so.0 -o .libs/libp2.so.0.0.0
> 
> However, this crude hack will not work with "make distcheck",
> because it will generate a new libtool.
> 
> Still, I'm trying to understand if this is a bug in autotools,
> and if there is a workaround via edits in configure.ac and/or
> Makefile.am.
> 
> Thank you
> 
> Anton
> 
> > On 20 Oct 2023, at 08:40, Shterenlikht, Anton <
> > shterenli...@par-tec.com> wrote:
> > 
> > [also posted in libt...@gnu.org]
> > 
> > Please help me understand how to deal correctly with this error:
> > 
> > libtool: link: armflang -shared-g   -soname 
> > libp2.so.0 -o .libs/libp2.so.0.0.0
> > armflang: error: unknown argument: '-soname'
> > 
> > 
> > I see this issue mentioned in multiple places, e.g:
> > 
> > https://github.com/HDFGroup/hdf5/issues/366
> > 
> > with the solution that "-Wl," must be prepended somehow to "-
> > soname".
> > 
> > But I'm not sure what changes I need to do
> > to my configure.ac and/or Makefile.am
> > to fix this correctly.
> > 
> > For comparison, here's how the same line looks like when
> > I use gfortran:
> > 
> > libtool: link: gfortran -shared  -fPIC  -g
> > -O2   -Wl,-soname -Wl,libp2.so.0 -o .libs/libp2.so.0.0.0
> > 
> > 
> > Thank you
> > 
> > Anton
> 
> 




Re: armflang: error: unknown argument: '-soname'

2023-10-22 Thread Shterenlikht, Anton
Karl, thank you

I submitted a bug report with a reproducer:

https://savannah.gnu.org/support/index.php?110947

Anton


> On 21 Oct 2023, at 22:48, Karl Berry  wrote:
> 
> Hi Anton - thanks for the report.
> 
>https://github.com/HDFGroup/hdf5/issues/366
>with the solution that "-Wl," must be prepended somehow to "-soname".
> 
> Why do you think this is not a libtool issue?  Isn't it libtool's job to
> figure out the arguments that need to be passed? The fact that the -Wl
> is provided for gfortran and not for armflang makes me think even more
> that it is libtool. At first glance, the string "soname" does not appear
> in the Automake sources.
> 
>But I'm not sure what changes I need to do
>to my configure.ac and/or Makefile.am
>to fix this correctly.
> 
> I wish I had a workaround for you, but I just don't know the answer.
> Someone else here probably knows better, else I suggest posting to
> bug-libt...@gnu.org, ideally with a reproducible case.
> 
> Happy linking,
> Karl



smime.p7s
Description: S/MIME cryptographic signature


Re: armflang: error: unknown argument: '-soname'

2023-10-21 Thread Karl Berry
Hi Anton - thanks for the report.

https://github.com/HDFGroup/hdf5/issues/366
with the solution that "-Wl," must be prepended somehow to "-soname".

Why do you think this is not a libtool issue?  Isn't it libtool's job to
figure out the arguments that need to be passed? The fact that the -Wl
is provided for gfortran and not for armflang makes me think even more
that it is libtool. At first glance, the string "soname" does not appear
in the Automake sources.

But I'm not sure what changes I need to do
to my configure.ac and/or Makefile.am
to fix this correctly.

I wish I had a workaround for you, but I just don't know the answer.
Someone else here probably knows better, else I suggest posting to
bug-libt...@gnu.org, ideally with a reproducible case.

Happy linking,
Karl



armflang: error: unknown argument: '-soname'

2023-10-20 Thread Shterenlikht, Anton
[also posted in libt...@gnu.org]

Please help me understand how to deal correctly with this error:

libtool: link: armflang -shared-g   -soname libp2.so.0 
-o .libs/libp2.so.0.0.0
armflang: error: unknown argument: '-soname'


I see this issue mentioned in multiple places, e.g:

https://github.com/HDFGroup/hdf5/issues/366

with the solution that "-Wl," must be prepended somehow to "-soname".

But I'm not sure what changes I need to do
to my configure.ac and/or Makefile.am
to fix this correctly.

For comparison, here's how the same line looks like when
I use gfortran:

libtool: link: gfortran -shared  -fPIC  -g -O2   
-Wl,-soname -Wl,libp2.so.0 -o .libs/libp2.so.0.0.0


Thank you

Anton

smime.p7s
Description: S/MIME cryptographic signature


Re: armflang: error: unknown argument: '-soname'

2023-10-20 Thread Shterenlikht, Anton
This seems like an automake issue, not libtool.

The libtool produced by running configure has:

11661 # ### BEGIN LIBTOOL TAG CONFIG: FC
11662 
11663 # The linker used to build libraries.
11664 LD="/arm-compiler-for-linux_23.10_AmazonLinux-2/gcc-12.2.0_AmazonLinux-2/aarch64-linux-gnu/bin/ld"
11665 
11666 # How to create reloadable object files.
11667 reload_flag=" -r"
11668 reload_cmds="\$LD\$reload_flag -o \$output\$reload_objs"
11669 
11670 # Commands used to build an old-style archive.
11671 old_archive_cmds="\$AR \$AR_FLAGS \$oldlib\$oldobjs~\$RANLIB 
\$tool_oldlib"
11672 
11673 # A language specific compiler.
11674 CC="armflang"
11675 
11676 # Is the compiler the GNU compiler?
11677 with_gcc=no
11678 
11679 # Compiler flag to turn off builtin functions.
11680 no_builtin_flag=""
11681 
11682 # Additional compiler flags for building library objects.
11683 pic_flag=""
11684 
11685 # How to pass a linker flag through the compiler.
11686 wl=""

Note that wl= is emtpy.

Compare with the portion of this file for C compiler:

  317 # A language specific compiler.
  318 CC="mpicc"
  319 
  320 # Is the compiler the GNU compiler?
  321 with_gcc=yes
  322 
  323 # Compiler flag to turn off builtin functions.
  324 no_builtin_flag=" -fno-builtin -fno-rtti -fno-exceptions"
  325 
  326 # Additional compiler flags for building library objects.
  327 pic_flag=" -fPIC -DPIC"
  328 
  329 # How to pass a linker flag through the compiler.
  330 wl="-Wl,"


This simple patch works:

sed -i 's|wl=""|wl="-Wl,"|' libtool

and gives:

libtool: link: armflang -shared   -g -fopenmp 
-mcpu=neoverse-512tvb -march=armv8.4-a+sve   -fopenmp -Wl,-soname 
-Wl,libp2.so.0 -o .libs/libp2.so.0.0.0

However, this crude hack will not work with "make distcheck",
because it will generate a new libtool.

Still, I'm trying to understand if this is a bug in autotools,
and if there is a workaround via edits in configure.ac and/or Makefile.am.

Thank you

Anton

> On 20 Oct 2023, at 08:40, Shterenlikht, Anton  
> wrote:
> 
> [also posted in libt...@gnu.org]
> 
> Please help me understand how to deal correctly with this error:
> 
> libtool: link: armflang -shared-g   -soname 
> libp2.so.0 -o .libs/libp2.so.0.0.0
> armflang: error: unknown argument: '-soname'
> 
> 
> I see this issue mentioned in multiple places, e.g:
> 
> https://github.com/HDFGroup/hdf5/issues/366
> 
> with the solution that "-Wl," must be prepended somehow to "-soname".
> 
> But I'm not sure what changes I need to do
> to my configure.ac and/or Makefile.am
> to fix this correctly.
> 
> For comparison, here's how the same line looks like when
> I use gfortran:
> 
> libtool: link: gfortran -shared  -fPIC  -g -O2   
> -Wl,-soname -Wl,libp2.so.0 -o .libs/libp2.so.0.0.0
> 
> 
> Thank you
> 
> Anton




smime.p7s
Description: S/MIME cryptographic signature