[FYI] distlinksbrk.test: Work around botched make -k.
I've applied the patch below to a temporary bug-fixing branch, merged
it to maint, merged maint to master, and pushed. The testcase still
works with GNU make, FreeBSD make and Solaris make, but I couldn't
test if it really fixes the problem with HP-UX make and IRIX make.
Regards,
Stefano
-*-*-*-
distlinksbrk.test: Work around botched make -k.
* tests/distlinksbrk.test: Run make multiple times and grep
its output each time for a single error message, rather than
running make -k one single time and grepping its output for
all the expected error messages. This should work around make
implementations with limited (broken?) `-k' support; for more
information, see these subthreads on the automake-patches list:
- 2010-11-15, Testsuite failures on HP-UX 11.23,
http://lists.gnu.org/archive/html/automake-patches/2010-11/msg00162.html
- 2010-11-15, Testsuite failures on IRIX 6.5,
http://lists.gnu.org/archive/html/automake-patches/2010-11/msg00166.html
---
ChangeLog | 14 ++
tests/distlinksbrk.test | 31 +--
2 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index cd301e3..cc6b22a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2010-12-22 Stefano Lattarini stefano.lattar...@gmail.com
+
+ distlinksbrk.test: Work around botched make -k.
+ * tests/distlinksbrk.test: Run make multiple times and grep
+ its output each time for a single error message, rather than
+ running make -k one single time and grepping its output for
+ all the expected error messages. This should work around make
+ implementations with limited (broken?) `-k' support; for more
+ information, see these subthreads on the automake-patches list:
+ - 2010-11-15, Testsuite failures on HP-UX 11.23,
+
http://lists.gnu.org/archive/html/automake-patches/2010-11/msg00162.html
+ - 2010-11-15, Testsuite failures on IRIX 6.5,
+
http://lists.gnu.org/archive/html/automake-patches/2010-11/msg00166.html
+
2010-06-21 Stefano Lattarini stefano.lattar...@gmail.com
Add a test checking that distributed broken symlinks cause
diff --git a/tests/distlinksbrk.test b/tests/distlinksbrk.test
index 1e478ab..2314408 100755
--- a/tests/distlinksbrk.test
+++ b/tests/distlinksbrk.test
@@ -49,30 +49,25 @@ test -h $lnk2
test -h $lnka
test -h $lnkb
-cat configure.in END
+cat configure.in 'END'
AC_OUTPUT
END
-cat Makefile.am END
-EXTRA_DIST = $lnk1 $lnk2 $lnka $lnkb
-END
-
-ls -l
-
$ACLOCAL
$AUTOCONF
-$AUTOMAKE
-./configure
-# Distribution must fail.
-$MAKE distdir Exit 1
+ls -l # for debugging
-# Names of distributed broken symlinks should be reported in make output.
-$MAKE -k distdir out 21 || : # don't trust the exit status of make -k
-cat out
-$FGREP $lnk1 out
-$FGREP $lnk2 out
-$FGREP $lnka out
-$FGREP $lnkb out
+# Don't try to use make -k, because some botched make implementations
+# (HP-UX, IRIX) might still exit on the first error in this situations.
+for lnk in $lnk1 $lnk2 $lnka $lnkb; do
+ echo EXTRA_DIST = $lnk Makefile.am
+ $AUTOMAKE
+ ./configure
+ # Distribution must fail, with a decent error message.
+ $MAKE distdir out 21 { cat out; Exit 1; }
+ cat out
+ $FGREP $lnk out
+done
:
--
1.7.1
Re: Testsuite failures on HP-UX 11.23 (was: Re: testsuite results from master)
Reference: http://lists.gnu.org/archive/html/automake-patches/2010-11/msg00162.html [For the sake of the reading this message in real-time: this reply has been sent pratically without changes also to the related thread Testsuite failures on IRIX 6.5] FAIL: distlinksbrk.test (exit: 1) = /tmp/am/build-hppa2.0w-hp-hpux11.23/tests:/tmp/local/hppa2.0w-hp-hpux11.23/bin :/tmp/bin:/opt/aCC/bin:/opt/ansic/bin:/bin:/usr/bin:/sbin:/usr/sbin:/usr/bin/X11 :/usr/ccs/bin:/usr/contrib/bin/X11:/usr/vue/bin:/opt/imake/bin + pwd /tmp/am/build-hppa2.0w-hp-hpux11.23/tests/distlinksbrk.dir + set -e + lnk_base=BrknSymlnk + lnk1=BrknSymlnk__001 + lnk2=BrknSymlnk__002 + lnka=BrknSymlnk__aaa + lnkb=BrknSymlnk__bbb + ln -s nonesuch BrknSymlnk__001 + pwd + ln -s /tmp/am/build-hppa2.0w-hp-hpux11.23/tests/distlinksbrk.dir/nonesuch BrknSymlnk__002 + ln -s BrknSymlnk__001 BrknSymlnk__aaa + ln -s BrknSymlnk__aaa BrknSymlnk__bbb + test ! -r BrknSymlnk__001 + test ! -r BrknSymlnk__002 + test ! -r BrknSymlnk__aaa + test ! -r BrknSymlnk__bbb + test -h BrknSymlnk__001 + test -h BrknSymlnk__002 + test -h BrknSymlnk__aaa + test -h BrknSymlnk__bbb + cat + 1 configure.in 0 /var/tmp/sh13163.8 + cat + 1 Makefile.am 0 EXTRA_DIST = BrknSymlnk__001 BrknSymlnk__002 BrknSymlnk__aaa BrknSymlnk__bbb + ls -l total 18 lrwxrwxr-x 1 rwild rwild8 Nov 12 20:16 BrknSymlnk__001 - nonesuch lrwxrwxr-x 1 rwild rwild 74 Nov 12 20:16 BrknSymlnk__002 - /tmp/am/build-hppa2.0w-hp-hpux11.23/tests/distlinksbrk.dir/nonesuch lrwxrwxr-x 1 rwild rwild 15 Nov 12 20:16 BrknSymlnk__aaa - BrknSymlnk__001 lrwxrwxr-x 1 rwild rwild 15 Nov 12 20:16 BrknSymlnk__bbb - BrknSymlnk__aaa -rw-rw-r-- 1 rwild rwild 77 Nov 12 20:16 Makefile.am -rw-rw-r-- 1 rwild rwild 86 Nov 12 20:16 configure.in -rwxr-xr-x 1 rwild rwild20001 Nov 12 20:16 depcomp -rwxr-xr-x 1 rwild rwild13781 Nov 12 20:16 install-sh -rwxr-xr-x 1 rwild rwild11419 Nov 12 20:16 missing + aclocal-1.11a -Werror + autoconf + automake-1.11a --foreign -Werror -Wall + ./configure checking for a BSD-compatible install... ./install-sh -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... ./install-sh -c -d checking for gawk... no checking for mawk... no checking for nawk... no checking for awk... awk checking whether make sets $(MAKE)... yes checking that generated files are newer than configure... done configure: creating ./config.status config.status: creating Makefile + make distdir No suffix list. ?!? What is this? Make: Don't know how to make BrknSymlnk__001. Stop. + make -k distdir + 1 out 2 1 + : + cat out No suffix list. Make: Don't know how to make BrknSymlnk__001. Stop. Just an error message instead of four? Might this be a make -k bug? I've now installed a patch for this; see git commit v1.11-135-g2f8861f distlinksbrk.test: Work around botched 'make -k', and the message on automake-patches: http://lists.gnu.org/archive/html/automake-patches/2010-12/msg00121.html I'm not sure if that really solves the problem above, though. If anyone can do proper testing, please let me know what the results are. Regards, Stefano
Re: Testsuite failures on IRIX 6.5 (was: testsuite results from master)
Reference: http://lists.gnu.org/archive/html/automake-patches/2010-11/msg00166.html [For the sake of the reading this message in real-time: this reply has been sent pratically without changes also to the related thread Testsuite failures on HP-UX 11.23] FAIL: distlinksbrk.test (exit: 1) = /tmp/am/build-mips-sgi-irix6.5/tests:/tmp/local/mips-sgi-irix6.5/bi n:/tmp/bin:/bin:/usr/bin:/sbin:/usr/sbin:/etc:/usr/etc:/usr/bin/X11 :/usr/bsd + pwd /tmp/am/build-mips-sgi-irix6.5/tests/distlinksbrk.dir + set -e + lnk_base=BrknSymlnk + lnk1=BrknSymlnk__001 + lnk2=BrknSymlnk__002 + lnka=BrknSymlnk__aaa + lnkb=BrknSymlnk__bbb + ln -s nonesuch BrknSymlnk__001 + pwd + ln -s /tmp/am/build-mips-sgi-irix6.5/tests/distlinksbrk.dir/nonesuch BrknSymlnk__002 + ln -s BrknSymlnk__001 BrknSymlnk__aaa + ln -s BrknSymlnk__aaa BrknSymlnk__bbb + test ! -r BrknSymlnk__001 + test ! -r BrknSymlnk__002 + test ! -r BrknSymlnk__aaa + test ! -r BrknSymlnk__bbb + test -h BrknSymlnk__001 + test -h BrknSymlnk__002 + test -h BrknSymlnk__aaa + test -h BrknSymlnk__bbb + cat + 1 configure.in 0 /tmp/sh791237.2 + cat + 1 Makefile.am 0 EXTRA_DIST = BrknSymlnk__001 BrknSymlnk__002 BrknSymlnk__aaa BrknSymlnk__bbb + ls -l total 92 lrwxrwxr-x1 rwildrwild 8 Nov 12 20:31 BrknSymlnk__001 - nonesuch lrwxrwxr-x1 rwildrwild 69 Nov 12 20:31 BrknSymlnk__002 - /tmp/am/build-mips-sgi-irix6.5/tests/distlinksbrk.dir/nonesuch lrwxrwxr-x1 rwildrwild 15 Nov 12 20:31 BrknSymlnk__aaa - BrknSymlnk__001 lrwxrwxr-x1 rwildrwild 15 Nov 12 20:31 BrknSymlnk__bbb - BrknSymlnk__aaa -rw-rw-r--1 rwildrwild 77 Nov 12 20:31 Makefile.am -rw-rw-r--1 rwildrwild 86 Nov 12 20:31 configure.in -rwxr-xr-x1 rwildrwild 20001 Nov 12 20:31 depcomp -rwxr-xr-x1 rwildrwild 13781 Nov 12 20:31 install-sh -rwxr-xr-x1 rwildrwild 11419 Nov 12 20:31 missing + aclocal-1.11a -Werror + autoconf + automake-1.11a --foreign -Werror -Wall + ./configure checking for a BSD-compatible install... ./install-sh -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... ./install-sh -c -d checking for gawk... no checking for mawk... no checking for nawk... nawk checking whether make sets $(MAKE)... yes checking that generated files are newer than configure... done configure: creating ./config.status config.status: creating Makefile + make distdir UX:make: ERROR: don't know how to make BrknSymlnk__001 (bu42). + make -k distdir + 1 out 2 1 + : + cat out UX:make: ERROR: don't know how to make BrknSymlnk__001 (bu42). Just an error message instead of four? Might this be a make -k bug? If yes, how does the attached test script fare? I've now installed a patch for this; see git commit v1.11-135-g2f8861f distlinksbrk.test: Work around botched 'make -k', and the message on automake-patches: http://lists.gnu.org/archive/html/automake-patches/2010-12/msg00121.html I'm not sure if that really solves the problem above, though. If anyone can do proper testing, please let me know what the results are. Regards, Stefano
Re: User extensions
[off-list] Reviving an oldish thread... Reference: http://lists.gnu.org/archive/html/automake-patches/2010-11/msg2.html On Monday 01 November 2010, Ralf Wildenhues wrote: * Valentin David wrote on Mon, Nov 01, 2010 at 09:41:47PM CET: I hope I will be able to prepare the new patches pretty soon. Cool. Whatever you send, several small changes (each being a logical entity) is always easier to review than one large one. Hello Valentin. Have you had time to respin the patches yet? I find the feature you're implementing very useful and promising, and thus I'd like to know if there are progresses, and if I could help in any way. Thanks, Stefano
Re: [FYI] distlinksbrk.test: Work around botched make -k.
* Stefano Lattarini wrote on Tue, Dec 21, 2010 at 03:49:49PM CET: I've applied the patch below to a temporary bug-fixing branch, merged it to maint, merged maint to master, and pushed. The testcase still works with GNU make, FreeBSD make and Solaris make, but I couldn't test if it really fixes the problem with HP-UX make and IRIX make. Thanks. This makes the test pass on HP/UX 11.23 and IRIX 6.5. Cheers, Ralf distlinksbrk.test: Work around botched make -k. * tests/distlinksbrk.test: Run make multiple times and grep its output each time for a single error message, rather than running make -k one single time and grepping its output for all the expected error messages. This should work around make implementations with limited (broken?) `-k' support; for more information, see these subthreads on the automake-patches list: - 2010-11-15, Testsuite failures on HP-UX 11.23, http://lists.gnu.org/archive/html/automake-patches/2010-11/msg00162.html - 2010-11-15, Testsuite failures on IRIX 6.5, http://lists.gnu.org/archive/html/automake-patches/2010-11/msg00166.html
[FYI] docs: cygnus mode doesn't require AM_CYGWIN32 macro.
The automake manual states that the cygwin mode requires the macro AM_CYGWIN32,
but this is not true anymore since at least commit Release-1-2-31-g3038064
merged changes from Cygnus of 1997-08-25 (yep!); also, the AM_CYGWIN32 macro
has been obsoleted from at least commit Release-1-3b-14-gd4d5968 Track recent
autoconf changes of 1998-09-26.
So I installed the following patch to maint, and pushed.
Regards,
Stefano
-*-*-*-
docs: cygnus mode doesn't require AM_CYGWIN32 macro.
* doc/automake.texi (Cygnus): Mode 'cygnus' does not require
the AM_CYGWIN32 macro (and indeed hasn't required it since at
least commit Release-1-2-31-g3038064 merged changes from
Cygnus of 1997-08-25).
---
ChangeLog |8
doc/automake.texi |3 +--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 26038e1..ad51571 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
2010-12-22 Stefano Lattarini stefano.lattar...@gmail.com
+ docs: cygnus mode doesn't require AM_CYGWIN32 macro.
+ * doc/automake.texi (Cygnus): Mode 'cygnus' does not require
+ the AM_CYGWIN32 macro (and indeed hasn't required it since at
+ least commit Release-1-2-31-g3038064 merged changes from
+ Cygnus of 1997-08-25).
+
+2010-12-22 Stefano Lattarini stefano.lattar...@gmail.com
+
distlinksbrk.test: Work around botched make -k.
* tests/distlinksbrk.test: Run make multiple times and grep
its output each time for a single error message, rather than
diff --git a/doc/automake.texi b/doc/automake.texi
index 9c2074b..ab5f861 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -9807,8 +9807,7 @@ The options @option{no-installinfo} and
@option{no-dependencies} are
implied.
@item
-The macros @code{AM_MAINTAINER_MODE} and @code{AM_CYGWIN32} are
-required.
+The macro @code{AM_MAINTAINER_MODE} is required.
@item
The @code{check} target doesn't depend on @code{all}.
--
1.7.1
Re: [FYI] docs: cygnus mode doesn't require AM_CYGWIN32 macro.
On Wednesday 22 December 2010, Stefano Lattarini wrote: So I installed the following patch to maint, and pushed. OK, not really, since savannah is down (again). Will push ASAP. Regards, Stefano
