[bug#60772] [PATCH] tests: rework gettext to only check 'external' behavior
On 13 Jan 2023 16:52, Karl Berry wrote: > Subject: [bug#60772] [PATCH] tests: rework gettext to only check > 'external' > behavior > > Good catch, thanks. Please commit. > > +# po/ is required. intl/ should not be used. > > Perhaps add the bit of information from your mail to help future > sleuths: > > "... not be used, since non-external use of gettext was deprecated in > 2010 (gettext 0.18) and made fatal in 0.20 (2019)." will do, and have done -mike signature.asc Description: PGP signature
[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P
On 13 Jan 2023 15:36, Karl Berry wrote: > - test -d "$(distdir)" || mkdir "$(distdir)" > + $(AM_V_at)$(MKDIR_P) "$(distdir)" > > Ok by me, but why the AM_V_at for this particular command? > I don't see it used anywhere else in distdir.am. this is certainly true, and it's something i want to fix ... at some point. imo we overly rely on explicit @ in many places which can make debugging failures painful. i imagine the current state is due to the silent-rules work focusing on the most common paths (compile/rebuilds) and leaving the rest to "one day". so if we ever get to that day, we'd use $(AM_V_at) in this location. i figured making the change while i was here means we have a slightly higher chance of this code eventually being silent-rules compat vs finding the time to convert it all at once. -mike signature.asc Description: PGP signature
[bug#60772] [PATCH] tests: rework gettext to only check 'external' behavior
Subject: [bug#60772] [PATCH] tests: rework gettext to only check 'external' behavior Good catch, thanks. Please commit. +# po/ is required. intl/ should not be used. Perhaps add the bit of information from your mail to help future sleuths: "... not be used, since non-external use of gettext was deprecated in 2010 (gettext 0.18) and made fatal in 0.20 (2019)." Thanks, Karl
[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h
> your patch *and* consistently test flex with "--never-interactive". Making flex non-interactive sounds desirable in any case, but --never-interactive is not mentioned in the 2.6.0 --help message. Instead there is -B (--batch), although --never-interactive is recognized, I can see experimentally. I do not know when --never-interactive, or any of its variants, was implemented. We should check that before using it ... --thanks, karl.
[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P
- test -d "$(distdir)" || mkdir "$(distdir)" + $(AM_V_at)$(MKDIR_P) "$(distdir)" Ok by me, but why the AM_V_at for this particular command? I don't see it used anywhere else in distdir.am. - test -d "$$am__dir" || $(MKDIR_P) "$$am__dir" || exit 1; \ + $(MKDIR_P) "$$am__dir" || exit 1; \ Sure. Thanks. -k
[bug#60771] [PATCH] tests: disable git log pager usage
- (cd "$am_top_srcdir" && git log -1) || st=1 + (cd "$am_top_srcdir" && git --no-pager log -1) || st=1 Sure. Please commit. Thanks. -k
[bug#60763] [PATCH] tests: change `sort|uniq` to `sort -u`
-done | sed 's,^\./,,' | sort | uniq >$(am__tfs); \ +done | sed 's,^\./,,' | sort -u >$(am__tfs); \ Sure, looks good, please commit. (60764 looks like a dup?)
[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h
On 13 Jan 2023 13:49, Frederic Berat wrote: > I probably won't be able to do so before next week at least. > If you happen to have time (and be willing) to do it earlier, don't > hesitate ;) that timeframe is fine. as you can see, we take a long view in Automake. -mike signature.asc Description: PGP signature
[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h
I probably won't be able to do so before next week at least. If you happen to have time (and be willing) to do it earlier, don't hesitate ;) On Fri, Jan 13, 2023 at 7:31 AM Mike Frysinger wrote: > On Mon, 12 Dec 2022 15:20:46 -0500, Zack Weinberg wrote: > > On 2022-12-12 2:07 AM, Frederic Berat wrote: > > > > > > This patch is mainly a proposal. While the macro can simply be removed > > > as explained below, another possibility it to add a flex option > > > "--never-interactive" to prevent flex to make use of "isatty". > > > > > > This is related to an effort to prepare Automake for future GCC/Clang > > > versions which set c99 as default standard to be used. > > > > > > Future version of flex make the "NO_UNISTD" flag a no-op, and include > > > unistd.h by default. > > > > > > In current version of flex, not having this header leads to implicit > > > function declarations that are not compatible with c99 standard. > > > > > > On top of that, while flex dedicated test were having this macro set, > > > the yacc ones didn't have it despise their use of Flex. Thus, if this > > > macro was ever useful, it looks like nobody actually cared. > > > > I'm guessing that the idea here was to avoid using unistd.h on platforms > > that don't supply that header at all. I suggest that we should apply > > your patch *and* consistently test flex with "--never-interactive". > > sounds fine. want to update your patch Frederic ? > -mike > > > >
[bug#59993] [PATCH v2 3/3] tests: Fix implicit function declaration in ax/depcomp.sh
Ok, I'll try to figure out why this test passes on 1.16.5 but not on HEAD with the same patch. On Fri, Jan 13, 2023 at 9:47 AM Mike Frysinger wrote: > On 13 Jan 2023 09:14, Frederic Berat wrote: > > I made one more build with a different patchset list, could it be that > the > > failure you encounter is with "t/subobj.sh" ? > > to be clear, i applied this patch only to current git master. i didn't try > including anything else. with that in mind, the failure is not in that, > but > in t/depcomp-auto.tap. > FAIL: t/depcomp-auto > FAIL: t/depcomp-auto.tap 14 - [simple VPATH] make distclean > FAIL: t/depcomp-auto.tap 21 - [long VPATH] make distclean > FAIL: t/depcomp-auto.tap 28 - [absolute VPATH] make distclean > > ERROR: files left in build directory after distclean: > ./.deps/foo.Tpo > make: *** [Makefile:750: distcleancheck] Error 1 > -mike >
[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P
We don't need to do the `test -d ... || mkdir ...` dance when we have the MKDIR_P helper, so simplify this code a bit. * lib/am/distdir.am: Use $(MKDIR_P). * lib/am/lisp.am: Drop redundant `test -d`. --- lib/am/distdir.am | 2 +- lib/am/lisp.am| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/am/distdir.am b/lib/am/distdir.am index 4cfc742ce23d..264713c332e6 100644 --- a/lib/am/distdir.am +++ b/lib/am/distdir.am @@ -103,7 +103,7 @@ endif %?TOPDIR_P% ## if %?TOPDIR_P% $(am__remove_distdir) - test -d "$(distdir)" || mkdir "$(distdir)" + $(AM_V_at)$(MKDIR_P) "$(distdir)" endif %?TOPDIR_P% ## ## diff --git a/lib/am/lisp.am b/lib/am/lisp.am index d5858f8661af..c96be2121656 100644 --- a/lib/am/lisp.am +++ b/lib/am/lisp.am @@ -37,7 +37,7 @@ endif %?INSTALL% am__subdir_includes="-L $$am__dir -L $(srcdir)/$$am__dir"; \ esac; \ ## Emacs byte-compilation won't create this automatically, sadly. - test -d "$$am__dir" || $(MKDIR_P) "$$am__dir" || exit 1; \ + $(MKDIR_P) "$$am__dir" || exit 1; \ $(EMACS) --batch --no-site-file \ $(AM_ELCFLAGS) $(ELCFLAGS) \ $$am__subdir_includes -L $(builddir) -L $(srcdir) \ -- 2.39.0
[bug#59993] [PATCH v2 3/3] tests: Fix implicit function declaration in ax/depcomp.sh
On 13 Jan 2023 09:14, Frederic Berat wrote: > I made one more build with a different patchset list, could it be that the > failure you encounter is with "t/subobj.sh" ? to be clear, i applied this patch only to current git master. i didn't try including anything else. with that in mind, the failure is not in that, but in t/depcomp-auto.tap. FAIL: t/depcomp-auto FAIL: t/depcomp-auto.tap 14 - [simple VPATH] make distclean FAIL: t/depcomp-auto.tap 21 - [long VPATH] make distclean FAIL: t/depcomp-auto.tap 28 - [absolute VPATH] make distclean ERROR: files left in build directory after distclean: ./.deps/foo.Tpo make: *** [Makefile:750: distcleancheck] Error 1 -mike signature.asc Description: PGP signature
[bug#59993] [PATCH v2 3/3] tests: Fix implicit function declaration in ax/depcomp.sh
I made one more build with a different patchset list, could it be that the failure you encounter is with "t/subobj.sh" ? In my tests run this failure is fixed by: https://lists.gnu.org/archive/html/automake-patches/2022-12/msg1.html On Fri, Jan 13, 2023 at 8:57 AM Frederic Berat wrote: > That's strange, although I tested it on top of automake-1.16.5, I don't > have any failure on `make check` with this one here [1]. > > May you provide more details ? > > > [1] > > > Testsuite summary for GNU Automake 1.16.5 > > > # TOTAL: 2980 > # PASS: 2882 > # SKIP: 60 > # XFAIL: 38 > # FAIL: 0 > # XPASS: 0 > # ERROR: 0 > > > > On Fri, Jan 13, 2023 at 7:48 AM Mike Frysinger wrote: > >> this breaks `make check`, so i can't merge it >> -mike >> >>
