Re: [PATCH 6/7] Tests defs: new AC_SUBST'ed variable $top_testsbuilddir.

2010-11-11 Thread Stefano Lattarini
On Thursday 11 November 2010, Stefano Lattarini wrote:
 On Wednesday 10 November 2010, Ralf Wildenhues wrote:
  * Stefano Lattarini wrote on Sun, Nov 07, 2010 at 04:21:09PM CET:
   * tests/defs.in ($top_testsbuilddir): New variable, initialized
   with the value AC_SUBST'ed from @abs_top_build...@.  Mostly for
   completeness and consistency with $testsrcdir and $top_testsrcdir.
  
  Let's add this only when we need it.  Do we?
 Not at the moment, but I thought it would be nice to have it anyway,
 if only for consistency/simmetry reasons.  But I'm OK with removing
 it, too, if you insist.  Do you?
I removed this patch from the series, as requested by Ralf.

Regards,
  Stefano



Re: [PATCH 6/7] Tests defs: new AC_SUBST'ed variable $top_testsbuilddir.

2010-11-10 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Nov 07, 2010 at 04:21:09PM CET:
 * tests/defs.in ($top_testsbuilddir): New variable, initialized
 with the value AC_SUBST'ed from @abs_top_build...@.  Mostly for
 completeness and consistency with $testsrcdir and $top_testsrcdir.

Let's add this only when we need it.  Do we?

Thanks,
Ralf



Re: [PATCH 6/7] Tests defs: new AC_SUBST'ed variable $top_testsbuilddir.

2010-11-10 Thread Stefano Lattarini
On Wednesday 10 November 2010, Ralf Wildenhues wrote:
 * Stefano Lattarini wrote on Sun, Nov 07, 2010 at 04:21:09PM CET:
  * tests/defs.in ($top_testsbuilddir): New variable, initialized
  with the value AC_SUBST'ed from @abs_top_build...@.  Mostly for
  completeness and consistency with $testsrcdir and $top_testsrcdir.
 
 Let's add this only when we need it.  Do we?
Not at the moment, but I thought it would be nice to have it anyway,
if only for consistency/simmetry reasons.  But I'm OK with removing
it, too, if you insist.  Do you?

Thanks,
  Stefano




[PATCH 6/7] Tests defs: new AC_SUBST'ed variable $top_testsbuilddir.

2010-11-07 Thread Stefano Lattarini
* tests/defs.in ($top_testsbuilddir): New variable, initialized
with the value AC_SUBST'ed from @abs_top_build...@.  Mostly for
completeness and consistency with $testsrcdir and $top_testsrcdir.
---
 ChangeLog |5 +
 tests/defs.in |1 +
 2 files changed, 6 insertions(+), 0 deletions(-)

From bb634a36f34b25d4344024c2a8f61af0702d02dc Mon Sep 17 00:00:00 2001
From: Stefano Lattarini stefano.lattar...@gmail.com
Date: Fri, 5 Nov 2010 18:21:35 +0100
Subject: [PATCH 6/7] Tests defs: new AC_SUBST'ed variable $top_testsbuilddir.

* tests/defs.in ($top_testsbuilddir): New variable, initialized
with the value AC_SUBST'ed from @abs_top_build...@.  Mostly for
completeness and consistency with $testsrcdir and $top_testsrcdir.
---
 ChangeLog |5 +
 tests/defs.in |1 +
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 3f89d8f..34e6918 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2010-11-06  Stefano Lattarini  stefano.lattar...@gmail.com
 
+	Tests defs: new AC_SUBST'ed variable $top_testsbuilddir.
+	* tests/defs.in ($top_testsbuilddir): New variable, initialized
+	with the value AC_SUBST'ed from @abs_top_build...@.  Mostly for
+	completeness and consistency with $testsrcdir and $top_testsrcdir.
+
 	Tests defs: $testsbuilddir is now AC_SUBST'ed.
 	* tests/defs.in ($testsbuilddir): Initialize statically
 	with the value AC_SUBST'ed from @abs_builddir@, rather than
diff --git a/tests/defs.in b/tests/defs.in
index 5124d2d..28436b2 100644
--- a/tests/defs.in
+++ b/tests/defs.in
@@ -29,6 +29,7 @@
 testsrcdir='@abs_srcdir@'
 top_testsrcdir='@abs_top_srcdir@'
 testbuilddir='@abs_builddir@'
+top_testbuilddir='@abs_top_builddir@'
 
 # Protect this file against multiple inclusion, useful for generated tests.
 if test x$am_skip_defs = xyes; then
-- 
1.7.1