Re: [7u8] Review request for 7171045 [macosx] There are no enter or exit events reported against 8b39 for MouseEventsDuringDrag.
Hi, Alexander. Fix looks good. 29.08.2012 13:59, Alexander Scherbatiy wrote: Could you review the updated fix for the JDK 7u8 where the failed test is removed: http://cr.openjdk.java.net/~alexsch/7171045/webrev7.02/ On 8/28/2012 8:37 PM, Anthony Petrov wrote: Hi Alexander, 1. Does the closed/javax/swing/plaf/basic/BasicToolBarUI/4331392/bug4331392.java test (mentioned in 7154048) pass with this fix? Yes, the test passes. The fix reverted back changes after the 7154048 fix. http://cr.openjdk.java.net/~alexsch/7154048/webrev7.00/src/macosx/classes/sun/lwawt/LWWindowPeer.java.udiff.html 2. What is the plan for DragWindowTest.java? We should either remove it with this fix, or file a CR and remove '@' from the '@run' jtreg tag so that it wouldn't fail for the time being. I removed the failed DragWindowTest.java from the JDK 7u repository in the updated fix. But it still presents in the JDK 8 repository and passes with the fixed 7154048 and 7171045 issues. Thanks, Alexandr. -- best regards, Anthony On 8/28/2012 4:57 PM, Alexander Scherbatiy wrote: Hello, Please review the fix for the JDK 7u8: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171045 webrev: http://cr.openjdk.java.net/~alexsch/7171045/webrev7.00/ This is a regression after the fix 7154048 [macosx] At least drag twice, the toolbar can be dragged to the left side. In the case where a toolbar is created under a mouse and it is dragged over the initial window the mouse enter/exit events should not be generated for the components which are under the toolbar. The disabling component mouse enter/exit events generation during drag leads that it does not work in the case where a mouse is dragged over the current window. The full fix that checks that a current window is a topmost window under mouse requires some changes (using tracking area instead of tracking rectangle and so on) is a quite complicated and it seems that it is risky to include it to the JDK 7u8. Current fix just changes the condition for the component mouse enter/exit events generation to the initial state how it was before the 7154048 fix. This allows to generate components mouse enter/exit events, but the following test will fail: java/awt/Mouse/EnterExitEvents/DragWindowTest.java However this test did not work before the 7154048 fix so it is not a regression. Thanks, Alexandr. -- Best regards, Sergey.
Re: Objective-C and jcheck
Hi, Kelly.
The modified version was used in the macoxs-port project, after its
merge to the main branch there were some requests to update jcheck, but
nobody reacted to them. Whether it means that verification of these
files should be switched off?
29.08.2012 21:15, Kelly O'Hair wrote:
CC John Coomes...
First, the jcheck script contains:
normext_re = re.compile(".*\.(java|c|h|cpp|hpp)$")
I don't understand how you are getting this error, it isn't checking
*.m files. Did something change?
Second, it was my understanding that additions of Objective-C source
code into the JDK was going to be very very limited.
The more Objective-C code we add, the fewer developers we will have to
fix issues with it.
Not everyone is skilled at Objective-C. I understand we need to bridge
a little, but I really hope it is limited
and very well documented.
-kto
On Aug 28, 2012, at 4:22 AM, Sergey Bylokhov wrote:
Hi Everybody.
Looks like on the server we still use jcheck without fix for
Objective-C files? Does anybody know how to apply the fix to jdk8?
(see attachment)
[jdk]
pulling from http://hg.openjdk.java.net/jdk8/awt/jdk
searching for changes
adding changesets
adding manifests
adding file changes
added 1 changesets with 10 changes to 10 files
[jcheck 25e85a608db1 2011-07-08 09:19 -0700]
> Changeset: 5305:0fad89bd606b
> Author:alexsch
> Date: 2012-05-02 17:54
>
> 7154048: [macosx] At least drag twice, the toolbar can be dragged
to the left
side
> Reviewed-by: anthony, leonidr
src/macosx/native/sun/awt/AWTView.m:84: Trailing whitespace
src/macosx/native/sun/awt/AWTWindow.m:173: Trailing whitespace
transaction abort!
rollback completed
skipped: pretxnchangegroup.jcheck hook failed
02.05.2012 17:53, alexandr.scherba...@oracle.com
wrote
Changeset: 0fad89bd606b
Author:alexsch
Date: 2012-05-02 17:54 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0fad89bd606b
7154048: [macosx] At least drag twice, the toolbar can be dragged to
the left side
Reviewed-by: anthony, leonidr
! src/macosx/classes/sun/lwawt/LWWindowPeer.java
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/macosx/native/sun/awt/AWTView.h
! src/macosx/native/sun/awt/AWTView.m
! src/macosx/native/sun/awt/AWTWindow.h
! src/macosx/native/sun/awt/AWTWindow.m
+ test/java/awt/Mouse/EnterExitEvents/DragWindowOutOfFrameTest.java
+ test/java/awt/Mouse/EnterExitEvents/DragWindowTest.java
+ test/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java
! test/java/awt/regtesthelpers/Util.java
<Вложенное сообщение.eml>
--
Best regards, Sergey.
