AWT Dev hg: jdk8/awt/jdk: 6943780: JTabbedPane throws ArrayIndexOutOfBoundsException sometimes
Changeset: b5ed8686cc01 Author:malenkov Date: 2013-09-03 11:00 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b5ed8686cc01 6943780: JTabbedPane throws ArrayIndexOutOfBoundsException sometimes Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java + test/javax/swing/plaf/basic/BasicTabbedPaneUI/Test6943780.java
AWT Dev [8] Request for review: JDK-8022512 JLightweightFrame: the content pane should be transparent
Please, review a fix. jira: https://bugs.openjdk.java.net/browse/JDK-8022512 webrev: http://cr.openjdk.java.net/~ant/JDK-8022512/webrev.0/ Both JLF and its Content Pane are transparent to the client app, e.g. SwingNode, in terms of functionality. They should be physically transparent as well, in order to support translucent Swing content. This is the case for JLF, but not for the Content Pane yet. Thanks, Anton.
Re: AWT Dev AWT impact of deprecating/changing SecurityManager#checkTopLevelWindow, checkSystemClipboardAccess, checkTopLevelWindow
On 03/09/2013 10:56, Artem Ananiev wrote: Hi, Alan, the spec changes (still) look fine. I would move the new test from test/java/awt/etc to test/java/awt/security, as we have a few closed tests in that folder, which will eventually be opened. Thanks for taking care of this. Thanks Artem, moving the test to java/awt/security is good idea, I will do that before I push. -Alan.
AWT Dev hg: jdk8/awt/jdk: 8007156: [macosx] Wrong events in processKeyBinding of JTable Submit Date
Changeset: 80a8c4ff3b51 Author:alexsch Date: 2013-09-03 17:27 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/80a8c4ff3b51 8007156: [macosx] Wrong events in processKeyBinding of JTable Submit Date Reviewed-by: leonidr ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java + test/java/awt/event/KeyEvent/ExtendedKeyCode/ExtendedKeyCodeTest.java
AWT Dev [8] Review Request for JDK-8024170, [SwingNode] Implement cursor change
Hello, AWT Team. Please review the fix for the issue: http://bugs.sun.com/view_bug.do?bug_id=8024170 The issue might not be available on bugs.sun.com yet, so here's the FX counterpart: https://javafx-jira.kenai.com/browse/RT-31957 The JDK part of the fix is available at: http://cr.openjdk.java.net/~pchelko/8024170/webrev.00/ The FX part will be reviewed separately, but the fix is available here: http://cr.openjdk.java.net/~pchelko/8024170/webrev.rt.00/ This fix adds support for SwingNode cursor change on Windows and Mac OS X. Linux is not supported yet, because the native FX window handle should passed to AWT and this functionality is not implemented yet. With best regards. Petr.
Re: AWT Dev [8] Review Request for JDK-8024170, [SwingNode] Implement cursor change
Hi Petr,
It looks fine to me in general. Some minor comments:
* LightweightFramePeer.java
- Would be better to spell LightWeight as Lightweight.
- 41 * Sets the window peer under mouse to null if the current
value us equal to this peer
Please, fix the typo: us - is
* LightweightContent.java
- 187public void invokeOnContentsThread(Runnable r);
The method name sounds a little bit odd...
Could we use the term client mentioned in the javadoc? And rename it
to something like: invokeOnClientToolkitThread?
- Also, please provide a default impl for this method in order to
avoid the jdk/jfx versions mismatch until they get synchronized.
* WLightweightFramePeer.java
- 54 lightweightFramePeerUnderMouse = this;
Looks like it should be set to null here.
* JLightweightFrame.java
- 185 public void invokeOnContentsThread(Runnable r) {
Would you rather introduce a JLF.getContent() getter in order to avoid
such wrappers? But I'm not sure...
Thanks,
Anton.
On 9/3/13 6:27 PM, Petr Pchelko wrote:
Hello, AWT Team.
Please review the fix for the issue:
http://bugs.sun.com/view_bug.do?bug_id=8024170
The issue might not be available on bugs.sun.com yet, so here's the FX
counterpart:
https://javafx-jira.kenai.com/browse/RT-31957
The JDK part of the fix is available at:
http://cr.openjdk.java.net/~pchelko/8024170/webrev.00/
The FX part will be reviewed separately, but the fix is available here:
http://cr.openjdk.java.net/~pchelko/8024170/webrev.rt.00/
This fix adds support for SwingNode cursor change on Windows and Mac OS X.
Linux is not supported yet, because the native FX window handle should passed
to AWT and this functionality is not implemented yet.
With best regards. Petr.
AWT Dev hg: jdk8/awt/jdk: 7172865: PropertyDescriptor fails to work with setter method name if setter is non-void
Changeset: 2ad01ecbaf90 Author:malenkov Date: 2013-09-03 21:53 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2ad01ecbaf90 7172865: PropertyDescriptor fails to work with setter method name if setter is non-void Reviewed-by: art, alexsch ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/MethodDescriptor.java + src/share/classes/java/beans/MethodRef.java ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/Introspector/Test7172865.java
Re: AWT Dev AWT impact of deprecating/changing SecurityManager#checkTopLevelWindow, checkSystemClipboardAccess, checkTopLevelWindow
On 9/2/2013 8:49 AM, Alan Bateman wrote: This is a follow-up to thread from June [1] where I proposed deprecating the SecurityManager checkTopLevelWindow, checkSystemClipboardAccess, checkTopLevelWindow methods. At the time then Anthony agreed with the spec change but I didn't come back with a final webrev and get the change pushed. I've been on my to do list for a while and I'm only getting to it now. Here's the updated webrev: http://cr.openjdk.java.net/~alanb/8008981/webrev.02/ This change looks good to me. In the new test line 89, why is the assertChecked commented out? Should it check for accessClipboard permission? Mandy The spec changes are the same as what we had in June, it's just a re-based patch. I've also added a test and I'm open to suggests as to whether to put this (alternatively it can be split up, with separate tests for Toolkit and Window if needed). Thanks, Alan. [1] http://mail.openjdk.java.net/pipermail/awt-dev/2013-June/005019.html
