Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar
It has no representation on windows, but I assume it can have such on other
platforms like OSX/Unity?
OSX/Unity functionality doesn't have per window concept, they have per
application. For these operating system you should use
setProgressValue() instead of setWindowProgressValue()(and so on).
We also exclude JWindow.
It doesn't show up in the taskbar too like java.awt.Window.
--
Thanks,
Alexander.
On 14.03.2017 20:44, Sergey Bylokhov wrote:
It has no representation on windows, but I assume it can have such on other
platforms like OSX/Unity?
It is fine too, because Dialog has no representation in the taskbar too.
We also exclude JWindow.
--
Thanks,
Alexander.
On 14.03.2017 15:56, Philip Race wrote:
Hi,
I realise I need to clarify one thing that may be important.
Previously with Window this could apply to a Dialog.
Now it cannot. Are we disabling an important case with this change ?
-phil
On 3/14/17, 5:54 AM, Alexander Zvegintsev wrote:
There is no precedents here:
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/02/
Thanks,
Alexander.
On 14/03/2017 15:40, Philip Race wrote:
with this change maybe we should be renaming the parameters and update the doc
ie
279 * @param w window
could be
@param f frame
?
Or is there precedent for what you have right now ?
-phil.
On 3/14/17, 5:33 AM, Alexander Zvegintsev wrote:
So they already know the window isn't visible and are asking for an explanation
of the circumstances for this so I don't think this update will satisfy them
without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
Actually java.awt.Window is not visible in taskbar because of its window style
flags(WS_EX_NOACTIVATE, WS_EX_TOOLWINDOW), it has nothing to do with
decorations.
I've replaced parameter type with Frame instead if Window to avoid such
misunderstanding. Frame still can be removed from taskbar by
f.setType(Window.Type.UTILITY) call.
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
This part of API is supported for Windows only.
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/01/
--
Thanks,
Alexander.
On 14.03.2017 0:52, Phil Race wrote:
The JCK comments in the bug are :
This may be a specification issue.
Window progress is not displayed in taskbar as specified.
The spec states that progress is displayed in a platform-dependent way.
I>f progress is not in fact displayed under some circumstances, that should be
specified.
So they already know the window isn't visible and are asking for an explanation
of the circumstances for this so I don't think this update will satisfy them
without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
-phil.
On 3/13/2017 2:04 PM, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8176528
The test uses java.awt.Window which doesn't have button for its window in the
taskbar, thus we can't show progress for this window there.
Re: Review Request: JDK-8174977: Update license files with consistent license/notice names
On 14/03/2017 19:58, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174977/webrev.00/index.html Small edits to the license files, contributed by jeannette.h...@oracle.com. I am sponsoring it. Also I have reviewed it. Mandy Looks okay to me.
Review Request: JDK-8174977: Update license files with consistent license/notice names
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8174977/webrev.00/index.html Small edits to the license files, contributed by jeannette.h...@oracle.com. I am sponsoring it. Also I have reviewed it. Mandy
Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar
It has no representation on windows, but I assume it can have such on other
platforms like OSX/Unity?
> It is fine too, because Dialog has no representation in the taskbar too.
We also exclude JWindow.
>
> --
> Thanks,
> Alexander.
>
> On 14.03.2017 15:56, Philip Race wrote:
>> Hi,
>>
>> I realise I need to clarify one thing that may be important.
>> Previously with Window this could apply to a Dialog.
>> Now it cannot. Are we disabling an important case with this change ?
>>
>> -phil
>>
>> On 3/14/17, 5:54 AM, Alexander Zvegintsev wrote:
>>> There is no precedents here:
>>>
>>> http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/02/
>>>
>>> Thanks,
>>> Alexander.
>>>
>>> On 14/03/2017 15:40, Philip Race wrote:
with this change maybe we should be renaming the parameters and update the
doc
ie
279 * @param w window
could be
@param f frame
?
Or is there precedent for what you have right now ?
-phil.
On 3/14/17, 5:33 AM, Alexander Zvegintsev wrote:
>> So they already know the window isn't visible and are asking for an
>> explanation
>> of the circumstances for this so I don't think this update will satisfy
>> them without
>> more explanation.
>>
>> At the very least we need to add that
>> "Some {@code Window}s are not visible in the task bar.
>> For example undecorated Windows may not be visible".
> Actually java.awt.Window is not visible in taskbar because of its window
> style flags(WS_EX_NOACTIVATE, WS_EX_TOOLWINDOW), it has nothing to do
> with decorations.
>
> I've replaced parameter type with Frame instead if Window to avoid such
> misunderstanding. Frame still can be removed from taskbar by
> f.setType(Window.Type.UTILITY) call.
>
>> I do not know if we can say something stronger than that ?
>> Is this the case on all platforms ?
> This part of API is supported for Windows only.
>
>
> http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/01/
>
> --
> Thanks,
> Alexander.
>
> On 14.03.2017 0:52, Phil Race wrote:
>> The JCK comments in the bug are :
>> >This may be a specification issue.
>> >Window progress is not displayed in taskbar as specified.
>> >The spec states that progress is displayed in a platform-dependent way.
>> I>f progress is not in fact displayed under some circumstances, that
>> should be specified.
>>
>> So they already know the window isn't visible and are asking for an
>> explanation
>> of the circumstances for this so I don't think this update will satisfy
>> them without
>> more explanation.
>>
>> At the very least we need to add that
>> "Some {@code Window}s are not visible in the task bar.
>> For example undecorated Windows may not be visible".
>>
>> I do not know if we can say something stronger than that ?
>> Is this the case on all platforms ?
>>
>> -phil.
>>
>> On 3/13/2017 2:04 PM, Alexander Zvegintsev wrote:
>>> Hello,
>>>
>>> please review the fix
>>>
>>> http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/00/
>>>
>>> for the issue
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8176528
>>>
>>> The test uses java.awt.Window which doesn't have button for its window
>>> in the taskbar, thus we can't show progress for this window there.
>>>
>>>
>>>
>>
>
>>>
>
Re: TrayIcon not working with LXDE on Raspberry Pi
>> For steps to reproduce, it is necessary to have a test application that >> creates >> a tray icon with a menu. I can put this together but it will take a day or >> two. > The test case is done now. Before filing the bug, I retested on the latest > version of Raspbian (released on 2017-03-02) and the problem does not occur. > The problem occurs with an older version of Raspbian from 2006-03-18 that > I was using previously. Because of this, I am not sure if there is still > any need to file the bug and my test case but I would be happy to do this > if it might assist other users. CC 2d-dev: Since Dsun.java2d.xrender affects the bug means that this is related to xrender libarary, and probably some bugs were fixed in the latest version of Raspbian > > Simon > >> Simon The TrayIcon display of messages, hover text and pop-up menus appeara to be broken when running JDK9 EA build 159 on Raspbian LXDE. In all cases, the background is drawn but there is no foreground text. Selecting the invisible text of a menu item works as expected. Is this a known issue or should I create a bug report? Simon Nash
JDK9 will be in RDP2 after March 16th PDT
All, There will I am sure be an official email to jdk9-dev soon but I'd at least to give a reminder about this change in JDK 9 rules as it winds down towards release. If you have anything you need to push without incurring extra process you have just 2 and a half days to do it. After March 16th *all* pushes to any forest require some kind of explicit approval. For changes in product code, you will need a "jdk9-critical-request" label and a justification about why it is a critical or stopper bug for JDK9. That justification will be evaluated. P3 and above "test" and "doc" bugs can still go in with a much less formal "nod" which for the lists above you can get from me. I will monitor the lists for such issues. That is just a very brief and rough summary of what happens *after* Thursday. Others will give a more precise rundown of the rules. The main message here from me is (1) Push soon or incur process (2) After Thursday DO NOT push without approval. -phil.
Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar
OK. So this API change seems like a necessary one.
-phil.
On 3/14/17, 6:09 AM, Alexander Zvegintsev wrote:
It is fine too, because Dialog has no representation in the taskbar too.
--
Thanks,
Alexander.
On 14.03.2017 15:56, Philip Race wrote:
Hi,
I realise I need to clarify one thing that may be important.
Previously with Window this could apply to a Dialog.
Now it cannot. Are we disabling an important case with this change ?
-phil
On 3/14/17, 5:54 AM, Alexander Zvegintsev wrote:
There is no precedents here:
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/02/
Thanks,
Alexander.
On 14/03/2017 15:40, Philip Race wrote:
with this change maybe we should be renaming the parameters and
update the doc
ie
279 * @param w window
could be
@param f frame
?
Or is there precedent for what you have right now ?
-phil.
On 3/14/17, 5:33 AM, Alexander Zvegintsev wrote:
So they already know the window isn't visible and are asking for
an explanation
of the circumstances for this so I don't think this update will
satisfy them without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
Actually java.awt.Window is not visible in taskbar because of its
window style flags(WS_EX_NOACTIVATE, WS_EX_TOOLWINDOW), it has
nothing to do with decorations.
I've replaced parameter type with Frame instead if Window to avoid
such misunderstanding. Frame still can be removed from taskbar by
f.setType(Window.Type.UTILITY) call.
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
This part of API is supported for Windows only.
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/01/
--
Thanks,
Alexander.
On 14.03.2017 0:52, Phil Race wrote:
The JCK comments in the bug are :
>This may be a specification issue.
>Window progress is not displayed in taskbar as specified.
>The spec states that progress is displayed in a
platform-dependent way.
I>f progress is not in fact displayed under some circumstances,
that should be specified.
So they already know the window isn't visible and are asking for
an explanation
of the circumstances for this so I don't think this update will
satisfy them without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
-phil.
On 3/13/2017 2:04 PM, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8176528
The test uses java.awt.Window which doesn't have button for its
window in the taskbar, thus we can't show progress for this
window there.
Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar
It is fine too, because Dialog has no representation in the taskbar too.
--
Thanks,
Alexander.
On 14.03.2017 15:56, Philip Race wrote:
Hi,
I realise I need to clarify one thing that may be important.
Previously with Window this could apply to a Dialog.
Now it cannot. Are we disabling an important case with this change ?
-phil
On 3/14/17, 5:54 AM, Alexander Zvegintsev wrote:
There is no precedents here:
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/02/
Thanks,
Alexander.
On 14/03/2017 15:40, Philip Race wrote:
with this change maybe we should be renaming the parameters and
update the doc
ie
279 * @param w window
could be
@param f frame
?
Or is there precedent for what you have right now ?
-phil.
On 3/14/17, 5:33 AM, Alexander Zvegintsev wrote:
So they already know the window isn't visible and are asking for
an explanation
of the circumstances for this so I don't think this update will
satisfy them without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
Actually java.awt.Window is not visible in taskbar because of its
window style flags(WS_EX_NOACTIVATE, WS_EX_TOOLWINDOW), it has
nothing to do with decorations.
I've replaced parameter type with Frame instead if Window to avoid
such misunderstanding. Frame still can be removed from taskbar by
f.setType(Window.Type.UTILITY) call.
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
This part of API is supported for Windows only.
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/01/
--
Thanks,
Alexander.
On 14.03.2017 0:52, Phil Race wrote:
The JCK comments in the bug are :
>This may be a specification issue.
>Window progress is not displayed in taskbar as specified.
>The spec states that progress is displayed in a
platform-dependent way.
I>f progress is not in fact displayed under some circumstances,
that should be specified.
So they already know the window isn't visible and are asking for
an explanation
of the circumstances for this so I don't think this update will
satisfy them without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
-phil.
On 3/13/2017 2:04 PM, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8176528
The test uses java.awt.Window which doesn't have button for its
window in the taskbar, thus we can't show progress for this
window there.
Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar
Hi,
I realise I need to clarify one thing that may be important.
Previously with Window this could apply to a Dialog.
Now it cannot. Are we disabling an important case with this change ?
-phil
On 3/14/17, 5:54 AM, Alexander Zvegintsev wrote:
There is no precedents here:
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/02/
Thanks,
Alexander.
On 14/03/2017 15:40, Philip Race wrote:
with this change maybe we should be renaming the parameters and
update the doc
ie
279 * @param w window
could be
@param f frame
?
Or is there precedent for what you have right now ?
-phil.
On 3/14/17, 5:33 AM, Alexander Zvegintsev wrote:
So they already know the window isn't visible and are asking for an
explanation
of the circumstances for this so I don't think this update will
satisfy them without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
Actually java.awt.Window is not visible in taskbar because of its
window style flags(WS_EX_NOACTIVATE, WS_EX_TOOLWINDOW), it has
nothing to do with decorations.
I've replaced parameter type with Frame instead if Window to avoid
such misunderstanding. Frame still can be removed from taskbar by
f.setType(Window.Type.UTILITY) call.
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
This part of API is supported for Windows only.
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/01/
--
Thanks,
Alexander.
On 14.03.2017 0:52, Phil Race wrote:
The JCK comments in the bug are :
>This may be a specification issue.
>Window progress is not displayed in taskbar as specified.
>The spec states that progress is displayed in a platform-dependent
way.
I>f progress is not in fact displayed under some circumstances,
that should be specified.
So they already know the window isn't visible and are asking for an
explanation
of the circumstances for this so I don't think this update will
satisfy them without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
-phil.
On 3/13/2017 2:04 PM, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8176528
The test uses java.awt.Window which doesn't have button for its
window in the taskbar, thus we can't show progress for this window
there.
Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar
There is no precedents here:
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/02/
Thanks,
Alexander.
On 14/03/2017 15:40, Philip Race wrote:
with this change maybe we should be renaming the parameters and update the doc
ie
279 * @param w window
could be
@param f frame
?
Or is there precedent for what you have right now ?
-phil.
On 3/14/17, 5:33 AM, Alexander Zvegintsev wrote:
So they already know the window isn't visible and are asking for an
explanation
of the circumstances for this so I don't think this update will
satisfy them without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
Actually java.awt.Window is not visible in taskbar because of its
window style flags(WS_EX_NOACTIVATE, WS_EX_TOOLWINDOW), it has
nothing to do with decorations.
I've replaced parameter type with Frame instead if Window to avoid
such misunderstanding. Frame still can be removed from taskbar by
f.setType(Window.Type.UTILITY) call.
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
This part of API is supported for Windows only.
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/01/
--
Thanks,
Alexander.
On 14.03.2017 0:52, Phil Race wrote:
The JCK comments in the bug are :
>This may be a specification issue.
>Window progress is not displayed in taskbar as specified.
>The spec states that progress is displayed in a platform-dependent
way.
I>f progress is not in fact displayed under some circumstances, that
should be specified.
So they already know the window isn't visible and are asking for an
explanation
of the circumstances for this so I don't think this update will
satisfy them without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
-phil.
On 3/13/2017 2:04 PM, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8176528
The test uses java.awt.Window which doesn't have button for its
window in the taskbar, thus we can't show progress for this window
there.
Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar
with this change maybe we should be renaming the parameters and update the doc
ie
279 * @param w window
could be
@param f frame
?
Or is there precedent for what you have right now ?
-phil.
On 3/14/17, 5:33 AM, Alexander Zvegintsev wrote:
So they already know the window isn't visible and are asking for an
explanation
of the circumstances for this so I don't think this update will
satisfy them without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
Actually java.awt.Window is not visible in taskbar because of its
window style flags(WS_EX_NOACTIVATE, WS_EX_TOOLWINDOW), it has nothing
to do with decorations.
I've replaced parameter type with Frame instead if Window to avoid
such misunderstanding. Frame still can be removed from taskbar by
f.setType(Window.Type.UTILITY) call.
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
This part of API is supported for Windows only.
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/01/
--
Thanks,
Alexander.
On 14.03.2017 0:52, Phil Race wrote:
The JCK comments in the bug are :
>This may be a specification issue.
>Window progress is not displayed in taskbar as specified.
>The spec states that progress is displayed in a platform-dependent way.
I>f progress is not in fact displayed under some circumstances, that
should be specified.
So they already know the window isn't visible and are asking for an
explanation
of the circumstances for this so I don't think this update will
satisfy them without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
-phil.
On 3/13/2017 2:04 PM, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8176528
The test uses java.awt.Window which doesn't have button for its
window in the taskbar, thus we can't show progress for this window
there.
Re: [9] Review request for 8176528: Progress state for window is not displayed in taskbar
So they already know the window isn't visible and are asking for an
explanation
of the circumstances for this so I don't think this update will
satisfy them without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
Actually java.awt.Window is not visible in taskbar because of its window
style flags(WS_EX_NOACTIVATE, WS_EX_TOOLWINDOW), it has nothing to do
with decorations.
I've replaced parameter type with Frame instead if Window to avoid such
misunderstanding. Frame still can be removed from taskbar by
f.setType(Window.Type.UTILITY) call.
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
This part of API is supported for Windows only.
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/01/
--
Thanks,
Alexander.
On 14.03.2017 0:52, Phil Race wrote:
The JCK comments in the bug are :
>This may be a specification issue.
>Window progress is not displayed in taskbar as specified.
>The spec states that progress is displayed in a platform-dependent way.
I>f progress is not in fact displayed under some circumstances, that
should be specified.
So they already know the window isn't visible and are asking for an
explanation
of the circumstances for this so I don't think this update will
satisfy them without
more explanation.
At the very least we need to add that
"Some {@code Window}s are not visible in the task bar.
For example undecorated Windows may not be visible".
I do not know if we can say something stronger than that ?
Is this the case on all platforms ?
-phil.
On 3/13/2017 2:04 PM, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8176528/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8176528
The test uses java.awt.Window which doesn't have button for its
window in the taskbar, thus we can't show progress for this window
there.
