Re: [9] Review request for 8178996 [macos] JComboBox doesn't display popup in mixed JavaFX Swing Application on 8u131 and Mac OS 10.12
Ok, then looks fine. - alexander.zvegint...@oracle.com wrote: > I thought about that, by I decided to add this flag for code > readability. > > -- > Thanks, > Alexander. > > On 11.05.2017 18:34, Sergey Bylokhov wrote: > > Hi, Alex. > > Why you need a separate flag since you can use the ref.get()!=0? and > the ref is set if the block is executed. > > > > - alexander.zvegint...@oracle.com wrote: > > > >> Hi all, > >> > >> please review the fix > >> > >> http://cr.openjdk.java.net/~azvegint/jdk/9/8178996/00/ > >> > >> for the issue > >> > >> https://bugs.openjdk.java.net/browse/JDK-8178996 > >> > >> > >> Popup doesn't show up due to owner is lightweight frame and > doesn't > >> have > >> a native pointer, > >> > >> thus we do not invoke owner.execute() code block, while > >> nativeCreateNSWindow should be called with null ownerPtr. > >> > >> > >> -- > >> Thanks, > >> Alexander.
Re: [9] Review request for 8178996 [macos] JComboBox doesn't display popup in mixed JavaFX Swing Application on 8u131 and Mac OS 10.12
Looks good. --Semyon On 05/11/2017 01:54 AM, Alexander Zvegintsev wrote: Hi all, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8178996/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8178996 Popup doesn't show up due to owner is lightweight frame and doesn't have a native pointer, thus we do not invoke owner.execute() code block, while nativeCreateNSWindow should be called with null ownerPtr.
[9] Review request for 8178996 [macos] JComboBox doesn't display popup in mixed JavaFX Swing Application on 8u131 and Mac OS 10.12
Hi all, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8178996/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8178996 Popup doesn't show up due to owner is lightweight frame and doesn't have a native pointer, thus we do not invoke owner.execute() code block, while nativeCreateNSWindow should be called with null ownerPtr. -- Thanks, Alexander.
