Re: [10] Review request for 8177414: Missing key events on Mac Os

[Sergey Bylokhov]

Looks fine.

On 02.08.2017 7:26, Dmitry Markov wrote:

Hello,

Could you review a fix for jdk10, please?

bug: https://bugs.openjdk.java.net/browse/JDK-8177414
webrev: http://cr.openjdk.java.net/~dmarkov/8177414/webrev.00/

Problem description:
On OSX KEY_TYPED and KEY_PRESSED events might be lost if the input method such 
as ‘British’, ‘US International’ is set. That is caused by the current 
implementation of keyDown() method (see AWTView.m) which is responsible for 
transmitting native KEY_PRESSED events to java layer. If the flag 
willBeHandledByComplexInputMethod is set, the method stops sending the events 
to the java layer. However in some cases we may not have InputMethod object and 
KEY_PRESSED events will be incorrectly dropped.

Fix:
In keyDown() we have to check InputMethod object and drop key events only when 
non-null InputMethod is present.

Testing:
I ran corresponding JCK and regression tests and did not observe any new 
failures.

Thanks,
Dmitry




--
Best regards, Sergey.

Re: [10] Review request for JDK-8136999: [macosx] NSException and NPE in a crash test

[Sergey Bylokhov]

Looks fine.

On 03.08.2017 6:27, Manajit Halder wrote:

Hi Sergey,

Added the test case from the previous iteration of the fix. Please 
review the webrev:

http://cr.openjdk.java.net/~mhalder/8136999/webrev.01/

Regards,
Manajit

On 26-Jul-2017, at 10:32 PM, Sergey Bylokhov 
mailto:sergey.bylok...@oracle.com>> wrote:


Hi, Manajit.
Can you please add a test from the previous iteration of the fix:
http://cr.openjdk.java.net/~alexsch/8136999/webrev.00

-manajit.hal...@oracle.com wrote:
>
>Hi All,
>
>
>Kindly review the fix for JDK10.
>
>Bug:
>https://bugs.openjdk.java.net/browse/JDK-8136999
>
>Webrev:
>http://cr.openjdk.java.net/~mhalder/8136999/webrev.00/
>
>Fix:
>The flushEvent method is not required as mentioned in the previous 
review mail 
(http://mail.openjdk.java.net/pipermail/awt-dev/2015-October/010201.html).
>flushEvent related functionalities were modified while fixing issue 
JDK-8006634   
and hence deleted flushEvent method.

>
>Regards,
>Manajit





--
Best regards, Sergey.

Re: [10] Review request for 8178448: MenuBar item handler fired twice

[Sergey Bylokhov]

Looks fine.

On 02.08.2017 23:28, Alexander Zvegintsev wrote:

Hi Sergey,

http://cr.openjdk.java.net/~azvegint/jdk/10/8178448/01/

I've updated the test.

The JFrame needs to be iconified because it is stealing the keyboard 
focus, so accelerators for menu items will not be triggered.



Thanks,
Alexander.

On 02/08/2017 21:12, Sergey Bylokhov wrote:

Hi, Alex.
Is it possible to create a test for this issue? It will be similar to 
ActionListenerCalledTwiceTest


On 01.08.2017 22:34, Alexander Zvegintsev wrote:

Hi all,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8178448/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8178448

This Mac specific issue happens if setDefaultMenuBar() is called 
after setJMenuBar() with same instance of JMenuBar.


JFrame.setJMenuBar(mb);
Desktop.getDesktop().setDefaultMenuBar(mb);

--
Thanks,
Alexander.









--
Best regards, Sergey.

Re: [10] Review request for JDK-8136999: [macosx] NSException and NPE in a crash test

[Manajit Halder]

Hi Sergey,

Added the test case from the previous iteration of the fix. Please review the 
webrev:
http://cr.openjdk.java.net/~mhalder/8136999/webrev.01/ 


Regards,
Manajit

> On 26-Jul-2017, at 10:32 PM, Sergey Bylokhov  
> wrote:
> 
> Hi, Manajit.
> Can you please add a test from the previous iteration of the fix:
> http://cr.openjdk.java.net/~alexsch/8136999/webrev.00 
> 
> 
> - manajit.hal...@oracle.com  wrote: 
> > 
> > Hi All,
> > 
> > 
> > Kindly review the fix for JDK10.
> > 
> > Bug: 
> > https://bugs.openjdk.java.net/browse/JDK-8136999 
> > 
> > 
> > Webrev:
> > http://cr.openjdk.java.net/~mhalder/8136999/webrev.00/ 
> > 
> > 
> > Fix:
> > The flushEvent method is not required as mentioned in the previous review 
> > mail 
> > (http://mail.openjdk.java.net/pipermail/awt-dev/2015-October/010201.html). 
> >  
> > flushEvent related functionalities were modified while fixing issue 
> > JDK-8006634   and hence 
> > deleted flushEvent method. 
> > 
> > Regards,
> > Manajit