Integrated: JDK-8255681: print callstack in error case in runAWTLoopWithApp
On Tue, 3 Nov 2020 08:45:20 GMT, Matthias Baesken wrote: > Currently in case of occurences of an NSException in runAWTLoopWithApp we > catch the exception just print a simple error message like this : > > 2020-10-30 15:28:33.027 java[634:8435] Apple AWT Startup Exception: Cannot > lock focus on image , > because it is size zero. > 2020-10-30 15:28:33.306 java[634:8435] Apple AWT Restarting Native Event > Thread > > But we omit the callstack and loose valuable information. This change adds > the callstack to the output. This pull request has now been integrated. Changeset: ab9192e4 Author:Matthias Baesken URL: https://git.openjdk.java.net/jdk/commit/ab9192e4 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8255681: print callstack in error case in runAWTLoopWithApp Reviewed-by: clanger, serb - PR: https://git.openjdk.java.net/jdk/pull/1032
Re: RFR: JDK-8244088: [Regression] Switch of Gnome theme ends up in deadlocked UI
On Thu, 29 Oct 2020 13:14:49 GMT, Jayashree S Kumar wrote: > Issue > > https://bugs.openjdk.java.net/browse/JDK-8244088 > > Problem > > While using GTK3 java implementation, User sees a deadlock issue in UI while > trying to switch themes in gnome-tweak-tool. I'll run the tests for the proposed fix. - PR: https://git.openjdk.java.net/jdk/pull/932
Re: RFR: JDK-8255681: print callstack in error case in runAWTLoopWithApp
On Tue, 3 Nov 2020 08:45:20 GMT, Matthias Baesken wrote: > Currently in case of occurences of an NSException in runAWTLoopWithApp we > catch the exception just print a simple error message like this : > > 2020-10-30 15:28:33.027 java[634:8435] Apple AWT Startup Exception: Cannot > lock focus on image , > because it is size zero. > 2020-10-30 15:28:33.306 java[634:8435] Apple AWT Restarting Native Event > Thread > > But we omit the callstack and loose valuable information. This change adds > the callstack to the output. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1032
Integrated: 8196087: java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java fails
On Thu, 29 Oct 2020 04:12:53 GMT, Sergey Bylokhov wrote: > The test draws some specific pattern to the VolatileImage and to the > BufferedImage, and then compare pixels. > > The test uses the getSnapshot() method to get the pixels from VolatileImage, > and this method produces some interpolation "artifacts" if the fractional > scale is used in the system(like 125%). > > The solution is to use some predefined scale factors. This pull request has now been integrated. Changeset: 83f3cf42 Author:Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/83f3cf42 Stats: 4 lines in 2 files changed: 2 ins; 1 del; 1 mod 8196087: java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java fails Reviewed-by: jdv - PR: https://git.openjdk.java.net/jdk/pull/921
Re: RFR: 8241806: The sun/awt/shell/FileSystemViewMemoryLeak.java is unstable
On Tue, 3 Nov 2020 11:55:38 GMT, Alexey Ivanov wrote: > The test fails if OutOfMemoryError is thrown, right? > Is the reduced execution time enough to catch the original bug? It depends on the system, if it is really slow and just a few iterations out of 5000 will be done then the original bug will not be caught. If the system is fast and all 5000 iterations will be done, then the bug will be found. - PR: https://git.openjdk.java.net/jdk/pull/923
Integrated: 8255798: Remove dead headless code in CompileJavaModules.gmk
On Tue, 3 Nov 2020 08:21:22 GMT, Magnus Ihse Bursie wrote: > The variable BUILD_HEADLESS_ONLY is no longer set. And sun/applet does not > exist anymore. This pull request has now been integrated. Changeset: 64a98112 Author:Magnus Ihse Bursie URL: https://git.openjdk.java.net/jdk/commit/64a98112 Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod 8255798: Remove dead headless code in CompileJavaModules.gmk Reviewed-by: shade, erikj - PR: https://git.openjdk.java.net/jdk/pull/1031
Re: RFR: 8255798: Remove dead headless code in CompileJavaModules.gmk
On Tue, 3 Nov 2020 08:21:22 GMT, Magnus Ihse Bursie wrote: > The variable BUILD_HEADLESS_ONLY is no longer set. And sun/applet does not > exist anymore. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1031
Re: RFR: JDK-8255681: print callstack in error case in runAWTLoopWithApp
On Tue, 3 Nov 2020 08:45:20 GMT, Matthias Baesken wrote: > Currently in case of occurences of an NSException in runAWTLoopWithApp we > catch the exception just print a simple error message like this : > > 2020-10-30 15:28:33.027 java[634:8435] Apple AWT Startup Exception: Cannot > lock focus on image , > because it is size zero. > 2020-10-30 15:28:33.306 java[634:8435] Apple AWT Restarting Native Event > Thread > > But we omit the callstack and loose valuable information. This change adds > the callstack to the output. To me this looks like a good idea. In our current customer case this information would have greatly helped analysis. However, I'd like to see an opinion from one of the experts in that area on whether that's appropriate here. - Marked as reviewed by clanger (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1032
Re: RFR: 8241806: The sun/awt/shell/FileSystemViewMemoryLeak.java is unstable
On Tue, 3 Nov 2020 08:17:29 GMT, Jayathirth D V wrote: >> The test may work up to 15 minutes on some systems. >> The solution is to limit the time execution to 90 seconds. > > Marked as reviewed by jdv (Reviewer). The test fails if OutOfMemoryError is thrown, right? Is the reduced execution time enough to catch the original bug? - PR: https://git.openjdk.java.net/jdk/pull/923
Re: RFR: 8255798: Remove dead headless code in CompileJavaModules.gmk
On Tue, 3 Nov 2020 08:21:22 GMT, Magnus Ihse Bursie wrote: > The variable BUILD_HEADLESS_ONLY is no longer set. And sun/applet does not > exist anymore. Looks fine and trivial. - Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1031
RFR: JDK-8255681: print callstack in error case in runAWTLoopWithApp
Currently in case of occurences of an NSException in runAWTLoopWithApp we catch the exception just print a simple error message like this : 2020-10-30 15:28:33.027 java[634:8435] Apple AWT Startup Exception: Cannot lock focus on image , because it is size zero. 2020-10-30 15:28:33.306 java[634:8435] Apple AWT Restarting Native Event Thread But we omit the callstack and loose valuable information. This change adds the callstack to the output. - Commit messages: - JDK-8255681 Changes: https://git.openjdk.java.net/jdk/pull/1032/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1032&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8255681 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/1032.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1032/head:pull/1032 PR: https://git.openjdk.java.net/jdk/pull/1032
Re: RFR: 8241806: The sun/awt/shell/FileSystemViewMemoryLeak.java is unstable
On Thu, 29 Oct 2020 05:29:54 GMT, Sergey Bylokhov wrote: > The test may work up to 15 minutes on some systems. > The solution is to limit the time execution to 90 seconds. Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/923
Re: RFR: 8196087: java/awt/image/DrawImage/IncorrectUnmanagedImageRotatedClip.java fails
On Thu, 29 Oct 2020 04:12:53 GMT, Sergey Bylokhov wrote: > The test draws some specific pattern to the VolatileImage and to the > BufferedImage, and then compare pixels. > > The test uses the getSnapshot() method to get the pixels from VolatileImage, > and this method produces some interpolation "artifacts" if the fractional > scale is used in the system(like 125%). > > The solution is to use some predefined scale factors. Marked as reviewed by jdv (Reviewer). Please add CI test link in JBS. Looks good to me. - PR: https://git.openjdk.java.net/jdk/pull/921
