Re: RFR: JDK-8262420: typo: @implnote in java.desktop module
On Thu, 25 Feb 2021 23:15:03 GMT, Jonathan Gibbons wrote: > Please review some doc changes in `java.awt.TrayIcon`. > > Note, the fix is more than the 1-character fix for the typo detected by > doclint. The changes are: > > 1. Fix the name of the `@implNote` tag > 2. Remove the redundant `` before the `@implNote` tag > 3. Move the `@implNote` tag and its immediate content to after the following > paragraph, (beginning _See the ..._) which was originally part of the main > description, and does not appear that it should be part of the implementation > note. Marked as reviewed by azvegint (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2735
Re: RFR: JDK-8262420: typo: @implnote in java.desktop module
On Thu, 25 Feb 2021 23:15:03 GMT, Jonathan Gibbons wrote: > Please review some doc changes in `java.awt.TrayIcon`. > > Note, the fix is more than the 1-character fix for the typo detected by > doclint. The changes are: > > 1. Fix the name of the `@implNote` tag > 2. Remove the redundant `` before the `@implNote` tag > 3. Move the `@implNote` tag and its immediate content to after the following > paragraph, (beginning _See the ..._) which was originally part of the main > description, and does not appear that it should be part of the implementation > note. Marked as reviewed by prr (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2735
Re: RFR: JDK-8262420: typo: @implnote in java.desktop module
On Thu, 25 Feb 2021 23:15:03 GMT, Jonathan Gibbons wrote: > Please review some doc changes in `java.awt.TrayIcon`. > > Note, the fix is more than the 1-character fix for the typo detected by > doclint. The changes are: > > 1. Fix the name of the `@implNote` tag > 2. Remove the redundant `` before the `@implNote` tag > 3. Move the `@implNote` tag and its immediate content to after the following > paragraph, (beginning _See the ..._) which was originally part of the main > description, and does not appear that it should be part of the implementation > note. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2735
RFR: JDK-8262420: typo: @implnote in java.desktop module
Please review some doc changes in `java.awt.TrayIcon`. Note, the fix is more than the 1-character fix for the typo detected by doclint. The changes are: 1. Fix the name of the `@implNote` tag 2. Remove the redundant `` before the `@implNote` tag 3. Move the `@implNote` tag and its immediate content to after the following paragraph, (beginning _See the ..._) which was originally part of the main description, and does not appear that it should be part of the implementation note. - Commit messages: - JDK-8262420: typo: @implnote in java.desktop module Changes: https://git.openjdk.java.net/jdk/pull/2735/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2735=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262420 Stats: 7 lines in 1 file changed: 2 ins; 3 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2735.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2735/head:pull/2735 PR: https://git.openjdk.java.net/jdk/pull/2735
Re: RFR: 8262161 Refactor manual I/O stream copying to new convinient methods in java.desktop
On Mon, 21 Dec 2020 07:54:17 GMT, Andrey Turbanov wrote: > Cleanup code to use new handy methods in > `java.io.InputStream`/`java.nio.file.Files` instead of manual stream copy: > 1. java.io.InputStream#readAllBytes > 2. java.io.InputStream#transferTo > 3. java.nio.file.Files#copy > > Similar issue - https://bugs.openjdk.java.net/browse/JDK-8080272 The direct replacement of the old API by the new one looks fine. The tests are green. - Marked as reviewed by serb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1856
Re: RFR: 8262161 Refactor manual I/O stream copying to new convinient methods in java.desktop
On Mon, 21 Dec 2020 07:54:17 GMT, Andrey Turbanov
wrote:
> Cleanup code to use new handy methods in
> `java.io.InputStream`/`java.nio.file.Files` instead of manual stream copy:
> 1. java.io.InputStream#readAllBytes
> 2. java.io.InputStream#transferTo
> 3. java.nio.file.Files#copy
>
> Similar issue - https://bugs.openjdk.java.net/browse/JDK-8080272
src/java.desktop/unix/classes/sun/print/UnixPrintJob.java line 601:
> 599: try (BufferedInputStream bin = new
> BufferedInputStream(instream);
> 600: BufferedOutputStream bout = new
> BufferedOutputStream(output)) {
> 601: bin.transferTo(bout);
https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/io/InputStream.html#transferTo(java.io.OutputStream)
This method does not close either stream.
---
So this doesn't look right.
src/java.desktop/share/classes/com/sun/media/sound/DLSSoundbank.java line 990:
> 988: AudioInputStream stream = AudioSystem.getAudioInputStream(
> 989: audioformat, (AudioInputStream)sample.getData());
> 990: stream.transferTo(data_chunk);
Are all these audio streams buffered ? transferTo docs don't say anything in
terms of guarantees of what API they call. If it is unbuffered and it just
calls read(byte) over and over it would be really slow.
-
PR: https://git.openjdk.java.net/jdk/pull/1856
