Integrated: 8257414: Drag n Drop target area is wrong on high DPI systems
On Tue, 29 Dec 2020 20:56:06 GMT, Olga Mikhaltsova wrote: > Please, review this small fix for drag-n-drop on Linux with HiDPI turned on! > > This bug is due to the following reason: while scaling Java recalculates > resolution (W x H) according to sun.java2d.uiScale (W/SCALE x H/SCALE) and > works inside these new coordinates but at the same time the events, that come > from the system, continue reporting positions in the old coordinates (W x H). > > The idea of the suggested fix is in division of coordinates on the scale when > they come from the system to Java and multiplying them on the scale when they > go back from Java to the system. It is similar to processing events from > mouse and buttons. > > Testing is quite complicated because for reproducing this bug the following > conditions should be met: > 1.HiDPI is turned on > 2.sun.java2d.uiScale.enabled = true and sun.java2d.uiScale != 100% > 3.the source of drag-n-drop is non-java application > > The step-by-step guide how to reproduce this bug is added to > https://bugs.openjdk.java.net/browse/JDK-8257414. This pull request has now been integrated. Changeset: d3398324 Author:Olga Mikhaltsova Committer: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/d3398324 Stats: 31 lines in 2 files changed: 26 ins; 0 del; 5 mod 8257414: Drag n Drop target area is wrong on high DPI systems Reviewed-by: serb - PR: https://git.openjdk.java.net/jdk/pull/1907
Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v10]
> **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > The entire work on this was done under [OpenJDK Project - > Lanai](http://openjdk.java.net/projects/lanai/) > > We iterated through several Early Access (EA) builds and have reached a stage > where it is ready to be integrated to openjdk/jdk. The latest EA build is > available at - https://jdk.java.net/lanai/ > > A new option -Dsun.java2d.metal=true | True needs to be used to use this > pipeline. > > **Testing :** > This implementation has been tested with the tests present at - [Test Plan > for JEP 382: New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8251396) > > **Note to reviewers :** > 1) Default rendering pipeline on macOS has not been changed by this PR. > OpenGL still stays as the default rendering pipeline and Metal rendering > pipeline is optional to choose. > > 2) To apply and test this PR - > To enable the metal pipeline you must specify on command line > -Dsun.java2d.metal=true (No message will be printed in this case) or > -Dsun.java2d.metal=True (A message indicating Metal rendering pipeline is > enabled gets printed) > > 3) Review comments (including some preliminary informal review comments) are > tracked with JBS issues - https://bugs.openjdk.java.net/issues/?filter=40598 Ajit Ghaisas has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 36 additional commits since the last revision: - Lanai PR#206 - 8262729 - aghaisas - Lanai PR#205 - 8262496 - avu - Lanai PR#203 - 8262313 - jdv - Lanai PR#202 - 8262293 - avu - Lanai PR#201 - 8261891 - avu - Lanai PR#200 - 8262115 - aghaisas - Merge branch 'master' into 8260931_lanai_JEP_branch - Lanai PR#199 - 8262091 - aghaisas - Lanai PR#198 - 8261646 - avu - Lanai PR#197 - 8261960 - jdv - ... and 26 more: https://git.openjdk.java.net/jdk/compare/dd205a58...5cb1fd91 - Changes: - all: https://git.openjdk.java.net/jdk/pull/2403/files - new: https://git.openjdk.java.net/jdk/pull/2403/files/614be056..5cb1fd91 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=2403=09 - incr: https://webrevs.openjdk.java.net/?repo=jdk=2403=08-09 Stats: 14064 lines in 640 files changed: 7890 ins; 3094 del; 3080 mod Patch: https://git.openjdk.java.net/jdk/pull/2403.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2403/head:pull/2403 PR: https://git.openjdk.java.net/jdk/pull/2403
Re: RFR: 8257414: Drag n Drop target area is wrong on high DPI systems [v3]
On Sat, 27 Feb 2021 01:18:58 GMT, Sergey Bylokhov wrote: >> Olga Mikhaltsova has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8257414: Drag n Drop target area is wrong on high DPI systems > > Marked as reviewed by serb (Reviewer). Sergey, thank you for reviewing! - PR: https://git.openjdk.java.net/jdk/pull/1907
