Re: RFR: 8262446: DragAndDrop hangs on Windows
On Thu, 4 Mar 2021 10:36:56 GMT, Dmitry Markov wrote: > The IME functions and the DND operation must be executed on the toolkit > thread. If the DND operation is in progress, the IME API is invoked via > SendMessage() call inside InvokeInputMethodFunction() to avoid a hang. The > flag isInDoDragDropLoop indicates whether the DND takes place or not. The > flag works properly if the DND is performed between two Java windows. However > if anything is dragged from native app, (e.g. Windows FileExplorer) to Java > the flag is NOT set. That’s the root cause of the hang. > > Fix: > Introduce a new flag to indicate DND operation between Java and native app. > > Testing: > mach5 green @dmarkov20 I'd like to confirm this issue was not fixed by [JDK-8261231](https://bugs.openjdk.java.net/browse/JDK-8261231) #2448 ? - PR: https://git.openjdk.java.net/jdk/pull/2825
Re: RFR: 8262446: DragAndDrop hangs on Windows
On Thu, 4 Mar 2021 19:38:34 GMT, Alexey Ivanov wrote: >> The IME functions and the DND operation must be executed on the toolkit >> thread. If the DND operation is in progress, the IME API is invoked via >> SendMessage() call inside InvokeInputMethodFunction() to avoid a hang. The >> flag isInDoDragDropLoop indicates whether the DND takes place or not. The >> flag works properly if the DND is performed between two Java windows. >> However if anything is dragged from native app, (e.g. Windows FileExplorer) >> to Java the flag is NOT set. That’s the root cause of the hang. >> >> Fix: >> Introduce a new flag to indicate DND operation between Java and native app. >> >> Testing: >> mach5 green > > Marked as reviewed by aivanov (Reviewer). Why we cannot reuse the old flag? "isInDoDragDropLoop"? I think the Robot.waitForIdle() will hang if isInDoDragDropLoop is not set to true while dragging something from the native app. - PR: https://git.openjdk.java.net/jdk/pull/2825
Re: RFR: 8250804: Can't set the application icon image for Unity WM on Linux.
On Fri, 5 Mar 2021 01:17:38 GMT, Sergey Bylokhov wrote: >> As of now we can have two icons: on the side dock and on the top bar. >> But this test was written for an old time Unity with an icon in the side >> dock only. >> >> Icon at the top by default is displayed as grayscale(the actual reason of >> submitting bug report). >> BTW it may not be presented depending on Gnome Shell settings. >> >> `setIconImage()` seems to be working as expected in this case, but we need >> to clarify the test's instruction. >> >> Besides that the test has another issue: it does not fail on pressing "Fail" >> button. It is also fixed. > > test/jdk/ProblemList.txt line 855: > >> 853: >> java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java >> 8162380 generic-all >> 854: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java >> 8163086 macosx-all >> 855: java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java >> 8250804 macosx-all,linux-all > > Does this test work fine on the macOS? Looks like it was reported here: > > https://bugs.openjdk.java.net/browse/JDK-8250804?focusedCommentId=14379402&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14379402 O, I see that you made it Linux only. - PR: https://git.openjdk.java.net/jdk/pull/2838
Re: RFR: 8250804: Can't set the application icon image for Unity WM on Linux.
On Fri, 5 Mar 2021 00:55:04 GMT, Alexander Zvegintsev wrote: > As of now we can have two icons: on the side dock and on the top bar. > But this test was written for an old time Unity with an icon in the side dock > only. > > Icon at the top by default is displayed as grayscale(the actual reason of > submitting bug report). > BTW it may not be presented depending on Gnome Shell settings. > > `setIconImage()` seems to be working as expected in this case, but we need to > clarify the test's instruction. > > Besides that the test has another issue: it does not fail on pressing "Fail" > button. It is also fixed. Marked as reviewed by serb (Reviewer). test/jdk/ProblemList.txt line 855: > 853: java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java > 8162380 generic-all > 854: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java > 8163086 macosx-all > 855: java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java 8250804 > macosx-all,linux-all Does this test work fine on the macOS? Looks like it was reported here: https://bugs.openjdk.java.net/browse/JDK-8250804?focusedCommentId=14379402&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14379402 - PR: https://git.openjdk.java.net/jdk/pull/2838
RFR: 8250804: Can't set the application icon image for Unity WM on Linux.
As of now we can have two icons: on the side dock and on the top bar. But this test was written for an old time Unity with an icon in the side dock only. Icon at the top by default is displayed as grayscale(the actual reason of submitting bug report). BTW it may not be presented depending on Gnome Shell settings. `setIconImage()` seems to be working as expected in this case, but we need to clarify the test's instruction. Besides that the test has another issue: it does not fail on pressing "Fail" button. It is also fixed. - Commit messages: - ProblemList - initial Changes: https://git.openjdk.java.net/jdk/pull/2838/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2838&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8250804 Stats: 22 lines in 2 files changed: 9 ins; 5 del; 8 mod Patch: https://git.openjdk.java.net/jdk/pull/2838.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2838/head:pull/2838 PR: https://git.openjdk.java.net/jdk/pull/2838
Re: RFR: 8262446: DragAndDrop hangs on Windows
On Thu, 4 Mar 2021 10:36:56 GMT, Dmitry Markov wrote: > The IME functions and the DND operation must be executed on the toolkit > thread. If the DND operation is in progress, the IME API is invoked via > SendMessage() call inside InvokeInputMethodFunction() to avoid a hang. The > flag isInDoDragDropLoop indicates whether the DND takes place or not. The > flag works properly if the DND is performed between two Java windows. However > if anything is dragged from native app, (e.g. Windows FileExplorer) to Java > the flag is NOT set. That’s the root cause of the hang. > > Fix: > Introduce a new flag to indicate DND operation between Java and native app. > > Testing: > mach5 green Marked as reviewed by aivanov (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2825
RFR: 8262446: DragAndDrop hangs on Windows
The IME functions and the DND operation must be executed on the toolkit thread. If the DND operation is in progress, the IME API is invoked via SendMessage() call inside InvokeInputMethodFunction() to avoid a hang. The flag isInDoDragDropLoop indicates whether the DND takes place or not. The flag works properly if the DND is performed between two Java windows. However if anything is dragged from native app, (e.g. Windows FileExplorer) to Java the flag is NOT set. That’s the root cause of the hang. Fix: Introduce a new flag to indicate DND operation between Java and native app. Testing: mach5 green - Commit messages: - 8262446: DragAndDrop hangs on Windows Changes: https://git.openjdk.java.net/jdk/pull/2825/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2825&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262446 Stats: 10 lines in 3 files changed: 9 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2825.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2825/head:pull/2825 PR: https://git.openjdk.java.net/jdk/pull/2825
