Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X

2021-03-19 Thread Sergey Bylokhov 
On Fri, 19 Mar 2021 23:10:46 GMT, Alexander Zuev  wrote:

> 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X

src/java.desktop/macosx/native/libawt_lwawt/awt/JavaComponentAccessibility.m 
line 1459:

> 1457: {
> 1458: JNIEnv *env = [ThreadUtilities getJNIEnv];
> 1459: GET_CACCESSIBILITY_CLASS_RETURN(nil);

Is it caused by the JDK-8257853? Should we update the accessibilityIndexOfChild 
as well?

-

PR: https://git.openjdk.java.net/jdk/pull/3099

Re: RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X

2021-03-19 Thread Alexander Zvegintsev 
On Fri, 19 Mar 2021 23:10:46 GMT, Alexander Zuev  wrote:

> 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X

Since there is no test, I assume that the JBS issue should have `noreg-hard` 
label.

-

Marked as reviewed by azvegint (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3099

RFR: 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X

2021-03-19 Thread Alexander Zuev 
8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X

-

Commit messages:
 - 8263846: Bad JNI lookup getFocusOwner in accessibility code on Mac OS X

Changes: https://git.openjdk.java.net/jdk/pull/3099/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3099=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8263846
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3099.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3099/head:pull/3099

PR: https://git.openjdk.java.net/jdk/pull/3099

Integrated: 8247370: Clean up unused printing code in awt_PrintJob.cpp

2021-03-19 Thread Phil Race 
On Thu, 18 Mar 2021 22:59:57 GMT, Phil Race  wrote:

> This removes a long time un-used code path.

This pull request has now been integrated.

Changeset: d41f7512
Author:Phil Race 
URL:   https://git.openjdk.java.net/jdk/commit/d41f7512
Stats: 29 lines in 1 file changed: 0 ins; 19 del; 10 mod

8247370: Clean up unused printing code in awt_PrintJob.cpp

Reviewed-by: serb, psadhukhan

-

PR: https://git.openjdk.java.net/jdk/pull/3083

Re: RFR: 8247370: Clean up unused printing code in awt_PrintJob.cpp

2021-03-19 Thread Phil Race 
On Fri, 19 Mar 2021 04:45:46 GMT, Prasanta Sadhukhan  
wrote:

> Maybe we should put noreg-cleanup in JBS.

done

-

PR: https://git.openjdk.java.net/jdk/pull/3083

libfontmanager.so: undefined symbol: hb_font_destroy in openjdk17~14

2021-03-19 Thread mc36 
hi,
just upgraded from openjdk17~11 to openjdk17~14 
(https://packages.debian.org/sid/main/openjdk-17-jdk) on my debian sid. i 
quickly noticed that something is wrong so i ended up with the below sample app.
i'm not a big c coder so all i was able to do is that i got the libharfbuzz 
sources  (https://packages.debian.org/unstable/libharfbuzz-dev) and checked 
that i have that version and the function is there.
i would appreciate some idea what else should i try?
thanks,
csaba


mc36@noti:~$ cat a.java

import java.awt.Graphics2D;
import java.awt.image.BufferedImage;

public class a {

    public static void main(String[] args) throws Exception {
    BufferedImage img = new BufferedImage(100, 100, 
BufferedImage.TYPE_INT_RGB);
    Graphics2D g2d = img.createGraphics();
    }

}


mc36@noti:~$ javac a.java
mc36@noti:~$ java a
Exception in thread "main" java.lang.UnsatisfiedLinkError: 
/usr/lib/jvm/java-17-openjdk-amd64/lib/libfontmanager.so: 
/usr/lib/jvm/java-17-openjdk-amd64/lib/libfontmanager.so: undefined symbol: 
hb_font_destroy
    at java.base/jdk.internal.loader.NativeLibraries.load(Native Method)
    at 
java.base/jdk.internal.loader.NativeLibraries$NativeLibraryImpl.open(NativeLibraries.java:383)
    at 
java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:227)
    at 
java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:169)
    at 
java.base/jdk.internal.loader.NativeLibraries.findFromPaths(NativeLibraries.java:310)
    at 
java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:280)
    at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2392)
    at java.base/java.lang.Runtime.loadLibrary0(Runtime.java:808)
    at java.base/java.lang.System.loadLibrary(System.java:1893)
    at 
java.desktop/sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:57)
    at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:312)
    at 
java.desktop/sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32)
    at 
java.desktop/sun.java2d.xr.XRSurfaceData.initXRSurfaceData(XRSurfaceData.java:104)
    at 
java.desktop/sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:122)
    at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:312)
    at 
java.desktop/sun.awt.X11GraphicsEnvironment.(X11GraphicsEnvironment.java:59)
    at 
java.desktop/sun.awt.PlatformGraphicsInfo.createGE(PlatformGraphicsInfo.java:36)
    at 
java.desktop/java.awt.GraphicsEnvironment$LocalGE.createGE(GraphicsEnvironment.java:93)
    at 
java.desktop/java.awt.GraphicsEnvironment$LocalGE.(GraphicsEnvironment.java:84)
    at 
java.desktop/java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment(GraphicsEnvironment.java:106)
    at 
java.desktop/java.awt.image.BufferedImage.createGraphics(BufferedImage.java:1181)
    at a.main(a.java:9)
mc36@noti:~$