Re: RFR: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception

2021-05-10 Thread Pankaj Bansal
On Mon, 10 May 2021 21:38:37 GMT, Sergey Bylokhov  wrote:

> An exception occurs when the main thread disposes of the frame while the 
> other thread still renders to it. The fix joins the main thread to other 
> threads, so we will dispose of the frame at the end only.

Marked as reviewed by pbansal (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3957


Re: RFR: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception

2021-05-10 Thread Alexander Zuev
On Mon, 10 May 2021 21:38:37 GMT, Sergey Bylokhov  wrote:

> An exception occurs when the main thread disposes of the frame while the 
> other thread still renders to it. The fix joins the main thread to other 
> threads, so we will dispose of the frame at the end only.

Marked as reviewed by kizune (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3957


Re: RFR: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception

2021-05-10 Thread Alexander Zvegintsev
On Mon, 10 May 2021 21:38:37 GMT, Sergey Bylokhov  wrote:

> An exception occurs when the main thread disposes of the frame while the 
> other thread still renders to it. The fix joins the main thread to other 
> threads, so we will dispose of the frame at the end only.

Marked as reviewed by azvegint (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3957


RFR: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception

2021-05-10 Thread Sergey Bylokhov
An exception occurs when the main thread disposes of the frame while the other 
thread still renders to it. The fix joins the main thread to other threads, so 
we will dispose of the frame at the end only.

-

Commit messages:
 - Initial fix

Changes: https://git.openjdk.java.net/jdk/pull/3957/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3957=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8047218
  Stats: 20 lines in 2 files changed: 0 ins; 9 del; 11 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3957.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3957/head:pull/3957

PR: https://git.openjdk.java.net/jdk/pull/3957


Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

2021-05-10 Thread Tejpal Rebari
On Fri, 9 Apr 2021 05:42:37 GMT, Tejpal Rebari  wrote:

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

I am working on it. Will update the next version  soon.

-

PR: https://git.openjdk.java.net/jdk/pull/3407


Integrated: 8226384: Implement a better logic to switch between OpenGL and Metal pipeline

2021-05-10 Thread Jayathirth D V
On Tue, 4 May 2021 11:02:40 GMT, Jayathirth D V  wrote:

> We have many if else conditions to select OpenGL/Metal pipeline objects.
> Apart from initialization phase we should not fetch these objects everytime 
> checking whether we are using OpenGL/Metal pipeline.

This pull request has now been integrated.

Changeset: 53db2a0a
Author:Jayathirth D V 
URL:   
https://git.openjdk.java.net/jdk/commit/53db2a0acd4e208fb5cfb7108206ec667c7c4131
Stats: 186 lines in 5 files changed: 83 ins; 91 del; 12 mod

8226384: Implement a better logic to switch between OpenGL and Metal pipeline

Reviewed-by: prr

-

PR: https://git.openjdk.java.net/jdk/pull/3851