Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v4]

2021-05-16 Thread Tejpal Rebari 
> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

Tejpal Rebari has updated the pull request incrementally with one additional 
commit since the last revision:

  initialize in static block added doprivilged and removed @available

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3407/files
  - new: https://git.openjdk.java.net/jdk/pull/3407/files/8193b3e4..4c345924

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3407=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3407=02-03

  Stats: 25 lines in 2 files changed: 13 ins; 8 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8182043: Access to Windows Large Icons [v7]

2021-05-16 Thread Alexander Zuev 
On Sun, 16 May 2021 18:49:24 GMT, Alexander Zvegintsev  
wrote:

>> Alexander Zuev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Slight change of wording in javadoc
>>   Fixed Win32ShellFolder2.getSystemIcon scaling issue
>
> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java 
> line 271:
> 
>> 269: * Example: 
>> 270: * FileSystemView fsv = FileSystemView.getFileSystemView();
>> 271: * Icon icon = fsv.getSystemIcon("application.exe", 64);
> 
> Shouldn't the first parameter be a File instance instead of String?
> `Icon icon = fsv.getSystemIcon(new File("application.exe"), 64);`

Good catch! Yes, fixed both here and in CSR.

-

PR: https://git.openjdk.java.net/jdk/pull/2875

Re: RFR: 8182043: Access to Windows Large Icons [v8]

2021-05-16 Thread Alexander Zuev 
> Fix updated after first round of review.

Alexander Zuev has updated the pull request incrementally with one additional 
commit since the last revision:

  Example in JavaDoc fixed

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2875/files
  - new: https://git.openjdk.java.net/jdk/pull/2875/files/4cd5a508..911bc70b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=2875=07
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=2875=06-07

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2875.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2875/head:pull/2875

PR: https://git.openjdk.java.net/jdk/pull/2875

Re: RFR: 8182043: Access to Windows Large Icons [v7]

2021-05-16 Thread Alexander Zvegintsev 
On Fri, 14 May 2021 19:46:03 GMT, Alexander Zuev  wrote:

>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Slight change of wording in javadoc
>   Fixed Win32ShellFolder2.getSystemIcon scaling issue

src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line 
271:

> 269: * Example: 
> 270: * FileSystemView fsv = FileSystemView.getFileSystemView();
> 271: * Icon icon = fsv.getSystemIcon("application.exe", 64);

Shouldn't the first parameter be a File instance instead of String?
`Icon icon = fsv.getSystemIcon(new File("application.exe"), 64);`

-

PR: https://git.openjdk.java.net/jdk/pull/2875