Re: RFR: 8181571: printing to CUPS fails on mac sandbox app

2021-08-05 Thread Alexander Scherbatiy 
On Wed, 28 Jul 2021 17:18:12 GMT, NikolayTach 
 wrote:

> [JDK-8247768 ](https://bugs.openjdk.java.net/browse/JDK-8247768)
> Same here played 6 times yet moved, 8 issues missed.

What is the relation between JDK-8247768 and the current pull request?
Should something be updated in the pull request description?

-

PR: https://git.openjdk.java.net/jdk/pull/4861

Integrated: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

2021-08-05 Thread rajat mahajan 
On Thu, 29 Jul 2021 20:29:31 GMT, rajat mahajan 
 wrote:

> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on 
> all OS. Added synchronization for focusCnt.

This pull request has now been integrated.

Changeset: cb368802
Author:Rajat Mahajan 
Committer: Alexey Ivanov 
URL:   
https://git.openjdk.java.net/jdk/commit/cb368802815c465f8eef7aa930d6cbb6540d0fa8
Stats: 114 lines in 1 file changed: 44 ins; 28 del; 42 mod

8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, 
including Aqua on macOS

Reviewed-by: psadhukhan, aivanov

-

PR: https://git.openjdk.java.net/jdk/pull/4937

Re: RFR: 8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility [v9]

2021-08-05 Thread Victor Dyakov 
On Mon, 2 Aug 2021 05:45:35 GMT, Sergey Bylokhov  wrote:

>> As @ azuev-java canceled below this is not functional regression.
>> However, cell navigation will be implemented later in 
>> [JDK-8271071](https://bugs.openjdk.java.net/browse/JDK-8271071).
>
> ok

Ok

-

PR: https://git.openjdk.java.net/jdk/pull/4412

Re: RFR: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS [v2]

2021-08-05 Thread Alexey Ivanov 
On Wed, 4 Aug 2021 21:43:53 GMT, rajat mahajan 
 wrote:

>> Summary: Expanded ButtonGroupLayoutTraversalTest.java to run in all LAFs on 
>> all OS. Added synchronization for focusCnt.
>
> rajat mahajan has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   make variables with static final modifier CAPS, as per coding standard.

Marked as reviewed by aivanov (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4937

Integrated: 8270058: Use Objects.check{Index, FromIndexSize} for java.desktop

2021-08-05 Thread Yi Yang 
On Thu, 8 Jul 2021 08:32:49 GMT, Yi Yang  wrote:

> After JDK-8265518(#3615), it's possible to replace all variants of checkIndex 
> by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in 
> the whole JDK codebase.
> 
> As Mandy suggested, I create this PR for changes involving client code:
> 
> src/java.desktop/share/classes/com/sun/media/sound/AudioFloatInputStream.java
> src/java.desktop/share/classes/javax/swing/JTabbedPane.java
> test/jdk/java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java
> test/jdk/javax/imageio/AppletResourceTest.java
> test/jdk/javax/imageio/ImageReaderReadAll.java
> test/jdk/javax/imageio/metadata/IIOMetadataFormat/UserPluginMetadataFormatTest.java

This pull request has now been integrated.

Changeset: ea9a5952
Author:Yi Yang 
URL:   
https://git.openjdk.java.net/jdk/commit/ea9a59520de45fe1c2a6706b2a924cbc856a06c6
Stats: 41 lines in 6 files changed: 7 ins; 19 del; 15 mod

8270058: Use Objects.check{Index,FromIndexSize} for java.desktop

Reviewed-by: psadhukhan, pbansal, jdv

-

PR: https://git.openjdk.java.net/jdk/pull/4718