Re: RFR: 8268620: InfiniteLoopException test may fail on x86 platforms

[Tejpal Rebari]

On Mon, 14 Jun 2021 17:18:15 GMT, Sergey Bylokhov  wrote:

> Small test update.
> 
> This test posts lots of events to EDT from the different threads, and it 
> checks that the robot.waitForIdle() on the main thread will not hang or throw 
> an exception. And this test fails on x86. The post of events are implemented 
> via wait/notifyAll, and the robot.waitForIdle() is also implemented via 
> wait/notifyAll on the same monitor, and on x86 platform, the wait() in the 
> robot.waitForIdle() is never interrupted/notified by the notifyAll(), and it 
> hangs forever.
> 
> I do not think this bug is specific to the x86(I tested 8u), it is just 
> accidentally working fine on the mainline.

Marked as reviewed by trebari (Committer).

-

PR: https://git.openjdk.java.net/jdk/pull/4488

Integrated: 8256465: [macos] Java frame and dialog presented full screen freeze application

[Tejpal Rebari]

On Fri, 9 Apr 2021 05:42:37 GMT, Tejpal Rebari  wrote:

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

This pull request has now been integrated.

Changeset: 042f0bdb
Author:Tejpal Rebari 
URL:   
https://git.openjdk.java.net/jdk/commit/042f0bdb3568edab4f96b9f7c83cbb0f90db7f18
Stats: 171 lines in 3 files changed: 169 ins; 0 del; 2 mod

8256465: [macos] Java frame and dialog presented full screen freeze application

Reviewed-by: kcr, serb, prr

-

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos] Java frame and dialog presented full screen freeze application [v10]

[Tejpal Rebari]

On Fri, 4 Jun 2021 13:48:18 GMT, Kevin Rushforth  wrote:

>> Tejpal Rebari has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   add SupressWarnings and test changes
>
> test/jdk/java/awt/Window/TestAppFreeze.java line 107:
> 
>> 105: 
>> 106: private static void testApp() {
>> 107: testFrame = new JFrame("TestFrame");
> 
> This is being run on the wrong thread. You should wrap this method in an 
> `invokeLater` as you did in the `createInstructionUI` method.

yeah , i have added this code to run on  EDT.

-

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos] Java frame and dialog presented full screen freeze application [v11]

[Tejpal Rebari]

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

Tejpal Rebari has updated the pull request incrementally with one additional 
commit since the last revision:

  call on testApp on correct thread

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3407/files
  - new: https://git.openjdk.java.net/jdk/pull/3407/files/d710f761..c078f8d2

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3407=10
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3407=09-10

  Stats: 14 lines in 1 file changed: 2 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v10]

[Tejpal Rebari]

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

Tejpal Rebari has updated the pull request incrementally with one additional 
commit since the last revision:

  add SupressWarnings and test changes

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3407/files
  - new: https://git.openjdk.java.net/jdk/pull/3407/files/28752a2c..d710f761

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3407=09
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3407=08-09

  Stats: 9 lines in 2 files changed: 2 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v8]

[Tejpal Rebari]

On Thu, 3 Jun 2021 11:48:41 GMT, Kevin Rushforth  wrote:

>> Tejpal Rebari has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   updated the comment
>
> test/jdk/java/awt/Window/TestAppFreeze.java line 64:
> 
>> 62: private static void createInstructionUI() {
>> 63: SwingUtilities.invokeLater(() -> {
>> 64: String instruction = "1. This test is only for Mac OS 
>> Version 11 " +
> 
> This bug also affects macOS 10.15. On 10.15 the "Prefer Tabs" setting in the 
> `System Preferences -> Dock` rather than `-> General`.

Yeah, i think it will affect Mac OS 10.12.+  as the tabbedWindows was 
introduced in 10.12 , i have checked it affects the 10.14 , don't have earlier 
version to check.

-

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v9]

[Tejpal Rebari]

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

Tejpal Rebari has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains 11 additional commits 
since the last revision:

 - Merge remote-tracking branch 'upstream/master' into 8256465
 - updated the comment
 - make string final
 - doPrivileged to the system.getproperty
 - addressed review comments
 - made changed according to CSR comments
 - initialize in static block added doprivilged and removed @available
 - code cleanup
 - Merge remote-tracking branch 'upstream/master' into 8256465
 - add system property
 - ... and 1 more: https://git.openjdk.java.net/jdk/compare/6fe46985...28752a2c

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3407/files
  - new: https://git.openjdk.java.net/jdk/pull/3407/files/7fbb729e..28752a2c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3407=08
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3407=07-08

  Stats: 129126 lines in 4462 files changed: 46743 ins; 68014 del; 14369 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v8]

[Tejpal Rebari]

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

Tejpal Rebari has updated the pull request incrementally with one additional 
commit since the last revision:

  updated the comment

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3407/files
  - new: https://git.openjdk.java.net/jdk/pull/3407/files/f2a9198e..7fbb729e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3407=07
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3407=06-07

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v7]

[Tejpal Rebari]

On Mon, 31 May 2021 11:23:46 GMT, Jayathirth D V  wrote:

>> Tejpal Rebari has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - make string final
>>  - doPrivileged to the system.getproperty
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 
> 130:
> 
>> 128: public static final String WINDOW_TITLE_VISIBLE = 
>> "apple.awt.windowTitleVisible";
>> 129: 
>> 130: // This system property is used in javafx as well
> 
> Reword this comment to mentioned that it is named as jdk.* because the 
> property is not specific to AWT and it will be used in JavaFX also.

yeah , instead of "will be used" we should used "is used" because that will be 
the situation after some time.

-

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v5]

[Tejpal Rebari]

On Thu, 20 May 2021 19:50:32 GMT, Sergey Bylokhov  wrote:

>> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m line 1107:
>> 
>>> 1105: JNI_COCOA_ENTER(env);
>>> 1106: if (allowAutomaticTabbing) {
>>> 1107: [NSWindow setAllowsAutomaticWindowTabbing:YES];
>> 
>> Should we access this property on the Appkit thread? Or this can be used 
>> everywhere?
>
> Do we plan to backport the same fix or a different one?

We will backport the same fix with one additional  platform check.

-

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v7]

[Tejpal Rebari]

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

Tejpal Rebari has updated the pull request incrementally with two additional 
commits since the last revision:

 - make string final
 - doPrivileged to the system.getproperty

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3407/files
  - new: https://git.openjdk.java.net/jdk/pull/3407/files/a09aea52..f2a9198e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3407=06
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3407=05-06

  Stats: 11 lines in 1 file changed: 1 ins; 7 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v6]

[Tejpal Rebari]

On Fri, 28 May 2021 12:26:31 GMT, Tejpal Rebari  wrote:

>> Hi All,
>> Please review the following fix for jdk17.
>> 
>> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
>> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
>> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
>> "Always".
>> It doesn't freeze when the Prefer tabs is set to "never".
>> 
>> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
>> prior to bigSur(11)  
>> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
>> and 10.15.
>> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
>> This issue can also be reproduced in MacOS 10.15 by setting 
>> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
>> 
>> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
>> staring from 10.12.
>> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
>> value changed in macos11.
>> 
>> Test : Added a manual test and tested on MacOS 10.15 and 11.
>> All the internal tests run are green.
>
> Tejpal Rebari has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   addressed review comments

src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 131:

> 129: 
> 130: // This system property is used in javafx as well
> 131: public static final String MAC_OS_TABBED_WINDOW = 
> System.getProperty("jdk.allowMacOSTabbedWindows");

need to add doPrivileged here

-

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v6]

[Tejpal Rebari]

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

Tejpal Rebari has updated the pull request incrementally with one additional 
commit since the last revision:

  addressed review comments

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3407/files
  - new: https://git.openjdk.java.net/jdk/pull/3407/files/dd910f73..a09aea52

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3407=05
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3407=04-05

  Stats: 11 lines in 2 files changed: 5 ins; 0 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v5]

[Tejpal Rebari]

On Thu, 20 May 2021 08:09:09 GMT, Tejpal Rebari  wrote:

>> Hi All,
>> Please review the following fix for jdk17.
>> 
>> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
>> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
>> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
>> "Always".
>> It doesn't freeze when the Prefer tabs is set to "never".
>> 
>> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
>> prior to bigSur(11)  
>> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
>> and 10.15.
>> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
>> This issue can also be reproduced in MacOS 10.15 by setting 
>> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
>> 
>> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
>> staring from 10.12.
>> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
>> value changed in macos11.
>> 
>> Test : Added a manual test and tested on MacOS 10.15 and 11.
>> All the internal tests run are green.
>
> Tejpal Rebari has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   made changed according to CSR comments

Please review the CSR https://bugs.openjdk.java.net/browse/JDK-8267238 as well.

-

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v3]

[Tejpal Rebari]

On Thu, 13 May 2021 20:43:01 GMT, Phil Race  wrote:

>> Tejpal Rebari has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   code cleanup
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 
> 325:
> 
>> 323: responder = createPlatformResponder();
>> 324: contentView.initialize(peer, responder);
>> 325: setAllowAutomaticWindowTabbing();
> 
> This is in the initialize() method that is being called for every window.
> That means the value could be changed by the app (back and forth!) during the 
> execution of the program.
> We don't want that. So add it in a static initializer block for the class, so 
> it is only ever read ONCE and guaranteed to be read before the first window 
> is created. This then means the Java method isn't needed and the native 
> method will be static.

Yeah, i have changed the method call to the native method in  a static block 
and added the doPrivileged around getProperty.

> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java line 
> 607:
> 
>> 605: 
>> nativeSetAllowAutomaticTabbingProperty(allowAutomaticWindowTabbing);
>> 606: }
>> 607: 
> 
> So we need a doPrivilged around the call to getProperty - in the new location 
> of the static block

Done

-

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v5]

[Tejpal Rebari]

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

Tejpal Rebari has updated the pull request incrementally with one additional 
commit since the last revision:

  made changed according to CSR comments

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3407/files
  - new: https://git.openjdk.java.net/jdk/pull/3407/files/4c345924..dd910f73

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3407=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3407=03-04

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v4]

[Tejpal Rebari]

On Mon, 17 May 2021 05:57:18 GMT, Tejpal Rebari  wrote:

>> Hi All,
>> Please review the following fix for jdk17.
>> 
>> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
>> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
>> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
>> "Always".
>> It doesn't freeze when the Prefer tabs is set to "never".
>> 
>> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
>> prior to bigSur(11)  
>> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
>> and 10.15.
>> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
>> This issue can also be reproduced in MacOS 10.15 by setting 
>> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
>> 
>> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
>> staring from 10.12.
>> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
>> value changed in macos11.
>> 
>> Test : Added a manual test and tested on MacOS 10.15 and 11.
>> All the internal tests run are green.
>
> Tejpal Rebari has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   initialize in static block added doprivilged and removed @available

Created CSR  : https://bugs.openjdk.java.net/browse/JDK-8267238.

-

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v4]

[Tejpal Rebari]

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

Tejpal Rebari has updated the pull request incrementally with one additional 
commit since the last revision:

  initialize in static block added doprivilged and removed @available

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3407/files
  - new: https://git.openjdk.java.net/jdk/pull/3407/files/8193b3e4..4c345924

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3407=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3407=02-03

  Stats: 25 lines in 2 files changed: 13 ins; 8 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v3]

[Tejpal Rebari]

On Tue, 11 May 2021 11:43:35 GMT, Tejpal Rebari  wrote:

>> Hi All,
>> Please review the following fix for jdk17.
>> 
>> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
>> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
>> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
>> "Always".
>> It doesn't freeze when the Prefer tabs is set to "never".
>> 
>> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
>> prior to bigSur(11)  
>> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
>> and 10.15.
>> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
>> This issue can also be reproduced in MacOS 10.15 by setting 
>> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
>> 
>> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
>> staring from 10.12.
>> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
>> value changed in macos11.
>> 
>> Test : Added a manual test and tested on MacOS 10.15 and 11.
>> All the internal tests run are green.
>
> Tejpal Rebari has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   code cleanup

Is there any place where we specify that "-Djdk.allowTabbedWindows" is a new 
jdk property which is for the macos automatic window tabbing. 
This is off by default and can be set using 
-Djdk.allowTabbedWindows=true/TRUE/TrUE ... .

-

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v3]

[Tejpal Rebari]

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

Tejpal Rebari has updated the pull request incrementally with one additional 
commit since the last revision:

  code cleanup

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3407/files
  - new: https://git.openjdk.java.net/jdk/pull/3407/files/d85a002d..8193b3e4

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3407=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3407=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v2]

[Tejpal Rebari]

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

Tejpal Rebari has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains three additional 
commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into 8256465
 - add system property
 - initial fix and test

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3407/files
  - new: https://git.openjdk.java.net/jdk/pull/3407/files/20c17200..d85a002d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=3407=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3407=00-01

  Stats: 622608 lines in 6496 files changed: 78609 ins; 528843 del; 15156 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

[Tejpal Rebari]

On Fri, 9 Apr 2021 05:42:37 GMT, Tejpal Rebari  wrote:

> Hi All,
> Please review the following fix for jdk17.
> 
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
> Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
> Screen". It is also freezing in normal screen when Prefer Tabs is set to 
> "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> 
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS 
> prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 
> and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting 
> setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> 
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> value changed in macos11.
> 
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

I am working on it. Will update the next version  soon.

-

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

[Tejpal Rebari]

On Sat, 10 Apr 2021 23:22:06 GMT, Philip Race  wrote:

> It would be interesting to have an enumeration of known and suspected 
> problems with this.
> 
> * where is it inappropriate UI - if we have an unowned dialog it is really 
> weird to popup it up in a new tab.
>   Are just at odds with the mac desktop where dialogs are always owned 
> windows ?

Mac OS Alert opens up in new window no matter what the Prefer Tab setting is.
>   Do they imagine that all windows can layout nicely even if they don't get 
> the size they want ?
>   I'm having trouble picturing how all this works smoothly
> * where do we have behavioural problems - full screen oddities, application 
> freezes, incorrect behaviour
>   of menu bars .. focus ..
> * what scenarios do we need to examine  ?
> 
> I can imagine it would take some time to properly go through all of these and 
> I think we should
> schedule that rather than just disabling this and in all likelihood 
> forgetting about this.
> Do we have a go-with-the disabling RFE to support it ?

I have filed a RFE for this : https://bugs.openjdk.java.net/browse/JDK-8266026.

-

PR: https://git.openjdk.java.net/jdk/pull/3407

Integrated: 8197811 : Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows

[Tejpal Rebari]

On Mon, 19 Apr 2021 09:49:40 GMT, Tejpal Rebari  wrote:

> The test PopupPosTest.java fails for windows every time, and was problem 
> listed.
> This test was added under the JDK-5044150,  And the change was specific to  
> XToolkit as mentioned in JDK-5044150.
> "this change is for XToolkit thus testing it on Linux will be sufficient"/
> 
> This test runs fine in linux(i have tested on ubuntu).
> So making this test linux specific.

This pull request has now been integrated.

Changeset: d1c8c9ea
Author:Tejpal Rebari 
URL:   https://git.openjdk.java.net/jdk/commit/d1c8c9ea
Stats: 9 lines in 2 files changed: 0 ins; 8 del; 1 mod

8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows

Reviewed-by: psadhukhan

-

PR: https://git.openjdk.java.net/jdk/pull/3567

RFR: 8197811 : Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows

[Tejpal Rebari]

The test PopupPosTest.java fails for windows every time, and was problem listed.
This test was added under the JDK-5044150,  And the change was specific to  
XToolkit as mentioned in JDK-5044150.
"this change is for XToolkit thus testing it on Linux will be sufficient"/

This test runs fine in linux(i have tested on ubuntu).
So making this test linux specific.

-

Commit messages:
 - initial changes

Changes: https://git.openjdk.java.net/jdk/pull/3567/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3567=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8197811
  Stats: 9 lines in 2 files changed: 0 ins; 8 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3567.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3567/head:pull/3567

PR: https://git.openjdk.java.net/jdk/pull/3567

Re: RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

[Tejpal Rebari]

On Fri, 9 Apr 2021 07:01:26 GMT, Sergey Bylokhov  wrote:

> > Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
> > staring from 10.12.
> > The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default 
> > value changed in macos11.
> 
> But why the option setAllowsAutomaticWindowTabbing=yes does not work? Why the 
> nswindow in JDK is so specific?

As per my understanding we don't have support for opening window in a new 
Tab.And also it is always not a good idea to open in new Tab as the dialog size 
could be different. Similar fix is done for 
JavaFX(https://git.openjdk.java.net/jfx/pull/440) and for other 
application(like SPSS) it is advised to set System Preference  -> General -> 
Prefer tabs  to  never.

-

PR: https://git.openjdk.java.net/jdk/pull/3407

RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application

[Tejpal Rebari]

Hi All,
Please review the following fix for jdk17.

Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full 
Screen  when the System Preference -> General -> Prefer Tabs is set to "Full 
Screen". It is also freezing in normal screen when Prefer Tabs is set to 
"Always".
It doesn't freeze when the Prefer tabs is set to "never".

Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS prior 
to bigSur(11)  
(in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 and 
10.15.
>From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
This issue can also be reproduced in MacOS 10.15 by setting 
setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.

Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release 
staring from 10.12.
The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default value 
changed in macos11.

Test : Added a manual test and tested on MacOS 10.15 and 11.
All the internal tests run are green.

-

Commit messages:
 - initial fix and test

Changes: https://git.openjdk.java.net/jdk/pull/3407/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3407=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8256465
  Stats: 138 lines in 2 files changed: 138 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

Re: RFR: 8264344: Outdated links in JavaComponentAccessibility.m

[Tejpal Rebari]

On Mon, 29 Mar 2021 08:31:48 GMT, Alexander Zuev  wrote:

> 8264344: Outdated links in JavaComponentAccessibility.m

Marked as reviewed by trebari (Committer).

-

PR: https://git.openjdk.java.net/jdk/pull/3240

Re: RFR: 8259439: Apply java.io.Serial annotations in java.datatransfer

[Tejpal Rebari]

On Fri, 8 Jan 2021 04:51:50 GMT, Sergey Bylokhov  wrote:

> Please review the application of `@java.io.Serial` annotation (JDK-8202385) 
> to types in the datatransfer module to enable stricter compile-time checking 
> of serialization-related declarations. 
> 
> This annotation can be applied to these methods in the module:
>   * private void writeObject(java.io.ObjectOutputStream stream) throws 
> IOException
>   * private void readObject(java.io.ObjectInputStream stream) throws 
> IOException, ClassNotFoundException
>   * private void readObjectNoData() throws ObjectStreamException 
>* ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException
>* ANY-ACCESS-MODIFIER Object readResolve() throws ObjectStreamException
>* private static final ObjectStreamField[] serialPersistentFields
>* private static final long serialVersionUID
> 
> But only the `serialVersionUID` is updated since only this field is used in 
> the datatransfer module.
> 
> A similar fix was implemented for java.base module as well:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-August/062046.html

Marked as reviewed by trebari (Committer).

-

PR: https://git.openjdk.java.net/jdk/pull/1996

Re: RFR: 8255043: Incorrectly styled copyright text

[Tejpal Rebari]

On Tue, 20 Oct 2020 08:17:27 GMT, Sergey Bylokhov  wrote:

> In some files, the copyright text is styled as a JavaDoc comment.
> Most of the affected files are tests, only one product file is affected:
> src/java.sql/share/classes/javax/sql/package-info.java
> 
> The chenge is trivial:
>  - /**
>  + /*
> * Copyright (c)

Marked as reviewed by trebari (Committer).

-

PR: https://git.openjdk.java.net/jdk/pull/759

Re: Fwd: RFR: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual

[Tejpal Rebari]

Hi prasanta, 

> On 22-May-2020, at 4:10 PM, Prasanta Sadhukhan 
>  wrote:
> 
> If Alt+F4 is not working, then why dont we try with Alt+F+X which does close 
> the notepad app.
> 
I meant that  alt + f4 is woking fine in my local windows machine ,
 but it lefts the Notepad window open in nightly testing as reported in JBS.

I also tried running the original test in nightly testing and it was passing 
as commented in the JBS. 

There is one more problem, the test fails if the default share on disk c$ is 
disabled or different disk is used,
Which I think can be changed only manually.



> Regards
> Prasanta
> On 22-May-20 3:36 PM, Tejpal Rebari wrote:
>> 
>> 
>>> Begin forwarded message:
>>> 
>>> From: Tejpal Rebari >> <mailto:tejpal.reb...@oracle.com>>
>>> Subject:  RFR: 8239827: The test OpenByUNCPathNameTest.java 
>>> should be changed to be manual
>>> Date: 22 May 2020 at 3:32:45 PM IST
>>> To: swing-...@openjdk.java.net <mailto:swing-...@openjdk.java.net>
>>> 
>>> Hi All,
>>> Please review the following test only fix for jdk15.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8239827 
>>> <https://bugs.openjdk.java.net/browse/JDK-8239827>
>>> Webrev : http://cr.openjdk.java.net/~trebari/swing/8239827/webrev00/ 
>>> <http://cr.openjdk.java.net/~trebari/swing/8239827/webrev00/>
>>> 
>>> This test regularly left open Notepad window in the nightly testing.
>>> So it was added to problem list.
>>> 
>>> The test opens file by local path name and UNC path name in windows and 
>>> then try to close the file using alt + f4, which is not working.
>>> So changed the test to manual test and removed from problem list.
>>> 
>>> Tested on Windows Platform.
>>> 
>>> 
>>> Thanks and Regards
>>> Tejpal
>> 

Regards
Tejpal

Fwd: RFR: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual

[Tejpal Rebari]

> Begin forwarded message:
> 
> From: Tejpal Rebari 
> Subject:  RFR: 8239827: The test OpenByUNCPathNameTest.java should 
> be changed to be manual
> Date: 22 May 2020 at 3:32:45 PM IST
> To: swing-...@openjdk.java.net
> 
> Hi All,
> Please review the following test only fix for jdk15.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8239827 
> <https://bugs.openjdk.java.net/browse/JDK-8239827>
> Webrev : http://cr.openjdk.java.net/~trebari/swing/8239827/webrev00/ 
> <http://cr.openjdk.java.net/~trebari/swing/8239827/webrev00/>
> 
> This test regularly left open Notepad window in the nightly testing.
> So it was added to problem list.
> 
> The test opens file by local path name and UNC path name in windows and 
> then try to close the file using alt + f4, which is not working.
> So changed the test to manual test and removed from problem list.
> 
> Tested on Windows Platform.
> 
> 
> Thanks and Regards
> Tejpal

Re: [15] Review Request: 8237222 [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails

[Tejpal Rebari]

Looks good to me.

Regards,
Tejpal

> On 24-Jan-2020, at 3:05 PM, Sergey Bylokhov  
> wrote:
> 
> Hello.
> Please review the fix for JDK 15.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8237222
> Fix: http://cr.openjdk.java.net/~serb/8237222/webrev.00
> 
> To fix the bug in the test a few specific for macOS
> keystrokes were added. The test is moved to the open repo.
> 
> -- 
> Best regards, Sergey.

[14] RFR JDK-8234802 - [TESTBUG] Test Right Mouse Button Drag Gesture Recognition in all the platforms

[Tejpal Rebari]

Hi All,
Please review a test fix for jdk-14.

Bug  : https://bugs.openjdk.java.net/browse/JDK-8234802 

Webrev : http://cr.openjdk.java.net/~trebari/swing/8234802/webrev0/ 


This is a new test to check for right mouse button drag gesture recognition in 
all the platform.

The drag gesture is recognised only in Windows and Mac. So the test would pass 
in Mac and windows if the drag gesture is recognised.
Similarly it would fail in other platforms if the drag gesture is recognised.

Testing : Tested in Mac, Windows and Ubuntu. Mach5 [our internal build and test 
system] link is in JBS.


Regards
Tejpal