Re: [10] Review request for 8178448: MenuBar item handler fired twice
Looks fine. On 02.08.2017 23:28, Alexander Zvegintsev wrote: Hi Sergey, http://cr.openjdk.java.net/~azvegint/jdk/10/8178448/01/ I've updated the test. The JFrame needs to be iconified because it is stealing the keyboard focus, so accelerators for menu items will not be triggered. Thanks, Alexander. On 02/08/2017 21:12, Sergey Bylokhov wrote: Hi, Alex. Is it possible to create a test for this issue? It will be similar to ActionListenerCalledTwiceTest On 01.08.2017 22:34, Alexander Zvegintsev wrote: Hi all, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8178448/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8178448 This Mac specific issue happens if setDefaultMenuBar() is called after setJMenuBar() with same instance of JMenuBar. JFrame.setJMenuBar(mb); Desktop.getDesktop().setDefaultMenuBar(mb); -- Thanks, Alexander. -- Best regards, Sergey.
Re: [10] Review request for 8178448: MenuBar item handler fired twice
Hi Sergey, http://cr.openjdk.java.net/~azvegint/jdk/10/8178448/01/ I've updated the test. The JFrame needs to be iconified because it is stealing the keyboard focus, so accelerators for menu items will not be triggered. Thanks, Alexander. On 02/08/2017 21:12, Sergey Bylokhov wrote: Hi, Alex. Is it possible to create a test for this issue? It will be similar to ActionListenerCalledTwiceTest On 01.08.2017 22:34, Alexander Zvegintsev wrote: Hi all, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8178448/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8178448 This Mac specific issue happens if setDefaultMenuBar() is called after setJMenuBar() with same instance of JMenuBar. JFrame.setJMenuBar(mb); Desktop.getDesktop().setDefaultMenuBar(mb); -- Thanks, Alexander.
Re: [10] Review request for 8178448: MenuBar item handler fired twice
Hi, Alex. Is it possible to create a test for this issue? It will be similar to ActionListenerCalledTwiceTest On 01.08.2017 22:34, Alexander Zvegintsev wrote: Hi all, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8178448/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8178448 This Mac specific issue happens if setDefaultMenuBar() is called after setJMenuBar() with same instance of JMenuBar. JFrame.setJMenuBar(mb); Desktop.getDesktop().setDefaultMenuBar(mb); -- Thanks, Alexander. -- Best regards, Sergey.
[10] Review request for 8178448: MenuBar item handler fired twice
Hi all, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8178448/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8178448 This Mac specific issue happens if setDefaultMenuBar() is called after setJMenuBar() with same instance of JMenuBar. JFrame.setJMenuBar(mb); Desktop.getDesktop().setDefaultMenuBar(mb); -- Thanks, Alexander.
