Re: [14] Review Request: 8236545 Compilation error in mach5 java/awt/FileDialog/MacOSGoToFolderCrash.java

[Dmitry Markov]

Looks good to me.

Thanks,
Dmitry

> On 30 Dec 2019, at 23:07, Sergey Bylokhov  wrote:
> 
> Hello.
> Please review the fix for JDK 14.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8236545
> Fix: http://cr.openjdk.java.net/~serb/8236545/webrev.00
> 
> This test may fail due to compilation error "unmappable character" for 
> encoding US-ASCII.
> 
> I could not reproduce it locally but our mach5 systems are affected, so I
> would like to fix it in jdk 14. The fix is trivial and affects the text in
> the comment.
> 
> -- 
> Best regards, Sergey.

[14] Review Request: 8236545 Compilation error in mach5 java/awt/FileDialog/MacOSGoToFolderCrash.java

[Sergey Bylokhov]

Hello.
Please review the fix for JDK 14.

Bug: https://bugs.openjdk.java.net/browse/JDK-8236545
Fix: http://cr.openjdk.java.net/~serb/8236545/webrev.00

This test may fail due to compilation error "unmappable character" for encoding 
US-ASCII.

I could not reproduce it locally but our mach5 systems are affected, so I
would like to fix it in jdk 14. The fix is trivial and affects the text in
the comment.

--
Best regards, Sergey.