Re: [9] Review request for 8166897: Some font overlap in the Optionpane dialog.

2016-10-17 Thread Alexander Zvegintsev

+1

Thanks,
Alexander.

On 10/13/16 12:12 AM, Semyon Sadetsky wrote:

Hello,

Please review fix for JDK9:

bug: https://bugs.openjdk.java.net/browse/JDK-8166897

webrev: http://cr.openjdk.java.net/~ssadetsky/8166897/webrev.00/

The setResizable() method of XDecoratedPeer class clears the frame 
insets to allow them to receive the updated size. In some situations 
clearing insets during establishing the frame dimensions may break the 
new frame dimensions algorithm for Unity and the frame content 
positioning becomes wrong.


Since in this new algorithm the insets may be arbitrary updated by WM 
it doesn't necessary to clear insets to get them the new size. The 
proposed solution is to avoid to force frame insets to zero when the 
frame is made resizable or non-resizable by user.


--Semyon





[9] Review request for 8166897: Some font overlap in the Optionpane dialog.

2016-10-12 Thread Semyon Sadetsky

Hello,

Please review fix for JDK9:

bug: https://bugs.openjdk.java.net/browse/JDK-8166897

webrev: http://cr.openjdk.java.net/~ssadetsky/8166897/webrev.00/

The setResizable() method of XDecoratedPeer class clears the frame 
insets to allow them to receive the updated size. In some situations 
clearing insets during establishing the frame dimensions may break the 
new frame dimensions algorithm for Unity and the frame content 
positioning becomes wrong.


Since in this new algorithm the insets may be arbitrary updated by WM it 
doesn't necessary to clear insets to get them the new size.  The 
proposed solution is to avoid to force frame insets to zero when the 
frame is made resizable or non-resizable by user.


--Semyon