Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v4]
On Fri, 23 Jul 2021 12:56:32 GMT, Alexander Zvegintsev wrote: >> This test can fail pretty consistently on some slow systems. Increased delay >> fixes the issue. >> We do have similar fix in #260 > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last revision: > > finally dispose Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v4]
On Fri, 23 Jul 2021 12:56:32 GMT, Alexander Zvegintsev wrote: >> This test can fail pretty consistently on some slow systems. Increased delay >> fixes the issue. >> We do have similar fix in #260 > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last revision: > > finally dispose CI job run is green. - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v4]
> This test can fail pretty consistently on some slow systems. Increased delay > fixes the issue. > We do have similar fix in #260 Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision: finally dispose - Changes: - all: https://git.openjdk.java.net/jdk17/pull/272/files - new: https://git.openjdk.java.net/jdk17/pull/272/files/cbe6f219..df2a2aa3 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17=272=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=272=02-03 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/272/head:pull/272 PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v3]
On Fri, 23 Jul 2021 11:53:48 GMT, Prasanta Sadhukhan wrote: > Looks good. BTW, normally in swing we also do dispose of the frame after test > is over in finally block...Not sure in awt Frame...It may not be required if > you are running standalone but in a group of CI run, it might prove > effective.. looks like jtreg handles this, but this might be helpful specially for standalone run. - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v3]
On Fri, 23 Jul 2021 11:33:35 GMT, Alexander Zvegintsev wrote: >> This test can fail pretty consistently on some slow systems. Increased delay >> fixes the issue. >> We do have similar fix in #260 > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last revision: > > increased delay Looks good. BTW, normally in swing we also do dispose of the frame after test is over in finally block...Not sure in awt Frame...It may not be required if you are running standalone but in a group of CI run, it might prove effective.. - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v3]
> This test can fail pretty consistently on some slow systems. Increased delay > fixes the issue. > We do have similar fix in #260 Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision: increased delay - Changes: - all: https://git.openjdk.java.net/jdk17/pull/272/files - new: https://git.openjdk.java.net/jdk17/pull/272/files/10ca677e..cbe6f219 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17=272=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=272=01-02 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/272/head:pull/272 PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v2]
On Thu, 22 Jul 2021 22:41:49 GMT, Sergey Bylokhov wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> year bump > > test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java > line 82: > >> 80: >> 81: Util.waitForIdle(robot); >> 82: robot.delay(200); > > I remember some similar issues, so I 'grep" our tests. Looks like usually a > bigger delay is used, like 500 or even 1 second. Normally we use delay of 1 sec after frame.setvisible and 500ms after events. Can you also please rectify the wildcard imports? Did you try to give CI job running this test for several iterations in all platforms, if yes, can you post it in JBS? - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v2]
On Thu, 22 Jul 2021 20:49:36 GMT, Alexander Zvegintsev wrote: >> This test can fail pretty consistently on some slow systems. Increased delay >> fixes the issue. >> We do have similar fix in #260 > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last revision: > > year bump test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java line 82: > 80: > 81: Util.waitForIdle(robot); > 82: robot.delay(200); I remember some similar issues, so I 'grep" our tests. Looks like usually a bigger delay is used, like 500 or even 1 second. - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v2]
On Thu, 22 Jul 2021 20:49:36 GMT, Alexander Zvegintsev wrote: >> This test can fail pretty consistently on some slow systems. Increased delay >> fixes the issue. >> We do have similar fix in #260 > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last revision: > > year bump Marked as reviewed by kizune (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu
On Thu, 22 Jul 2021 20:20:48 GMT, Alexander Zuev wrote: > I am not sure if we supposed to bump up the copyright year or it is supposed > to be done with some script later, but i usually do it myself just to be sure. updated - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v2]
> This test can fail pretty consistently on some slow systems. Increased delay > fixes the issue. > We do have similar fix in #260 Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision: year bump - Changes: - all: https://git.openjdk.java.net/jdk17/pull/272/files - new: https://git.openjdk.java.net/jdk17/pull/272/files/d64dd52d..10ca677e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17=272=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=272=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/272/head:pull/272 PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu
On Thu, 22 Jul 2021 19:53:37 GMT, Alexander Zvegintsev wrote: > This test can fail pretty consistently on some slow systems. Increased delay > fixes the issue. > We do have similar fix in #260 I am not sure if we supposed to bump up the copyright year or it is supposed to be done with some script later, but i usually do it myself just to be sure. - PR: https://git.openjdk.java.net/jdk17/pull/272
[jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu
This test can fail pretty consistently on some slow systems. Increased delay fixes the issue. We do have similar fix in #260 - Commit messages: - initial Changes: https://git.openjdk.java.net/jdk17/pull/272/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=272=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8015886 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk17/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/272/head:pull/272 PR: https://git.openjdk.java.net/jdk17/pull/272
