Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v2]
On Thu, 22 Jul 2021 22:41:49 GMT, Sergey Bylokhov wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> year bump > > test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java > line 82: > >> 80: >> 81: Util.waitForIdle(robot); >> 82: robot.delay(200); > > I remember some similar issues, so I 'grep" our tests. Looks like usually a > bigger delay is used, like 500 or even 1 second. Normally we use delay of 1 sec after frame.setvisible and 500ms after events. Can you also please rectify the wildcard imports? Did you try to give CI job running this test for several iterations in all platforms, if yes, can you post it in JBS? - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v2]
On Thu, 22 Jul 2021 20:49:36 GMT, Alexander Zvegintsev wrote: >> This test can fail pretty consistently on some slow systems. Increased delay >> fixes the issue. >> We do have similar fix in #260 > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last revision: > > year bump test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java line 82: > 80: > 81: Util.waitForIdle(robot); > 82: robot.delay(200); I remember some similar issues, so I 'grep" our tests. Looks like usually a bigger delay is used, like 500 or even 1 second. - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v2]
On Thu, 22 Jul 2021 20:49:36 GMT, Alexander Zvegintsev wrote: >> This test can fail pretty consistently on some slow systems. Increased delay >> fixes the issue. >> We do have similar fix in #260 > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last revision: > > year bump Marked as reviewed by kizune (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v2]
> This test can fail pretty consistently on some slow systems. Increased delay > fixes the issue. > We do have similar fix in #260 Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision: year bump - Changes: - all: https://git.openjdk.java.net/jdk17/pull/272/files - new: https://git.openjdk.java.net/jdk17/pull/272/files/d64dd52d..10ca677e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17=272=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=272=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk17/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/272/head:pull/272 PR: https://git.openjdk.java.net/jdk17/pull/272
