Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v3]
On Fri, 23 Jul 2021 11:53:48 GMT, Prasanta Sadhukhan wrote: > Looks good. BTW, normally in swing we also do dispose of the frame after test > is over in finally block...Not sure in awt Frame...It may not be required if > you are running standalone but in a group of CI run, it might prove > effective.. looks like jtreg handles this, but this might be helpful specially for standalone run. - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v3]
On Fri, 23 Jul 2021 11:33:35 GMT, Alexander Zvegintsev wrote: >> This test can fail pretty consistently on some slow systems. Increased delay >> fixes the issue. >> We do have similar fix in #260 > > Alexander Zvegintsev has updated the pull request incrementally with one > additional commit since the last revision: > > increased delay Looks good. BTW, normally in swing we also do dispose of the frame after test is over in finally block...Not sure in awt Frame...It may not be required if you are running standalone but in a group of CI run, it might prove effective.. - PR: https://git.openjdk.java.net/jdk17/pull/272
Re: [jdk17] RFR: 8015886: java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java sometimes failed on ubuntu [v3]
> This test can fail pretty consistently on some slow systems. Increased delay > fixes the issue. > We do have similar fix in #260 Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision: increased delay - Changes: - all: https://git.openjdk.java.net/jdk17/pull/272/files - new: https://git.openjdk.java.net/jdk17/pull/272/files/10ca677e..cbe6f219 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17=272=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=272=01-02 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk17/pull/272.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/272/head:pull/272 PR: https://git.openjdk.java.net/jdk17/pull/272
