Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled [v2]
On Fri, 23 Jul 2021 05:49:25 GMT, Alexander Zuev wrote: >> Fixed the version string parsing to work correctly on macOS 11.x and beyond > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Demoved isBigSurOrAbove variable that was never used in the code Updated fix looks good. > > ALso, please add noreg-demo to JBS since I guess SwingSet2 is used to test. > > Done. That's not what `noreg-demo` means (that label means that the change itself is limited to a demo). - Marked as reviewed by kcr (Author). PR: https://git.openjdk.java.net/jdk17/pull/269
Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled [v2]
On Fri, 23 Jul 2021 05:49:25 GMT, Alexander Zuev wrote: >> Fixed the version string parsing to work correctly on macOS 11.x and beyond > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Demoved isBigSurOrAbove variable that was never used in the code Marked as reviewed by psadhukhan (Reviewer). - PR: https://git.openjdk.java.net/jdk17/pull/269
Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled [v2]
On Fri, 23 Jul 2021 04:16:10 GMT, Prasanta Sadhukhan wrote: > This is not required..Need to be removed. Done. - PR: https://git.openjdk.java.net/jdk17/pull/269
Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled [v2]
> Fixed the version string parsing to work correctly on macOS 11.x and beyond Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Demoved isBigSurOrAbove variable that was never used in the code - Changes: - all: https://git.openjdk.java.net/jdk17/pull/269/files - new: https://git.openjdk.java.net/jdk17/pull/269/files/538305f9..3543c209 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17&pr=269&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17&pr=269&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk17/pull/269.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/269/head:pull/269 PR: https://git.openjdk.java.net/jdk17/pull/269
Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled
On Fri, 23 Jul 2021 04:18:42 GMT, Prasanta Sadhukhan wrote: > Since existing currentMacOSXVersionMatchesGivenVersionRange() is changed, did > you test in osx 10.15 or below to see current functionality is ok? I have tested the public methods of this class with simulated version strings for previous macOS releases - they return correct assumptions about them. I haven't tested the code that acquires the version string but i haven't changed that. > ALso, please add noreg-demo to JBS since I guess SwingSet2 is used to test. Done. - PR: https://git.openjdk.java.net/jdk17/pull/269
Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled
On Thu, 22 Jul 2021 16:25:40 GMT, Alexander Zuev wrote: > Fixed the version string parsing to work correctly on macOS 11.x and beyond Since existing currentMacOSXVersionMatchesGivenVersionRange() is changed, did you test in osx 10.15 or below to see current functionality is ok? ALso, please add noreg-demo to JBS since I guess SwingSet2 is used to test. src/java.desktop/macosx/classes/apple/laf/JRSUIUtils.java line 39: > 37: static boolean isLeopard = isMacOSXLeopard(); > 38: static boolean isSnowLeopardOrBelow = isMacOSXSnowLeopardOrBelow(); > 39: static boolean isBigSurOrAbove = isMacOSXBigSurOrAbove(); This is not required..Need to be removed. - PR: https://git.openjdk.java.net/jdk17/pull/269
Re: [jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled
On Thu, 22 Jul 2021 16:25:40 GMT, Alexander Zuev wrote: > Fixed the version string parsing to work correctly on macOS 11.x and beyond Looks good. I also tested it on macOS 11.5 and verified that the test case fails (is rendered incorrectly) without your fix and passes with your fix. @prsadhuk Can you review this? - Marked as reviewed by kcr (Author). PR: https://git.openjdk.java.net/jdk17/pull/269
[jdk17] RFR: 8269984: [macos] JTabbedPane title looks like disabled
Fixed the version string parsing to work correctly on macOS 11.x and beyond - Commit messages: - 8269984: [macos] JTabbedPane title looks like disabled Changes: https://git.openjdk.java.net/jdk17/pull/269/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=269&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269984 Stats: 26 lines in 1 file changed: 17 ins; 2 del; 7 mod Patch: https://git.openjdk.java.net/jdk17/pull/269.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/269/head:pull/269 PR: https://git.openjdk.java.net/jdk17/pull/269
