Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails
Thank you Krishna and Sergey for the review. -Original Message- From: Sergey Bylokhov Sent: Thursday, November 15, 2018 3:13 AM To: Shashidhara Veerabhadraiah ; Krishna Addepalli ; swing-...@openjdk.java.net; awt-dev@openjdk.java.net Subject: Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails Looks fine. -- Best regards, Sergey.
Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails
Looks fine. -- Best regards, Sergey.
Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails
Hi Sergey, Here is the updated Webrev. http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.04/ Thanks and regards, Shashi -Original Message- From: Sergey Bylokhov Sent: Wednesday, November 7, 2018 2:54 AM To: Shashidhara Veerabhadraiah ; Krishna Addepalli ; swing-...@openjdk.java.net; awt-dev@openjdk.java.net Subject: Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails Hi, Shashi. A few notes: - I just found that you replaced the Applet by the JFrame. The fist is a AWT component which could be used on any threads, the second is Swing component. So in the test you just mix the AWT and Swing, I suggest to use "Frame" instead. In this case "invokeAndWait" will not be necessary. - You can add finally block to the "try" in the "main" method, and dispose the frame there, instead of disposing it before every "throw". - This new line seems unnecessary: 63 robot.delay(10); On 04/11/2018 22:39, shashidhara.veerabhadra...@oracle.com wrote: > Hi All, Here is the new webrev with fixes for the comments: > > http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.03/ > > Thanks and regards, > Shashi > > > On 31/10/18 11:19 PM, Sergey Bylokhov wrote: >> Also robot.setAutoDelay() can be used instead of a list of .delay() >> >> +I suggest to add robot.waitForIdle after the createAndShowGUI, >> because it can be slow operation on the slow systems. >> >> On 31/10/2018 04:59, Krishna Addepalli wrote: >>> Hi Shashi, >>> >>> 1. Please add "@key headful" to the test. >>> 2. I don’t think you need to replace the waitForIdle call with delay. You >>> may choose to add delay in addition to waitForIdle. >>> 3. Minor nit: replace () -> createAndShowGUI() with method reference. >>> >>> Thanks, >>> Krishna >>> >>> -Original Message- >>> From: Shashidhara Veerabhadraiah >>> Sent: Wednesday, October 31, 2018 3:34 PM >>> To: swing-...@openjdk.java.net; awt-dev@openjdk.java.net >>> Subject: [12] JDK-6849922: >>> java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails >>> >>> Hi All, Please review test fix for the below bug. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-6849922 >>> >>> Webrev: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.02/ >>> >>> Fix: As the initial bug analysis said in the bug comments, it is a timing >>> issue where in the choice menu remains opened even though the escape key is >>> pressed. After removing the applet dependency and using the swing utilities >>> to order the GUI creation and sending the key events with a delay is fixing >>> the problem. >>> >>> This test was successfully run on Windows 10, Mac 10.13 and Ubuntu 16.04. >>> >>> Thanks and regards, >>> >>> Shashi >>> >> >> > -- Best regards, Sergey.
Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails
Hi, Shashi. A few notes: - I just found that you replaced the Applet by the JFrame. The fist is a AWT component which could be used on any threads, the second is Swing component. So in the test you just mix the AWT and Swing, I suggest to use "Frame" instead. In this case "invokeAndWait" will not be necessary. - You can add finally block to the "try" in the "main" method, and dispose the frame there, instead of disposing it before every "throw". - This new line seems unnecessary: 63 robot.delay(10); On 04/11/2018 22:39, shashidhara.veerabhadra...@oracle.com wrote: Hi All, Here is the new webrev with fixes for the comments: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.03/ Thanks and regards, Shashi On 31/10/18 11:19 PM, Sergey Bylokhov wrote: Also robot.setAutoDelay() can be used instead of a list of .delay() +I suggest to add robot.waitForIdle after the createAndShowGUI, because it can be slow operation on the slow systems. On 31/10/2018 04:59, Krishna Addepalli wrote: Hi Shashi, 1. Please add "@key headful" to the test. 2. I don’t think you need to replace the waitForIdle call with delay. You may choose to add delay in addition to waitForIdle. 3. Minor nit: replace () -> createAndShowGUI() with method reference. Thanks, Krishna -Original Message- From: Shashidhara Veerabhadraiah Sent: Wednesday, October 31, 2018 3:34 PM To: swing-...@openjdk.java.net; awt-dev@openjdk.java.net Subject: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails Hi All, Please review test fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-6849922 Webrev: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.02/ Fix: As the initial bug analysis said in the bug comments, it is a timing issue where in the choice menu remains opened even though the escape key is pressed. After removing the applet dependency and using the swing utilities to order the GUI creation and sending the key events with a delay is fixing the problem. This test was successfully run on Windows 10, Mac 10.13 and Ubuntu 16.04. Thanks and regards, Shashi -- Best regards, Sergey.
Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails
Hi All, Here is the new webrev with fixes for the comments: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.03/ Thanks and regards, Shashi On 31/10/18 11:19 PM, Sergey Bylokhov wrote: Also robot.setAutoDelay() can be used instead of a list of .delay() +I suggest to add robot.waitForIdle after the createAndShowGUI, because it can be slow operation on the slow systems. On 31/10/2018 04:59, Krishna Addepalli wrote: Hi Shashi, 1. Please add "@key headful" to the test. 2. I don’t think you need to replace the waitForIdle call with delay. You may choose to add delay in addition to waitForIdle. 3. Minor nit: replace () -> createAndShowGUI() with method reference. Thanks, Krishna -Original Message- From: Shashidhara Veerabhadraiah Sent: Wednesday, October 31, 2018 3:34 PM To: swing-...@openjdk.java.net; awt-dev@openjdk.java.net Subject: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails Hi All, Please review test fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-6849922 Webrev: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.02/ Fix: As the initial bug analysis said in the bug comments, it is a timing issue where in the choice menu remains opened even though the escape key is pressed. After removing the applet dependency and using the swing utilities to order the GUI creation and sending the key events with a delay is fixing the problem. This test was successfully run on Windows 10, Mac 10.13 and Ubuntu 16.04. Thanks and regards, Shashi
Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails
Also robot.setAutoDelay() can be used instead of a list of .delay() +I suggest to add robot.waitForIdle after the createAndShowGUI, because it can be slow operation on the slow systems. On 31/10/2018 04:59, Krishna Addepalli wrote: Hi Shashi, 1. Please add "@key headful" to the test. 2. I don’t think you need to replace the waitForIdle call with delay. You may choose to add delay in addition to waitForIdle. 3. Minor nit: replace () -> createAndShowGUI() with method reference. Thanks, Krishna -Original Message- From: Shashidhara Veerabhadraiah Sent: Wednesday, October 31, 2018 3:34 PM To: swing-...@openjdk.java.net; awt-dev@openjdk.java.net Subject: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails Hi All, Please review test fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-6849922 Webrev: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.02/ Fix: As the initial bug analysis said in the bug comments, it is a timing issue where in the choice menu remains opened even though the escape key is pressed. After removing the applet dependency and using the swing utilities to order the GUI creation and sending the key events with a delay is fixing the problem. This test was successfully run on Windows 10, Mac 10.13 and Ubuntu 16.04. Thanks and regards, Shashi -- Best regards, Sergey.
Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails
Hi Shashi, 1. Please add "@key headful" to the test. 2. I don’t think you need to replace the waitForIdle call with delay. You may choose to add delay in addition to waitForIdle. 3. Minor nit: replace () -> createAndShowGUI() with method reference. Thanks, Krishna -Original Message- From: Shashidhara Veerabhadraiah Sent: Wednesday, October 31, 2018 3:34 PM To: swing-...@openjdk.java.net; awt-dev@openjdk.java.net Subject: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails Hi All, Please review test fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-6849922 Webrev: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.02/ Fix: As the initial bug analysis said in the bug comments, it is a timing issue where in the choice menu remains opened even though the escape key is pressed. After removing the applet dependency and using the swing utilities to order the GUI creation and sending the key events with a delay is fixing the problem. This test was successfully run on Windows 10, Mac 10.13 and Ubuntu 16.04. Thanks and regards, Shashi
[12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails
Hi All, Please review test fix for the below bug. Bug: https://bugs.openjdk.java.net/browse/JDK-6849922 Webrev: http://cr.openjdk.java.net/~sveerabhadra/6849922/webrev.02/ Fix: As the initial bug analysis said in the bug comments, it is a timing issue where in the choice menu remains opened even though the escape key is pressed. After removing the applet dependency and using the swing utilities to order the GUI creation and sending the key events with a delay is fixing the problem. This test was successfully run on Windows 10, Mac 10.13 and Ubuntu 16.04. Thanks and regards, Shashi
