Re: RFR: 8197821: Test java/awt/font/TextLayout/LigatureCaretTest.java fails on Windows

2021-04-28 Thread Sergey Bylokhov
On Wed, 28 Apr 2021 12:46:56 GMT, Prasanta Sadhukhan  
wrote:

> 2 tests java/awt/font/TextLayout/LigatureCaretTest.java and 
> java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java used to 
> fail on windows in CI testing citing "wrong text location" and " right hit 
> failed within layout " which is due to some layout  issue. 
> We have made harfbuzz upgrades after that and these tests are not failing 
> neither locally nor in CI testing.
> 
> Several iterations of these tests in all platforms are working fine, so we 
> can remove from problemlist.

Marked as reviewed by serb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3760


Re: RFR: 8197821: Test java/awt/font/TextLayout/LigatureCaretTest.java fails on Windows

2021-04-28 Thread Alexander Zvegintsev
On Wed, 28 Apr 2021 12:46:56 GMT, Prasanta Sadhukhan  
wrote:

> 2 tests java/awt/font/TextLayout/LigatureCaretTest.java and 
> java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java used to 
> fail on windows in CI testing citing "wrong text location" and " right hit 
> failed within layout " which is due to some layout  issue. 
> We have made harfbuzz upgrades after that and these tests are not failing 
> neither locally nor in CI testing.
> 
> Several iterations of these tests in all platforms are working fine, so we 
> can remove from problemlist.

Marked as reviewed by azvegint (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3760


RFR: 8197821: Test java/awt/font/TextLayout/LigatureCaretTest.java fails on Windows

2021-04-28 Thread Prasanta Sadhukhan
2 tests java/awt/font/TextLayout/LigatureCaretTest.java and 
java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java used to 
fail on windows in CI testing citing "wrong text location" and " right hit 
failed within layout " which is due to some layout  issue. 
We have made harfbuzz upgrades after that and these tests are not failing 
neither locally nor in CI testing.

Several iterations of these tests in all platforms are working fine, so we can 
remove from problemlist.

-

Commit messages:
 - 8197821: Test java/awt/font/TextLayout/LigatureCaretTest.java fails on 
Windows

Changes: https://git.openjdk.java.net/jdk/pull/3760/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=3760=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8197821
  Stats: 2 lines in 1 file changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3760.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3760/head:pull/3760

PR: https://git.openjdk.java.net/jdk/pull/3760