Re: RFR: 8210866: Remove HPKeysym.h from JDK sources
The changes look good to me. Thanks, Dmitry > On 18 Sep 2018, at 22:49, Phil Race wrote: > > Thanks, > > However I also need to remove the now obsolete > comment which explained why we had our own copy .. > http://cr.openjdk.java.net/~prr/8210866.1 > > -phil. > > On 09/18/2018 01:14 PM, Sergey Bylokhov wrote: >> Looks fine. >> >> On 18/09/2018 12:50, Phil Race wrote: >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210880 >>> Webrev : http://cr.openjdk.java.net/~prr/8210866/ >>> >>> As described in the bug, we can rely on the build platform for this file, >>> as we do for most X11 include files. Builds pass on our core platforms. >>> Since this is an X11 protocol file, I expect very few people will find they >>> are missing this and have to install it .. >>> >>> -phil. >> >> >
Re: RFR: 8210866: Remove HPKeysym.h from JDK sources
+1 On 18/09/2018 14:49, Phil Race wrote: Thanks, However I also need to remove the now obsolete comment which explained why we had our own copy .. http://cr.openjdk.java.net/~prr/8210866.1 -phil. On 09/18/2018 01:14 PM, Sergey Bylokhov wrote: Looks fine. On 18/09/2018 12:50, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8210880 Webrev : http://cr.openjdk.java.net/~prr/8210866/ As described in the bug, we can rely on the build platform for this file, as we do for most X11 include files. Builds pass on our core platforms. Since this is an X11 protocol file, I expect very few people will find they are missing this and have to install it .. -phil. -- Best regards, Sergey.
Re: RFR: 8210866: Remove HPKeysym.h from JDK sources
Thanks, However I also need to remove the now obsolete comment which explained why we had our own copy .. http://cr.openjdk.java.net/~prr/8210866.1 -phil. On 09/18/2018 01:14 PM, Sergey Bylokhov wrote: Looks fine. On 18/09/2018 12:50, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8210880 Webrev : http://cr.openjdk.java.net/~prr/8210866/ As described in the bug, we can rely on the build platform for this file, as we do for most X11 include files. Builds pass on our core platforms. Since this is an X11 protocol file, I expect very few people will find they are missing this and have to install it .. -phil.
Re: RFR: 8210866: Remove HPKeysym.h from JDK sources
Looks fine. On 18/09/2018 12:50, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8210880 Webrev : http://cr.openjdk.java.net/~prr/8210866/ As described in the bug, we can rely on the build platform for this file, as we do for most X11 include files. Builds pass on our core platforms. Since this is an X11 protocol file, I expect very few people will find they are missing this and have to install it .. -phil. -- Best regards, Sergey.
RFR: 8210866: Remove HPKeysym.h from JDK sources
Bug: https://bugs.openjdk.java.net/browse/JDK-8210880 Webrev : http://cr.openjdk.java.net/~prr/8210866/ As described in the bug, we can rely on the build platform for this file, as we do for most X11 include files. Builds pass on our core platforms. Since this is an X11 protocol file, I expect very few people will find they are missing this and have to install it .. -phil.
