Re: RFR: 8233567: [TESTBUG] FocusSubRequestTest.java fails on macos

2021-04-12 Thread Pankaj Bansal
On Mon, 12 Apr 2021 04:37:31 GMT, Prasanta Sadhukhan  
wrote:

> This test was problemlisted during nightly testing of jdk on macos which 
> seems to be caused by the fact that proper waiting was not done to make sure 
> frame is visible before commencing the test, which can be problematic in some 
> of the slower CI macos system.
> Modified the wait-till-frame-is-visible code to make it more in sync with 
> what other similar test use.
> Several iterations of the test works fine in all platforms after this 
> modification.

Marked as reviewed by pbansal (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3430


Re: RFR: 8233567: [TESTBUG] FocusSubRequestTest.java fails on macos

2021-04-12 Thread Alexander Zvegintsev
On Mon, 12 Apr 2021 04:37:31 GMT, Prasanta Sadhukhan  
wrote:

> This test was problemlisted during nightly testing of jdk on macos which 
> seems to be caused by the fact that proper waiting was not done to make sure 
> frame is visible before commencing the test, which can be problematic in some 
> of the slower CI macos system.
> Modified the wait-till-frame-is-visible code to make it more in sync with 
> what other similar test use.
> Several iterations of the test works fine in all platforms after this 
> modification.

Marked as reviewed by azvegint (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3430


RFR: 8233567: [TESTBUG] FocusSubRequestTest.java fails on macos

2021-04-11 Thread Prasanta Sadhukhan
This test was problemlisted during nightly testing of jdk on macos which seems 
to be caused by the fact that proper waiting was not done to make sure frame is 
visible before commencing the test, which can be problematic in some of the 
slower CI macos system.
Modified the wait-till-frame-is-visible code to make it more in sync with what 
other similar test use.
Several iterations of the test works fine in all platforms after this 
modification.

-

Commit messages:
 - 8233567: [TESTBUG] FocusSubRequestTest.java fails on macos

Changes: https://git.openjdk.java.net/jdk/pull/3430/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3430&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8233567
  Stats: 13 lines in 2 files changed: 3 ins; 2 del; 8 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3430.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3430/head:pull/3430

PR: https://git.openjdk.java.net/jdk/pull/3430