Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS) [v2]
On Wed, 26 May 2021 17:51:55 GMT, Alexander Zvegintsev wrote: >> This fix is to explicitly specify that `Taskbar::getIconImage` may return an >> object different from passed to `Taskbar::setIconImage`. >> >> Actually it is always returns a different object on macOS(the only OS which >> supports this feature), but I want to save some options if we decide to >> rework this. > > Alexander Zvegintsev has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - update > - Merge branch 'openjdk:master' into Taskbar_getIconImageSpec_8264125 > - initial @mrserb @dbessono please review - PR: https://git.openjdk.java.net/jdk/pull/3250
Re: RFR: 8264125: Specification of Taskbar::getIconImage doesn't mention that the returned image might not be equal to the Taskbar::setIconImage one. (eg on Mac OS) [v2]
> This fix is to explicitly specify that `Taskbar::getIconImage` may return an > object different from passed to `Taskbar::setIconImage`. > > Actually it is always returns a different object on macOS(the only OS which > supports this feature), but I want to save some options if we decide to > rework this. Alexander Zvegintsev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - update - Merge branch 'openjdk:master' into Taskbar_getIconImageSpec_8264125 - initial - Changes: - all: https://git.openjdk.java.net/jdk/pull/3250/files - new: https://git.openjdk.java.net/jdk/pull/3250/files/74bccd43..a265fc99 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=3250=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3250=00-01 Stats: 695093 lines in 8625 files changed: 120831 ins; 548167 del; 26095 mod Patch: https://git.openjdk.java.net/jdk/pull/3250.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3250/head:pull/3250 PR: https://git.openjdk.java.net/jdk/pull/3250
