Re: RFR: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer
On Mon, 17 May 2021 08:22:59 GMT, Alexander Zuev wrote: > Initial implementation. Looks fine to me. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/GroupAccessibility.m line 27: > 25: > 26: #import "GroupAccessibility.h" > 27: #import "JNIUtilities.h" The header JNIUtilities.h is not used, please remove it before integrating. - Marked as reviewed by pbansal (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4046
Re: RFR: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer
On Tue, 18 May 2021 13:25:04 GMT, Pankaj Bansal wrote: > Could you please give some details about how you have tested this? I used the SwingSet2 first demo - internal frame - and made sure that components that were previously reported as groups - internal frame, button group and such - are correctly reported as groups and there are no regressions with navigating their children using the accessibility shortcut keys. Also with debug output i made sure that new code is used to gather list of the children inside the group components. Additionally i tested it with few existing AWT tests and made sure that there are no regression there too. - PR: https://git.openjdk.java.net/jdk/pull/4046
Re: RFR: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer
On Mon, 17 May 2021 08:22:59 GMT, Alexander Zuev wrote: > Initial implementation. Could you please give some details about how you have tested this? - PR: https://git.openjdk.java.net/jdk/pull/4046
RFR: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer
Initial implementation. - Commit messages: - 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer Changes: https://git.openjdk.java.net/jdk/pull/4046/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4046&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264290 Stats: 63 lines in 3 files changed: 60 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/4046.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4046/head:pull/4046 PR: https://git.openjdk.java.net/jdk/pull/4046
