Re: RFR: JDK-8255681: print callstack in error case in runAWTLoopWithApp

2020-11-03 Thread Sergey Bylokhov
On Tue, 3 Nov 2020 08:45:20 GMT, Matthias Baesken  wrote:

> Currently in case of occurences of an NSException in runAWTLoopWithApp we 
> catch the exception just print a simple error message like this :
> 
> 2020-10-30 15:28:33.027 java[634:8435] Apple AWT Startup Exception: Cannot 
> lock focus on image , 
> because it is size zero.
> 2020-10-30 15:28:33.306 java[634:8435] Apple AWT Restarting Native Event 
> Thread
> 
> But we omit the callstack and loose valuable information. This change  adds 
> the callstack to the output.

Marked as reviewed by serb (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/1032


Re: RFR: JDK-8255681: print callstack in error case in runAWTLoopWithApp

2020-11-03 Thread Christoph Langer
On Tue, 3 Nov 2020 08:45:20 GMT, Matthias Baesken  wrote:

> Currently in case of occurences of an NSException in runAWTLoopWithApp we 
> catch the exception just print a simple error message like this :
> 
> 2020-10-30 15:28:33.027 java[634:8435] Apple AWT Startup Exception: Cannot 
> lock focus on image , 
> because it is size zero.
> 2020-10-30 15:28:33.306 java[634:8435] Apple AWT Restarting Native Event 
> Thread
> 
> But we omit the callstack and loose valuable information. This change  adds 
> the callstack to the output.

To me this looks like a good idea. In our current customer case this 
information would have greatly helped analysis. However, I'd like to see an 
opinion from one of the experts in that area on whether that's appropriate here.

-

Marked as reviewed by clanger (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1032


RFR: JDK-8255681: print callstack in error case in runAWTLoopWithApp

2020-11-03 Thread Matthias Baesken
Currently in case of occurences of an NSException in runAWTLoopWithApp we catch 
the exception just print a simple error message like this :

2020-10-30 15:28:33.027 java[634:8435] Apple AWT Startup Exception: Cannot lock 
focus on image , because 
it is size zero.
2020-10-30 15:28:33.306 java[634:8435] Apple AWT Restarting Native Event Thread

But we omit the callstack and loose valuable information. This change  adds the 
callstack to the output.

-

Commit messages:
 - JDK-8255681

Changes: https://git.openjdk.java.net/jdk/pull/1032/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1032=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8255681
  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1032.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1032/head:pull/1032

PR: https://git.openjdk.java.net/jdk/pull/1032