[jira] Commented: (AXIS2-3108) Broken WSDL for operations added by modules

2007-08-09 Thread Thomas Leonard (JIRA)

[ 
https://issues.apache.org/jira/browse/AXIS2-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518679
 ] 

Thomas Leonard commented on AXIS2-3108:
---

There are two bugs causing this:

* ModuleBuilder.processOperations() doesn't set the message names, unlike 
ServiceBuilder.processOperations().

* AxisService.copyOperation() doesn't copy the message names.

By the way, there seems to be massive duplication of code here. 
ModuleBuilder.processOperations() was clearly copy-and-pasted from 
ServiceBuilder.processOperations(), but now they've diverged, each with its own 
bugs.

Likewise, AxisService.copyOperation() seems to be cut-and-pasted from 
AxisOperation.copyOperation(), which also contains the same bug.

> Broken WSDL for operations added by modules
> ---
>
> Key: AXIS2-3108
> URL: https://issues.apache.org/jira/browse/AXIS2-3108
> Project: Axis 2.0 (Axis2)
>  Issue Type: Bug
>  Components: kernel
>Affects Versions: 1.2
>Reporter: Thomas Leonard
> Fix For: 1.3
>
>
> Using Axis2 1.3-RC2, we get WSDL that looks like this:
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; message="ns0:null" 
> wsaw:Action="urn:getServiceProviderID"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; message="ns0:null" 
> wsaw:Action="urn:getServiceProviderIDResponse"/>
> 
> 
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:sayHelloRequest" wsaw:Action="urn:sayHello"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:sayHelloResponse" wsaw:Action="urn:sayHelloResponse"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:XMLStreamException" name="XMLStreamException" 
> wsaw:Action="urn:sayHelloXMLStreamException"/>
> 
> 
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:pingRequest" wsaw:Action="urn:ping"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:pingResponse" wsaw:Action="urn:pingResponse"/>
> 
> 
> This is for the user guide's sample service, with a module adding the 
> "getServiceProviderID" operation. Note that the messages have no name, even 
> though the operation does:
> 
> ...
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; message="ns0:null" 
> wsaw:Action="urn:getServiceProviderID"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; message="ns0:null" 
> wsaw:Action="urn:getServiceProviderIDResponse"/>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (AXIS2-3108) Broken WSDL for operations added by modules

2008-07-07 Thread Deepal Jayasinghe (JIRA)

[ 
https://issues.apache.org/jira/browse/AXIS2-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611042#action_12611042
 ] 

Deepal Jayasinghe commented on AXIS2-3108:
--

Could you please grant the patch license to Apache , then only I can look at 
that.

Thank you!
Deepal

> Broken WSDL for operations added by modules
> ---
>
> Key: AXIS2-3108
> URL: https://issues.apache.org/jira/browse/AXIS2-3108
> Project: Axis 2.0 (Axis2)
>  Issue Type: Bug
>  Components: kernel
>Affects Versions: 1.2
>Reporter: Thomas Leonard
> Attachments: module-ops.patch
>
>
> Using Axis2 1.3-RC2, we get WSDL that looks like this:
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; message="ns0:null" 
> wsaw:Action="urn:getServiceProviderID"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; message="ns0:null" 
> wsaw:Action="urn:getServiceProviderIDResponse"/>
> 
> 
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:sayHelloRequest" wsaw:Action="urn:sayHello"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:sayHelloResponse" wsaw:Action="urn:sayHelloResponse"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:XMLStreamException" name="XMLStreamException" 
> wsaw:Action="urn:sayHelloXMLStreamException"/>
> 
> 
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:pingRequest" wsaw:Action="urn:ping"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:pingResponse" wsaw:Action="urn:pingResponse"/>
> 
> 
> This is for the user guide's sample service, with a module adding the 
> "getServiceProviderID" operation. Note that the messages have no name, even 
> though the operation does:
> 
> ...
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; message="ns0:null" 
> wsaw:Action="urn:getServiceProviderID"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; message="ns0:null" 
> wsaw:Action="urn:getServiceProviderIDResponse"/>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Commented: (AXIS2-3108) Broken WSDL for operations added by modules

2008-07-07 Thread Thomas Leonard (JIRA)

[ 
https://issues.apache.org/jira/browse/AXIS2-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611127#action_12611127
 ] 

Thomas Leonard commented on AXIS2-3108:
---

I can't see how to do that in JIRA. You're welcome to it, though.

> Broken WSDL for operations added by modules
> ---
>
> Key: AXIS2-3108
> URL: https://issues.apache.org/jira/browse/AXIS2-3108
> Project: Axis 2.0 (Axis2)
>  Issue Type: Bug
>  Components: kernel
>Affects Versions: 1.2
>Reporter: Thomas Leonard
> Attachments: module-ops.patch
>
>
> Using Axis2 1.3-RC2, we get WSDL that looks like this:
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; message="ns0:null" 
> wsaw:Action="urn:getServiceProviderID"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; message="ns0:null" 
> wsaw:Action="urn:getServiceProviderIDResponse"/>
> 
> 
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:sayHelloRequest" wsaw:Action="urn:sayHello"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:sayHelloResponse" wsaw:Action="urn:sayHelloResponse"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:XMLStreamException" name="XMLStreamException" 
> wsaw:Action="urn:sayHelloXMLStreamException"/>
> 
> 
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:pingRequest" wsaw:Action="urn:ping"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; 
> message="ns0:pingResponse" wsaw:Action="urn:pingResponse"/>
> 
> 
> This is for the user guide's sample service, with a module adding the 
> "getServiceProviderID" operation. Note that the messages have no name, even 
> though the operation does:
> 
> ...
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; message="ns0:null" 
> wsaw:Action="urn:getServiceProviderID"/>
>  xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl"; message="ns0:null" 
> wsaw:Action="urn:getServiceProviderIDResponse"/>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]