Re: [Ayatana] Unity's desktop
Joern, that looks really interesting! signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Maverick Movies!
Well of course we have to get the brand correct and all but we should support any efforts to promote Ubuntu. --fagan On Fri, Aug 20, 2010 at 3:17 PM, Christian Giordano christian.giord...@canonical.com wrote: Shouldn't we promote our style guides? Sure they probably don't include video editing/transitions etc, but the typography of some of those videos is just too inconsistent. chr On Fri, Aug 20, 2010 at 11:01 AM, Mark Shuttleworth m...@ubuntu.comwrote: Hi folks I saw this amazing movie from the Ubuntu Ads guys http://www.youtube.com/watch?v=dHzP7mxRFJE and was inspired to blog http://www.markshuttleworth.com/archives/489 about https://wiki.ubuntu.com/MaverickMovieshttps://wiki.ubuntu.com/MaverickMovies#preview Shout if you are interested in helping host the process or participating. Mark ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Maverick Movies!
Well I think it would be fun to put some of the high quality ones on the front page of ubuntu.com using HTM5 video embedding. --fagan On Fri, Aug 20, 2010 at 5:50 PM, Christian Giordano christian.giord...@canonical.com wrote: Sure, it just would be nice to see them linked somewhere :) Cheers, chr On Fri, Aug 20, 2010 at 5:31 PM, Shane Fagan shanepatrickfa...@ubuntu.com wrote: Well of course we have to get the brand correct and all but we should support any efforts to promote Ubuntu. --fagan On Fri, Aug 20, 2010 at 3:17 PM, Christian Giordano christian.giord...@canonical.com wrote: Shouldn't we promote our style guides? Sure they probably don't include video editing/transitions etc, but the typography of some of those videos is just too inconsistent. chr On Fri, Aug 20, 2010 at 11:01 AM, Mark Shuttleworth m...@ubuntu.comwrote: Hi folks I saw this amazing movie from the Ubuntu Ads guys http://www.youtube.com/watch?v=dHzP7mxRFJE and was inspired to blog http://www.markshuttleworth.com/archives/489 about https://wiki.ubuntu.com/MaverickMovieshttps://wiki.ubuntu.com/MaverickMovies#preview Shout if you are interested in helping host the process or participating. Mark ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Maverick Movies!
This is an interesting question that I'd like some perspective on (as a bit of an outsider to Canonical, but part of the FLOSS community): where does Canonical a/o Ubuntu's responsibility to maintain the Ubuntu brand end? As a marketer in a rather traditional market, I'm conditioned to think that I need to preserve my brand wherever possible, to make sure everything looks consistent in every medium. At the same time, it's foolish, and I think, counter to FLOSS ideology, to clamp down on this sort of 'fan art', to categorize it broadly. So how does a company deeply devoted to open source ideology interact with fan art? I don't know if the Ayatana list is the right place for this discussion, but I'm curious about Canonical/Ubuntu's philosphy for walking that line, navigating that challenge in an innovative, open source way. Thanks! Jake On Fri, Aug 20, 2010 at 11:31 AM, Shane Fagan shanepatrickfa...@ubuntu.comwrote: Well of course we have to get the brand correct and all but we should support any efforts to promote Ubuntu. --fagan On Fri, Aug 20, 2010 at 3:17 PM, Christian Giordano christian.giord...@canonical.com wrote: Shouldn't we promote our style guides? Sure they probably don't include video editing/transitions etc, but the typography of some of those videos is just too inconsistent. chr On Fri, Aug 20, 2010 at 11:01 AM, Mark Shuttleworth m...@ubuntu.comwrote: Hi folks I saw this amazing movie from the Ubuntu Ads guys http://www.youtube.com/watch?v=dHzP7mxRFJE and was inspired to blog http://www.markshuttleworth.com/archives/489 about https://wiki.ubuntu.com/MaverickMovieshttps://wiki.ubuntu.com/MaverickMovies#preview Shout if you are interested in helping host the process or participating. Mark ___ Mailing list: https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana More help : https://help.launchpad.net/ListHelp -- Peaces, Jake ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Maverick Movies!
From what I remember only Ubuntu members and Canonical can use the logo for whatever they like like business cards, t-shirts, blogs..etc. The brand guidelines are on the design team's blog http://design.canonical.com/the-toolkit/ We wouldnt clamp down on fan art or community videos that use the logo but if you miss use it we can get you to take it down. So the idea is that as long as your not miss using it alls good with using the brand from what I remember. --fagan On Fri, Aug 20, 2010 at 6:54 PM, Jake Tolbert crazybi...@gmail.com wrote: This is an interesting question that I'd like some perspective on (as a bit of an outsider to Canonical, but part of the FLOSS community): where does Canonical a/o Ubuntu's responsibility to maintain the Ubuntu brand end? As a marketer in a rather traditional market, I'm conditioned to think that I need to preserve my brand wherever possible, to make sure everything looks consistent in every medium. At the same time, it's foolish, and I think, counter to FLOSS ideology, to clamp down on this sort of 'fan art', to categorize it broadly. So how does a company deeply devoted to open source ideology interact with fan art? I don't know if the Ayatana list is the right place for this discussion, but I'm curious about Canonical/Ubuntu's philosphy for walking that line, navigating that challenge in an innovative, open source way. Thanks! Jake On Fri, Aug 20, 2010 at 11:31 AM, Shane Fagan shanepatrickfa...@ubuntu.com wrote: Well of course we have to get the brand correct and all but we should support any efforts to promote Ubuntu. --fagan On Fri, Aug 20, 2010 at 3:17 PM, Christian Giordano christian.giord...@canonical.com wrote: Shouldn't we promote our style guides? Sure they probably don't include video editing/transitions etc, but the typography of some of those videos is just too inconsistent. chr On Fri, Aug 20, 2010 at 11:01 AM, Mark Shuttleworth m...@ubuntu.comwrote: Hi folks I saw this amazing movie from the Ubuntu Ads guys http://www.youtube.com/watch?v=dHzP7mxRFJE and was inspired to blog http://www.markshuttleworth.com/archives/489 about https://wiki.ubuntu.com/MaverickMovieshttps://wiki.ubuntu.com/MaverickMovies#preview Shout if you are interested in helping host the process or participating. Mark ___ Mailing list: https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana More help : https://help.launchpad.net/ListHelp -- Peaces, Jake ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Maverick Movies!
Encode them in WebM so that way the average person can't watch them until Natty is released... Seriously though, maybe put it on Ubuntu.com, but I think the point of advertising as a whole is to get the brand out there to people that don't know what Ubuntu is. A viewer watching it on ubuntu.com shows that they already are somewhat familiar with it. Ideally this would show on television, but that's prohibitively expensive. I do work in radio (and specifically the station's websites) advertising, so there's another venue if interested. Date: Fri, 20 Aug 2010 17:55:42 +0100 From: shanepatrickfa...@ubuntu.com To: christian.giord...@canonical.com CC: ubuntu-market...@lists.ubuntu.com; ayatana@lists.launchpad.net; m...@ubuntu.com Subject: Re: [Ayatana] Maverick Movies! Well I think it would be fun to put some of the high quality ones on the front page of ubuntu.com using HTM5 video embedding. --fagan On Fri, Aug 20, 2010 at 5:50 PM, Christian Giordano christian.giord...@canonical.com wrote: Sure, it just would be nice to see them linked somewhere :) Cheers, chr On Fri, Aug 20, 2010 at 5:31 PM, Shane Fagan shanepatrickfa...@ubuntu.com wrote: Well of course we have to get the brand correct and all but we should support any efforts to promote Ubuntu. --fagan On Fri, Aug 20, 2010 at 3:17 PM, Christian Giordano christian.giord...@canonical.com wrote: Shouldn't we promote our style guides? Sure they probably don't include video editing/transitions etc, but the typography of some of those videos is just too inconsistent. chr On Fri, Aug 20, 2010 at 11:01 AM, Mark Shuttleworth m...@ubuntu.com wrote: Hi folks I saw this amazing movie from the Ubuntu Ads guys http://www.youtube.com/watch?v=dHzP7mxRFJE and was inspired to blog http://www.markshuttleworth.com/archives/489 about https://wiki.ubuntu.com/MaverickMovies Shout if you are interested in helping host the process or participating. Mark ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Maverick Movies!
I was hoping to make a few nice videos of Ubuntu 9.10 (similar to what you're describing) only to find that the output videos of gtkRecordMyDesktop don't work correctly with PiTiVi or Openshot. It seems there may be a problem with libtheora in Lucid: https://bugs.launchpad.net/ubuntu/+source/recordmydesktop/+bug/578397 and https://bugzilla.redhat.com/show_bug.cgi?id=525155. Does anyone know if these bugs are fixed in Maverick and/or are there easy-to-use alternative gui-based screencast recorders somewhere that I don't know about? I would love to help create great videos of Ubuntu, but I wonder if the above video was created on Ubuntu using available apps. If not, it should be a goal to get Ubuntu to that place with apps that are readily available, work as they're supposed to, and are easy to use. Jonathan PS: Mark, your comments form isn't working correctly. It's asking me to download your wp-comments-post.php file... On Fri, Aug 20, 2010 at 5:01 AM, Mark Shuttleworth m...@ubuntu.com wrote: Hi folks I saw this amazing movie from the Ubuntu Ads guys http://www.youtube.com/watch?v=dHzP7mxRFJE and was inspired to blog http://www.markshuttleworth.com/archives/489 about https://wiki.ubuntu.com/MaverickMovies Shout if you are interested in helping host the process or participating. Mark ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Maverick Movies!
Well I was trying to make up a few but pitivi doesnt do transitions or other effects so I couldnt make anything nice --fagan On Fri, Aug 20, 2010 at 7:55 PM, Jonathan Blackhall johnny.one@gmail.com wrote: I was hoping to make a few nice videos of Ubuntu 9.10 (similar to what you're describing) only to find that the output videos of gtkRecordMyDesktop don't work correctly with PiTiVi or Openshot. It seems there may be a problem with libtheora in Lucid: https://bugs.launchpad.net/ubuntu/+source/recordmydesktop/+bug/578397 and https://bugzilla.redhat.com/show_bug.cgi?id=525155. Does anyone know if these bugs are fixed in Maverick and/or are there easy-to-use alternative gui-based screencast recorders somewhere that I don't know about? I would love to help create great videos of Ubuntu, but I wonder if the above video was created on Ubuntu using available apps. If not, it should be a goal to get Ubuntu to that place with apps that are readily available, work as they're supposed to, and are easy to use. Jonathan PS: Mark, your comments form isn't working correctly. It's asking me to download your wp-comments-post.php file... On Fri, Aug 20, 2010 at 5:01 AM, Mark Shuttleworth m...@ubuntu.com wrote: Hi folks I saw this amazing movie from the Ubuntu Ads guys http://www.youtube.com/watch?v=dHzP7mxRFJE and was inspired to blog http://www.markshuttleworth.com/archives/489 about https://wiki.ubuntu.com/MaverickMovies Shout if you are interested in helping host the process or participating. Mark ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
[Ayatana] Highlighting recently installed software in the menu
Hey all, I had an idea after I installed something and that was I just installed this program but where did it go? Then I looked for the program and found it in the menu so I was thinking we can make it easier by highlighting the menu entry of the recently installed programs. Also I thought it would be an ok idea to offer to open the program after its installed. Thoughts? --fagan ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Highlighting recently installed software in the menu
I believe the offering to open a program after install -used- to be a feature. A possible (?) issue with that, that I see, would be when installing libraries or the likes. For those it certainly wouldn't make sense to offer to open. In other words, how are you going to determine whether what you just installed is meant to be run at all? As for your first idea, I remember XP having that feature too and often being wrong/keeping it highlighted well after install. Was rather annoying! Something to keep in mind :o Ward Muylaert ward.muyla...@gmail.com 3de Bachelor Wiskunde - Minor Computer Wetenschappen Vrije Universiteit Brussel On 20 August 2010 22:14, Shane Fagan shanepatrickfa...@ubuntu.com wrote: Hey all, I had an idea after I installed something and that was I just installed this program but where did it go? Then I looked for the program and found it in the menu so I was thinking we can make it easier by highlighting the menu entry of the recently installed programs. Also I thought it would be an ok idea to offer to open the program after its installed. Thoughts? --fagan ___ Mailing list: https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatanahttps://launchpad.net/%7Eayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/dbusmenu/bigger-max-xml into lp:dbusmenu
Ted Gould has proposed merging lp:~ted/dbusmenu/bigger-max-xml into lp:dbusmenu. Requested reviews: Neil J. Patel (njpatel) Increase the max number of characters the XML string can be. GIMP is crazy. -- https://code.launchpad.net/~ted/dbusmenu/bigger-max-xml/+merge/33219 Your team ayatana-commits is subscribed to branch lp:dbusmenu. === modified file 'libdbusmenu-glib/client.c' --- libdbusmenu-glib/client.c 2010-08-16 15:59:53 + +++ libdbusmenu-glib/client.c 2010-08-20 14:27:43 + @@ -1225,7 +1225,8 @@ xmlDocPtr xmldoc; - xmldoc = xmlReadMemory(layout, g_utf8_strlen(layout, 16*1024), dbusmenu.xml, NULL, 0); + /* No one should need more characters than this! */ + xmldoc = xmlReadMemory(layout, g_utf8_strlen(layout, 1024*1024), dbusmenu.xml, NULL, 0); xmlNodePtr root = xmlDocGetRootElement(xmldoc); ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/bigger-max-xml into lp:dbusmenu
Review: Approve Wheee! -- https://code.launchpad.net/~ted/dbusmenu/bigger-max-xml/+merge/33219 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/dbusmenu/bigger-max-xml into lp:dbusmenu
The proposal to merge lp:~ted/dbusmenu/bigger-max-xml into lp:dbusmenu has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~ted/dbusmenu/bigger-max-xml/+merge/33219 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Branch ~dbusmenu-team/dbusmenu/trunk] Rev 151: Increasing the maximum size of the XML layout.
Merge authors: Ted Gould (ted) Related merge proposals: https://code.launchpad.net/~ted/dbusmenu/bigger-max-xml/+merge/33219 proposed by: Ted Gould (ted) review: Approve - Neil J. Patel (njpatel) revno: 151 [merge] committer: Ted Gould t...@gould.cx branch nick: trunk timestamp: Fri 2010-08-20 09:29:38 -0500 message: Increasing the maximum size of the XML layout. modified: libdbusmenu-glib/client.c -- lp:dbusmenu https://code.launchpad.net/~dbusmenu-team/dbusmenu/trunk Your team ayatana-commits is subscribed to branch lp:dbusmenu. To unsubscribe from this branch go to https://code.launchpad.net/~dbusmenu-team/dbusmenu/trunk/+edit-subscription === modified file 'libdbusmenu-glib/client.c' --- libdbusmenu-glib/client.c 2010-08-16 15:59:53 + +++ libdbusmenu-glib/client.c 2010-08-20 14:21:21 + @@ -1225,7 +1225,8 @@ xmlDocPtr xmldoc; - xmldoc = xmlReadMemory(layout, g_utf8_strlen(layout, 16*1024), dbusmenu.xml, NULL, 0); + /* No one should need more characters than this! */ + xmldoc = xmlReadMemory(layout, g_utf8_strlen(layout, 1024*1024), dbusmenu.xml, NULL, 0); xmlNodePtr root = xmlDocGetRootElement(xmldoc); ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-application/ordering-for-keyboard-stuff into lp:indicator-application
Ted Gould has proposed merging lp:~ted/indicator-application/ordering-for-keyboard-stuff into lp:indicator-application. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Adding the keyboard stuff to the overrides. -- https://code.launchpad.net/~ted/indicator-application/ordering-for-keyboard-stuff/+merge/33226 Your team ayatana-commits is subscribed to branch lp:indicator-application. === modified file 'data/ordering-override.keyfile' --- data/ordering-override.keyfile 2010-08-11 14:06:41 + +++ data/ordering-override.keyfile 2010-08-20 15:16:02 + @@ -1,2 +1,5 @@ [Ordering Index Overrides] gnome-power-manager=1 +gst-keyboard-xkb=2 +gsd-keyboard-xkb=3 +ibus=4 ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-application/icon-label-updates-wrong into lp:indicator-application
Ted Gould has proposed merging lp:~ted/indicator-application/icon-label-updates-wrong into lp:indicator-application. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Not using the get_position everywhere, so things were getting out of position. -- https://code.launchpad.net/~ted/indicator-application/icon-label-updates-wrong/+merge/33237 Your team ayatana-commits is subscribed to branch lp:indicator-application. === modified file 'src/application-service-appstore.c' --- src/application-service-appstore.c 2010-08-19 14:57:49 + +++ src/application-service-appstore.c 2010-08-20 16:57:42 + @@ -621,7 +621,7 @@ g_signal_emit(G_OBJECT(app-appstore), signals[APPLICATION_ADDED], 0, newicon, - g_list_index(priv-applications, app), /* Position */ + get_position(app), /* Position */ app-dbus_name, app-menu, app-icon_theme_path, ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/dbusmenu/show-menu-on-activate into lp:dbusmenu
Ted Gould has proposed merging lp:~ted/dbusmenu/show-menu-on-activate into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Opening menus when requested. Originally I thought we'd be able to use
activate, but that created a nice little signal loop -- oops. Added a new
signal to the menu item and bubble that up.
--
https://code.launchpad.net/~ted/dbusmenu/show-menu-on-activate/+merge/33268
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
=== modified file '.bzrignore'
--- .bzrignore 2010-06-28 23:33:43 +
+++ .bzrignore 2010-08-20 22:08:49 +
@@ -188,3 +188,6 @@
tests/test-json-server
tests/test-json-client
tests/test-json
+libdbusmenu-glib/client-marshal.c
+libdbusmenu-glib/client-marshal.h
+libdbusmenu-glib/libdbusmenu_glib_la-client-marshal.lo
=== modified file 'libdbusmenu-glib/Makefile.am'
--- libdbusmenu-glib/Makefile.am 2010-05-21 18:37:36 +
+++ libdbusmenu-glib/Makefile.am 2010-08-20 22:08:49 +
@@ -4,6 +4,7 @@
EXTRA_DIST = \
dbusmenu-glib.pc.in \
dbus-menu.xml \
+ client-marshal.list \
menuitem-marshal.list \
server-marshal.list
@@ -32,6 +33,8 @@
server.c \
server-marshal.h \
server-marshal.c \
+ client-marshal.h \
+ client-marshal.c \
client-menuitem.h \
client-menuitem.c \
client.h \
@@ -54,6 +57,8 @@
BUILT_SOURCES = \
dbusmenu-client.h \
dbusmenu-server.h \
+ client-marshal.h \
+ client-marshal.c \
menuitem-marshal.h \
menuitem-marshal.c \
server-marshal.h \
@@ -73,6 +78,16 @@
--output=dbusmenu-client.h \
$(srcdir)/dbus-menu.xml
+client-marshal.h: $(srcdir)/client-marshal.list
+ glib-genmarshal --header \
+ --prefix=_dbusmenu_client_marshal $(srcdir)/client-marshal.list \
+ client-marshal.h
+
+client-marshal.c: $(srcdir)/client-marshal.list
+ glib-genmarshal --body \
+ --prefix=_dbusmenu_client_marshal $(srcdir)/client-marshal.list \
+ client-marshal.c
+
server-marshal.h: $(srcdir)/server-marshal.list
glib-genmarshal --header \
--prefix=_dbusmenu_server_marshal $(srcdir)/server-marshal.list \
=== added file 'libdbusmenu-glib/client-marshal.list'
--- libdbusmenu-glib/client-marshal.list 1970-01-01 00:00:00 +
+++ libdbusmenu-glib/client-marshal.list 2010-08-20 22:08:49 +
@@ -0,0 +1,1 @@
+VOID: OBJECT, UINT
=== modified file 'libdbusmenu-glib/client.c'
--- libdbusmenu-glib/client.c 2010-08-20 14:21:21 +
+++ libdbusmenu-glib/client.c 2010-08-20 22:08:49 +
@@ -41,6 +41,7 @@
#include client-menuitem.h
#include dbusmenu-client.h
#include server-marshal.h
+#include client-marshal.h
/* Properties */
enum {
@@ -54,6 +55,7 @@
LAYOUT_UPDATED,
ROOT_CHANGED,
NEW_MENUITEM,
+ ITEM_ACTIVATE,
LAST_SIGNAL
};
@@ -123,6 +125,7 @@
static void menuitem_get_properties_cb (DBusGProxy * proxy, GHashTable * properties, GError * error, gpointer data);
static void get_properties_globber (DbusmenuClient * client, gint id, const gchar ** properties, org_ayatana_dbusmenu_get_properties_reply callback, gpointer user_data);
static GQuark error_domain (void);
+static void item_activated (DBusGProxy * proxy, gint id, guint timestamp, DbusmenuClient * client);
/* Build a type */
G_DEFINE_TYPE (DbusmenuClient, dbusmenu_client, G_TYPE_OBJECT);
@@ -187,6 +190,22 @@
NULL, NULL,
g_cclosure_marshal_VOID__OBJECT,
G_TYPE_NONE, 1, G_TYPE_OBJECT);
+ /**
+ DbusmenuClient::item-activate:
+ @arg0: The #DbusmenuClient object
+ @arg1: The #DbusmenuMenuitem activated
+ @arg2: A timestamp that the event happened at
+
+ Signaled when the server wants to activate an item in
+ order to display the menu.
+ */
+ signals[ITEM_ACTIVATE] = g_signal_new(DBUSMENU_CLIENT_SIGNAL_ITEM_ACTIVATE,
+ G_TYPE_FROM_CLASS (klass),
+ G_SIGNAL_RUN_LAST,
+ G_STRUCT_OFFSET (DbusmenuClientClass, item_activate),
+ NULL, NULL,
+ _dbusmenu_client_marshal_VOID__OBJECT_UINT,
+ G_TYPE_NONE, 2, G_TYPE_OBJECT, G_TYPE_UINT);
g_object_class_install_property (object_class, PROP_DBUSOBJECT,
g_param_spec_string(DBUSMENU_CLIENT_PROP_DBUS_OBJECT, DBus Object we represent,
@@ -582,6 +601,28 @@
return;
}
+/* Called when a server item wants to activate the menu */
+static void
+item_activated (DBusGProxy * proxy, gint id, guint timestamp, DbusmenuClient * client)
+{
+ DbusmenuClientPrivate * priv = DBUSMENU_CLIENT_GET_PRIVATE(client);
+
+ if (priv-root == NULL) {
+ g_warning(Asked to activate item %d when we don't have a menu structure., id);
+ return;
+ }
+
+ DbusmenuMenuitem * menuitem = dbusmenu_menuitem_find_id(priv-root, id);
+ if (menuitem == NULL) {
+ g_warning(Unable to find menu item %d to activate., id);
+ return;
+
