Re: [Ayatana] OMG!Ubuntu a bane or a boon? [was]Re: The new default wallpaper
Thanks Vish for reminding folks of the importance of respect when providing feedback. As Ubuntu grows, it's necessary for calm heads to constantly remind newer folks of the core values of the project, otherwise we'll lose the gravity that holds our galaxy together, so to speak. The Code of Conduct is important, so when you see people stepping out of it, please everyone help them cool down and we'll all be more effective as a community as a result of your taking the trouble to do so. That said, I think the feedback on the wallpaper is representative of real concerns about it. Otto, the lead visual designer for our desktop work in the Canonical design team, blogged about where he wants to go with it at http://design.canonical.com/2010/09/ubuntu-default-wallpaper/ where he also invites folks who are keen to help pursue the underlying idea. As a result of the feedback (even though some of it was, ahem, undiplomatic ;-)) we'll revamp the wallpaper (and yes, it's a failure on our part to have to do that post-UIF). To summarise the idea: we want to make the desktop have a unique style, but be personal to every different PC. In essence, the wallpaper for the Lucid-12.04 series is a symphony of light and light-related effects, and we want to make it so every day, each of those lights and effects moves just a little bit for each user, in a different direction. So, at release time, all the wallpapers look the same, but over the course of a month or so they all end up being different. For each release, we'd vary the elements a little, i.e. the number and relative strength of lights / flares / blurs. We didn't get to implement that this cycle. I thought we could do it with a Python-GIMP script that ran nightly. We need to use something like Gegl for high-quality effects. Alas, we then dropped the GIMP from the CD, so we'll need to figure a plan B :-) Mark signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Restart Required
On 03/09/10 05:12, David Hamm wrote: It may have taken years to make the first Elvis Sandwich, but no one can deny its tastiness.* * * * If however we are trying to achieve an orgasm then, well, you guys are on your own. And back to the topic, please ;) signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] OMG!Ubuntu a bane or a boon? [was]Re: The new default wallpaper
On 09/02/2010 11:42 PM, Mark Shuttleworth wrote: That said, I think the feedback on the wallpaper is representative of real concerns about it. Otto, the lead visual designer for our desktop work in the Canonical design team, blogged about where he wants to go with it at http://design.canonical.com/2010/09/ubuntu-default-wallpaper/ where he also invites folks who are keen to help pursue the underlying idea. As a result of the feedback (even though some of it was, ahem, undiplomatic ;-)) we'll revamp the wallpaper (and yes, it's a failure on our part to have to do that post-UIF). I was very happy to read Otto's post and thought this was a very intriguing idea. I would love to see an evolving wallpaper and his description grasped my sense of fancy. I'm afraid the resulting wallpaper did not match my expectations from his description, though, and I'm relieved to hear that it will be revamped. Although I'm getting used to the wallpaper, first impressions always matter, and Ubuntu is in a very difficult position of being dramatically more elegant than Windows but perhaps not quite as elegant as Mac OS X, which it is now compared to. This means the stakes have never felt higher. This is also an incredible achievement, and definitely one I would not have predicted from Linux when I adopted Ubuntu 5.04 so many years ago. I'm thrilled that Canonical is boldly moving to improve design and usability. And I recognize the pressure this places upon the design team and am definitely grateful that community feedback continues to inform the finished product. The frequent updates from design.canonical.com have been a real pleasure to read, and I also appreciate the further update on the wallpaper status. Regards, Nathan -- Nathan Haines Ubuntu California Local Community Team ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] OMG!Ubuntu a bane or a boon? [was]Re: The new default wallpaper
I believe that Gnome has supported .svg wallpapers for some time. Is there any reason why you're not considering using this? A quick search returned this example. Refresh to see it change, and view the source to see how simple the code is: http://www.treebuilder.de/default.asp?file=205288.xml Here's an svg wallpaper for KDE which gets closer to what you're looking for: http://kde-look.org/content/show.php/Hydrogen?content=128829 With an experienced svg artist, it would be rather easy to create a compelling (and dynamic) scene. If Canonical were to provide the layered file of the current wallpaper, perhaps you could set it up as a challenge to attract the attention of some svg experts? I'll even have a go. Are there any technical issues I haven't considered? Performance? Compatibility? You could of course use a static .jpg as a fallback. Best, Joseph ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] SVG default wallpaper was: OMG!
On Fri, 2010-09-03 at 09:46 +0100, Joseph Hughes wrote: Are there any technical issues I haven't considered? Performance? Compatibility? You could of course use a static .jpg as a fallback. The svg specification is big... really big. Inkscape, which is used to make most SVG files, supports _some_ of the incomplete svg 1.2 specification. It's doing a fairly good job at supporting static parts but falls down at SMIL animation, css and javascript support. You then have filter effects which Inkscape does support, but not all svg renderers do. So blur effects and shadows and even in some cases semi transparencies can disappear or make the entire canvas black. So as a plan of action on this: I'd check the support of the svg renderer in gtk, recommend inkscape for making the starters and disapprove of any text as text. Martin, ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] OMG!Ubuntu a bane or a boon? [was]Re: The new default wallpaper
On Fri, 2010-09-03 at 09:46 +0100, Joseph Hughes wrote: Are there any technical issues I haven't considered? Performance? Compatibility? You could of course use a static .jpg as a fallback. Tests show gnome supports all the filter effects, blurring, semi-transparencies and gradients that Inkscape does on Lucid. I'm going to have a play with a script now. Martin, ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] SVG default wallpaper was: OMG!
Martin hit the nail on the head - the gap between what's on the CD, what works in practice, and the SVG standard, is rather wide. signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
[Ayatana] Messagin Indiactor
I just realized that the messaging indicator no longer shows arrows to depict running apps. Was this intentional? Why? -- Owais Lone he...@owaislone.org http://www.owaislone.org ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Messagin Indiactor
On Fri, 2010-09-03 at 22:00 +0530, Owais Lone wrote: I just realized that the messaging indicator no longer shows arrows to depict running apps. Was this intentional? Why? It's a bug, we're working on it. Sorry. --Ted signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] SVG default wallpaper was: OMG!
Hey Joseph, Mark and Otto, On Fri, 2010-09-03 at 15:52 +0100, Mark Shuttleworth wrote: Martin hit the nail on the head - the gap between what's on the CD, what works in practice, and the SVG standard, is rather wide. Using testing and svg and python hacking I've put together a demonstration which works on the default lucid install: http://doctormo.org/2010/09/03/random-genetic-wallpaper/ So I may have been too hasty with my initial concerns. I think so long as the svgs limits are known, it should be possible to do something even more interesting than what I have done here. Martin, ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Restart Required
Hello Scott, On Fri, Sep 3, 2010 at 05:01, Scott Kitterman ubu...@kitterman.com wrote: Frederik Nnaji frederik.nn...@gmail.com wrote: On Thu, Sep 2, 2010 at 19:58, Scott Kitterman ubu...@kitterman.com wrote: On Wednesday, September 01, 2010 07:17:55 pm Frederik Nnaji wrote: On Wed, Sep 1, 2010 at 19:16, Scott Kitterman ubu...@kitterman.com wrote: If you're using apt-get, then you aren't in the target audience Ayatana is designing for. I think the CLI is definitely part of an ordinary Ubuntu experience for about 50% of Ubuntu users.. imagine getting workarounds from forums and wiki sites into place without guiding the novice through the CLI for a few commands.. Apart from that, getting the CLI dialogs right is an essential step in the evolution of interface metaphors. The GUI is born in the CLI, if you ask me.. Right is a function of the audience. I think that CLI package management users are more likely to be annoyed by excessively nanyish warnings from their package manager than helped by them. I agree, right depends on who's lookin. on another note.. i'm feeling like there's still too much developer vs consumer here.. Traits of elitarism. The new concept is prosumer aka community-driven, everyone contributes, using is participating already. There is also little sense in classifying groups of users by the applications they use in this particular context: community is a classless system. That's only true if you don't care about losing the people that got Ubuntu to the edge of the chasm. I'm reasonably certain that's not the case. I meant no harm or disrespect to the great characters who shaped much of what we know as Free today.. My personal point of view is simply that software under the hood of Ubuntu will be unreasonable, if it splits the community into a system of classes.. I am open for other opinions: perhaps you expand on why community is not a classless system .. or did i get you wrong in all? ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
[Ayatana] Presence via Me Menu
Hi there, i've been thinking about this one for quite a while now.. We can't control our state of Presence (Me Menu) when empathy's presence is set to offline. how is this situation supposed to evolve? My own idea would be, to replace invisible with offline, since i appear as offline when i set my presence to invisible. Clicking offline in the current Me Menu quits all accounts in Empathy, with no way of going back online. Perhaps then it would make sense to replace offline (Me Menu) with quit. thoughts? ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Restart Required
On Friday, September 03, 2010 04:23:01 pm Frederik Nnaji wrote: Hello Scott, On Fri, Sep 3, 2010 at 05:01, Scott Kitterman ubu...@kitterman.com wrote: Frederik Nnaji frederik.nn...@gmail.com wrote: On Thu, Sep 2, 2010 at 19:58, Scott Kitterman ubu...@kitterman.com wrote: On Wednesday, September 01, 2010 07:17:55 pm Frederik Nnaji wrote: On Wed, Sep 1, 2010 at 19:16, Scott Kitterman ubu...@kitterman.com wrote: If you're using apt-get, then you aren't in the target audience Ayatana is designing for. I think the CLI is definitely part of an ordinary Ubuntu experience for about 50% of Ubuntu users.. imagine getting workarounds from forums and wiki sites into place without guiding the novice through the CLI for a few commands.. Apart from that, getting the CLI dialogs right is an essential step in the evolution of interface metaphors. The GUI is born in the CLI, if you ask me.. Right is a function of the audience. I think that CLI package management users are more likely to be annoyed by excessively nanyish warnings from their package manager than helped by them. I agree, right depends on who's lookin. on another note.. i'm feeling like there's still too much developer vs consumer here.. Traits of elitarism. The new concept is prosumer aka community-driven, everyone contributes, using is participating already. There is also little sense in classifying groups of users by the applications they use in this particular context: community is a classless system. That's only true if you don't care about losing the people that got Ubuntu to the edge of the chasm. I'm reasonably certain that's not the case. I meant no harm or disrespect to the great characters who shaped much of what we know as Free today.. My personal point of view is simply that software under the hood of Ubuntu will be unreasonable, if it splits the community into a system of classes.. I am open for other opinions: perhaps you expand on why community is not a classless system .. or did i get you wrong in all? Not all users have the same level of experience. That's unavoidable. In general (not always, but in general) more experienced users will be more like to use more command line tools in their regular use of the system. As a result, I think it's a safe assumption that the typical command line user knows more about the system than one would consider normal for GUI based tools. More experienced users tend to find excessive warnings about things that are generally well understood to be off-putting. Adding them as Ubuntu specific changes reinforces the notion that Ubuntu is only for beginners and not for people who know what they are doing. We don't want that. So feel free to put all the training wheels you think are needed in the GUI, but don't extend the same concepts to the command line. Scott K ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] SVG default wallpaper was: OMG!
Great work! I really like the idea of the random evolving wallpaper, and your nice hack proves that the desired effect does work in practice. One word of warning - if this feature finally gets included in Ubuntu, please make sure that the orange highlights are always kept subtle and never run out of control. In Owens' demo the generated wallpaper looks great mainly because it contains very few and faded orange splashes. On the other hand, the original wallpaper that generated so much controversy contains no less than three big, highly saturated stains. http://www.omgubuntu.co.uk/2010/08/ubuntu-1010-default-wallpaper.html The new Ubuntu color palette takes an aggressive stance by combining purple and orange. While this combination can achieve a vibrating effects in the hands of a skilled designer, it's simply too risky to use in a random generator. So please put a constraint so that the orange highlights are always restricted to low saturations. You know what would be great? Having the random wallpaper to use other palettes, as defined by the colors in the chosen interface theme, with the same highlights in the same position of the fresh install wallpaper. This would allow for even more variability of the shared screenshots (the original goal of this idea) from the first day, while keeping the branding still recognizable. On 3 September 2010 19:51, Martin Owens wrote: Hey Joseph, Mark and Otto, On Fri, 2010-09-03 at 15:52 +0100, Mark Shuttleworth wrote: Martin hit the nail on the head - the gap between what's on the CD, what works in practice, and the SVG standard, is rather wide. Using testing and svg and python hacking I've put together a demonstration which works on the default lucid install: http://doctormo.org/2010/09/03/random-genetic-wallpaper/ So I may have been too hasty with my initial concerns. I think so long as the svgs limits are known, it should be possible to do something even more interesting than what I have done here. Martin, ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Restart Required
Frederik Nnaji frederik.nn...@gmail.com wrote: On Fri, Sep 3, 2010 at 22:30, Scott Kitterman ubu...@kitterman.com wrote: Not all users have the same level of experience. That's unavoidable. that's good, diversity is an asset, not a staller. In general (not always, but in general) more experienced users will be more like to use more command line tools in their regular use of the system. As a result, I think it's a safe assumption that the typical command line user knows more about the system than one would consider normal for GUI based tools. Yep, makes sense to me.. More experienced users tend to find excessive warnings about things that are generally well understood to be off-putting.Adding them as Ubuntu specific changes reinforces the notion that Ubuntu is only for beginners and not for people who know what they are doing. We don't want that. So feel free to put all the training wheels you think are needed in the GUI, but don't extend the same concepts to the command line. I understand your position and i agree with most of it, too. While we surely share the same opinion on much of what has been discussed here, i am developing a mental model of how there can be a learnable, consistent and semantically correct symmetry between command line interface and graphical user interface.. The foundation of my unborn brainchild is that a dialog is a dialog, whether in a GUI or in the CLI.. perhaps i'm going too far with my thinking Text always appears in a context. Dialogue needs to work in the context it's presented. Part of the context is that provided by the user. Part of it is the visual context. So because the target CLI user is somewhat different than the target GUI user and because the presentation and interaction are also different it's quite reasonable we would want different text. Scott K ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-appmenu/working-close-menu-item into lp:indicator-appmenu
Ted Gould has proposed merging
lp:~ted/indicator-appmenu/working-close-menu-item into lp:indicator-appmenu
with lp:~ted/indicator-appmenu/desktop-menu-handling as a prerequisite.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Have the close menu work for windows.
--
https://code.launchpad.net/~ted/indicator-appmenu/working-close-menu-item/+merge/34554
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.
=== modified file '.bzrignore'
--- .bzrignore 2010-06-29 15:04:15 +
+++ .bzrignore 2010-09-03 16:54:43 +
@@ -17,6 +17,7 @@
src/application-menu-debug-client.h
src/application-menu-debug-server.h
tools/current-menu-dump
+src/libappmenu_la-gdk-get-func.lo
tools/mock-json-app
tools/.deps
tools/.libs
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2010-07-22 13:06:09 +
+++ src/Makefile.am 2010-09-03 16:54:43 +
@@ -14,12 +14,15 @@
libappmenu_la_SOURCES = \
application-menu-registrar-server.h \
dbus-shared.h \
+ gdk-get-func.h \
+ gdk-get-func.c \
+ MwmUtil.h \
indicator-appmenu.c \
indicator-appmenu-marshal.c \
window-menus.c \
window-menus.h
libappmenu_la_CFLAGS = $(INDICATOR_CFLAGS) -Wall -Wl,-Bsymbolic-functions -Wl,-z,defs -Wl,--as-needed -Werror
-libappmenu_la_LIBADD = $(INDICATOR_LIBS)
+libappmenu_la_LIBADD = $(INDICATOR_LIBS) -lX11
libappmenu_la_LDFLAGS = -module -avoid-version
##
=== added file 'src/MwmUtil.h'
--- src/MwmUtil.h 1970-01-01 00:00:00 +
+++ src/MwmUtil.h 2010-09-03 16:54:43 +
@@ -0,0 +1,136 @@
+/**
+ *
+ * $Id$
+ *
+ * Copyright (C) 1995 Free Software Foundation, Inc.
+ *
+ * This file is part of the GNU LessTif Library.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+ * Boston, MA 02111-1307, USA.
+ *
+ *
+ * * Feb 21 1999 - George Lebl (ji...@5z.com)
+ * Owen Taylor (otay...@redhat.com)
+ *
+ * Modified so that the MotifWmHints structure defined here
+ * is suitable for client side use on 64-bit architectures.
+ * X expects fields with a format of 32 to be longs, even
+ * when sizeof(long) == 8.
+ **/
+
+#ifndef MWMUTIL_H_INCLUDED
+#define MWMUTIL_H_INCLUDED
+
+#include X11/Xmd.h
+
+G_BEGIN_DECLS
+
+typedef struct {
+unsigned long flags;
+unsigned long functions;
+unsigned long decorations;
+long input_mode;
+unsigned long status;
+} MotifWmHints, MwmHints;
+
+#define MWM_HINTS_FUNCTIONS (1L 0)
+#define MWM_HINTS_DECORATIONS (1L 1)
+#define MWM_HINTS_INPUT_MODE(1L 2)
+#define MWM_HINTS_STATUS(1L 3)
+
+#define MWM_FUNC_ALL(1L 0)
+#define MWM_FUNC_RESIZE (1L 1)
+#define MWM_FUNC_MOVE (1L 2)
+#define MWM_FUNC_MINIMIZE (1L 3)
+#define MWM_FUNC_MAXIMIZE (1L 4)
+#define MWM_FUNC_CLOSE (1L 5)
+
+#define MWM_DECOR_ALL (1L 0)
+#define MWM_DECOR_BORDER(1L 1)
+#define MWM_DECOR_RESIZEH (1L 2)
+#define MWM_DECOR_TITLE (1L 3)
+#define MWM_DECOR_MENU (1L 4)
+#define MWM_DECOR_MINIMIZE (1L 5)
+#define MWM_DECOR_MAXIMIZE (1L 6)
+
+#define MWM_INPUT_MODELESS 0
+#define MWM_INPUT_PRIMARY_APPLICATION_MODAL 1
+#define MWM_INPUT_SYSTEM_MODAL 2
+#define MWM_INPUT_FULL_APPLICATION_MODAL 3
+#define MWM_INPUT_APPLICATION_MODAL MWM_INPUT_PRIMARY_APPLICATION_MODAL
+
+#define MWM_TEAROFF_WINDOW (1L0)
+
+/*
+ * atoms
+ */
+#define _XA_MOTIF_BINDINGS _MOTIF_BINDINGS
+#define _XA_MOTIF_WM_HINTS _MOTIF_WM_HINTS
+#define _XA_MOTIF_WM_MESSAGES _MOTIF_WM_MESSAGES
+#define _XA_MOTIF_WM_OFFSET _MOTIF_WM_OFFSET
+#define _XA_MOTIF_WM_MENU _MOTIF_WM_MENU
+#define _XA_MOTIF_WM_INFO _MOTIF_WM_INFO
+#define _XA_MWM_HINTS _XA_MOTIF_WM_HINTS
+#define _XA_MWM_MESSAGES _XA_MOTIF_WM_MESSAGES
+#define _XA_MWM_MENU _XA_MOTIF_WM_MENU
+#define _XA_MWM_INFO _XA_MOTIF_WM_INFO
+
+
+/*
+ * _MWM_INFO property
+ */
+typedef struct {
+long flags;
+Window wm_window;
+} MotifWmInfo;
+
+typedef MotifWmInfo MwmInfo;
+
+#define MWM_INFO_STARTUP_STANDARD (1L0)
+#define MWM_INFO_STARTUP_CUSTOM (1L1)
+
+/*
+ * _MWM_HINTS property
+ */
+typedef struct {
+unsigned long flags;
+unsigned long functions;
+unsigned long decorations;
+long inputMode;
+unsigned long status;
+} PropMotifWmHints;
+
+typedef PropMotifWmHints
Re: [Ayatana-commits] [Merge] lp:~ted/indicator-session/bug611257 into lp:indicator-session
Review: Approve -- https://code.launchpad.net/~ted/indicator-session/bug611257/+merge/34340 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/libindicate/rb-crash into lp:libindicate
Ted Gould has proposed merging lp:~ted/libindicate/rb-crash into lp:libindicate.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Unreferences the proxy object on dispose so that we don't get any more signals
from it.
--
https://code.launchpad.net/~ted/libindicate/rb-crash/+merge/34560
Your team ayatana-commits is subscribed to branch lp:libindicate.
=== modified file 'libindicate/server.c'
--- libindicate/server.c 2010-02-18 22:02:35 +
+++ libindicate/server.c 2010-09-03 17:54:39 +
@@ -435,6 +435,11 @@
g_signal_emit(server, signals[SERVER_HIDE], 0, priv-type ? priv-type : , TRUE);
}
+ if (priv-dbus_proxy != NULL) {
+ g_object_unref(priv-dbus_proxy);
+ priv-dbus_proxy = NULL;
+ }
+
return;
}
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-messages/triangle-fix into lp:indicator-messages
Ted Gould has proposed merging lp:~ted/indicator-messages/triangle-fix into lp:indicator-messages. Requested reviews: Indicator Applet Developers (indicator-applet-developers) The triangle display callback wasn't getting the dbusmenu menuitem in its callback, so was exiting early. Now it gets it and is happy. -- https://code.launchpad.net/~ted/indicator-messages/triangle-fix/+merge/34562 Your team ayatana-commits is subscribed to branch lp:indicator-messages. === modified file 'src/indicator-messages.c' --- src/indicator-messages.c 2010-08-26 19:31:18 + +++ src/indicator-messages.c 2010-09-03 18:16:03 + @@ -453,7 +453,7 @@ /* Make sure we can handle the label changing */ g_signal_connect(G_OBJECT(newitem), DBUSMENU_MENUITEM_SIGNAL_PROPERTY_CHANGED, G_CALLBACK(application_prop_change_cb), label); g_signal_connect(G_OBJECT(newitem), DBUSMENU_MENUITEM_SIGNAL_PROPERTY_CHANGED, G_CALLBACK(application_icon_change_cb), icon); - g_signal_connect_after(G_OBJECT (gmi), expose_event, G_CALLBACK (application_triangle_draw_cb), NULL); + g_signal_connect_after(G_OBJECT (gmi), expose_event, G_CALLBACK (application_triangle_draw_cb), newitem); return TRUE; } ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/libindicate/rb-crash into lp:libindicate
Review: Approve +1 -- https://code.launchpad.net/~ted/libindicate/rb-crash/+merge/34560 Your team ayatana-commits is subscribed to branch lp:libindicate. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/indicator-applet/an-extra-pixel into lp:indicator-applet
The diff is empty -- https://code.launchpad.net/~ted/indicator-applet/an-extra-pixel/+merge/33913 Your team ayatana-commits is subscribed to branch lp:indicator-applet. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/indicator-applet/an-extra-pixel into lp:indicator-applet
Forgot to commit :) Fixed in r369. -- https://code.launchpad.net/~ted/indicator-applet/an-extra-pixel/+merge/33913 Your team ayatana-commits is subscribed to branch lp:indicator-applet. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/indicator-appmenu/desktop-menu-handling into lp:indicator-appmenu
Review: Needs Fixing In determine_new_desktop() it looks like you need to g_list_free() 'keys'. -- https://code.launchpad.net/~ted/indicator-appmenu/desktop-menu-handling/+merge/34491 Your team ayatana-commits is subscribed to branch lp:indicator-appmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/indicator-appmenu/desktop-menu-handling into lp:indicator-appmenu
Fixed in r72. -- https://code.launchpad.net/~ted/indicator-appmenu/desktop-menu-handling/+merge/34491 Your team ayatana-commits is subscribed to branch lp:indicator-appmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-messages/triangle-fix into lp:indicator-messages
The proposal to merge lp:~ted/indicator-messages/triangle-fix into lp:indicator-messages has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~ted/indicator-messages/triangle-fix/+merge/34562 Your team ayatana-commits is subscribed to branch lp:indicator-messages. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/indicator-appmenu/desktop-menu-handling into lp:indicator-appmenu
Review: Approve The code looks fine to me. I suggest landing that and trying it from a daily build for a few days. -- https://code.launchpad.net/~ted/indicator-appmenu/desktop-menu-handling/+merge/34491 Your team ayatana-commits is subscribed to branch lp:indicator-appmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/indicator-appmenu/working-close-menu-item into lp:indicator-appmenu
The code looks fine to me. I suggest landing that and trying it from a daily build for a few days. -- https://code.launchpad.net/~ted/indicator-appmenu/working-close-menu-item/+merge/34554 Your team ayatana-commits is subscribed to branch lp:indicator-appmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-appmenu/desktop-menu-handling into lp:indicator-appmenu
The proposal to merge lp:~ted/indicator-appmenu/desktop-menu-handling into lp:indicator-appmenu has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~ted/indicator-appmenu/desktop-menu-handling/+merge/34491 Your team ayatana-commits is subscribed to branch lp:indicator-appmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-appmenu/working-close-menu-item into lp:indicator-appmenu
The proposal to merge lp:~ted/indicator-appmenu/working-close-menu-item into lp:indicator-appmenu has been updated. Status: Needs review = Merged -- https://code.launchpad.net/~ted/indicator-appmenu/working-close-menu-item/+merge/34554 Your team ayatana-commits is subscribed to branch lp:indicator-appmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
