[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-datetime/trunk]
Status: Mature = Abandoned -- lp:indicator-datetime/0.3 https://code.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk Your team ayatana-commits is subscribed to branch lp:indicator-datetime/0.3. To unsubscribe from this branch go to https://code.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk/+edit-subscription ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-messages/trunk]
Status: Mature = Abandoned -- lp:indicator-messages/0.5 https://code.launchpad.net/~indicator-applet-developers/indicator-messages/trunk Your team ayatana-commits is subscribed to branch lp:indicator-messages/0.5. To unsubscribe from this branch go to https://code.launchpad.net/~indicator-applet-developers/indicator-messages/trunk/+edit-subscription ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ken-vandine/evolution-indicator/evo_3.4 into lp:evolution-indicator
Review: Approve The po/Makefile.in.in changes look odd, but they're apparently taken from intltool. -- https://code.launchpad.net/~ken-vandine/evolution-indicator/evo_3.4/+merge/107477 Your team ayatana-commits is subscribed to branch lp:evolution-indicator. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ken-vandine/evolution-indicator/evo_3.4 into lp:evolution-indicator
The proposal to merge lp:~ken-vandine/evolution-indicator/evo_3.4 into lp:evolution-indicator has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/evolution-indicator/evo_3.4/+merge/107477 -- https://code.launchpad.net/~ken-vandine/evolution-indicator/evo_3.4/+merge/107477 Your team ayatana-commits is subscribed to branch lp:evolution-indicator. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-860586 into lp:indicator-datetime/0.3
The proposal to merge lp:~jjardon/indicator-datetime/fix-860586 into lp:indicator-datetime/0.3 has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/fix-860586/+merge/79421 -- https://code.launchpad.net/~jjardon/indicator-datetime/fix-860586/+merge/79421 Your team ayatana-commits is subscribed to branch lp:indicator-datetime/0.3. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-794312 into lp:indicator-datetime/0.3
The proposal to merge lp:~jjardon/indicator-datetime/fix-794312 into lp:indicator-datetime/0.3 has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/fix-794312/+merge/79426 -- https://code.launchpad.net/~jjardon/indicator-datetime/fix-794312/+merge/79426 Your team ayatana-commits is subscribed to branch lp:indicator-datetime/0.3. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-datetime/trunk]
Status: Development = Mature -- lp:indicator-datetime/0.3 https://code.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk Your team ayatana-commits is subscribed to branch lp:indicator-datetime/0.3. To unsubscribe from this branch go to https://code.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk/+edit-subscription ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] What to call the unity panel?
On Tue, 2012-01-24 at 11:10 -0500, Michael Terry wrote: On Tue 24 Jan 2012 10:52:43 EST, John Lea wrote: Top bar is the term we have been using, it used to be Panel but this was a hangover from the Gnome2 days. mpt says menu bar so can you two hug it out and decide which one is better? :) Personal preference menu bar -- that says what it does where top bar just says where it is. It doesn't give any more information than what the user already has. --Ted signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-messages/trunk]
Status: Development = Mature -- lp:indicator-messages/0.5 https://code.launchpad.net/~indicator-applet-developers/indicator-messages/trunk Your team ayatana-commits is subscribed to branch lp:indicator-messages/0.5. To unsubscribe from this branch go to https://code.launchpad.net/~indicator-applet-developers/indicator-messages/trunk/+edit-subscription ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~jconti/indicator-applet/gnome3 into lp:indicator-applet
Review: Approve Great, thanks for the work on this. A few comments: * Please don't change the version number in configure.ac, it really confuses things if there are multiple version numbers in the wild so it's better just to have one place define it. I'll fix this on merge, no worries there. * Love that you changed the strings to #defines. I think that's a wonderful thing :-) Thanks again for your work. -- https://code.launchpad.net/~jconti/indicator-applet/gnome3/+merge/80877 Your team ayatana-commits is subscribed to branch lp:indicator-applet. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-datetime/geoclue-fix into lp:indicator-datetime
Ted Gould has proposed merging lp:~ted/indicator-datetime/geoclue-fix into
lp:indicator-datetime.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
For more details, see:
https://code.launchpad.net/~ted/indicator-datetime/geoclue-fix/+merge/80159
Fixing the check for the client so the GeoClue feature actually works. Eh, no
comment on why this was missed for so long :-/
--
https://code.launchpad.net/~ted/indicator-datetime/geoclue-fix/+merge/80159
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
=== modified file 'src/datetime-service.c'
--- src/datetime-service.c 2011-10-13 04:30:40 +
+++ src/datetime-service.c 2011-10-23 21:59:25 +
@@ -1404,7 +1404,12 @@
geo_master = client;
- if (geo_master != NULL) {
+ if (error != NULL) {
+ g_warning(Unable to get a GeoClue client! '%s' Geolocation based timezone support will not be available., error-message);
+ return;
+ }
+
+ if (geo_master == NULL) {
g_warning(_(Unable to get a GeoClue client! Geolocation based timezone support will not be available.));
return;
}
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/remove_libunique into lp:indicator-datetime
The proposal to merge lp:~jjardon/indicator-datetime/remove_libunique into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/remove_libunique/+merge/78240 -- https://code.launchpad.net/~jjardon/indicator-datetime/remove_libunique/+merge/78240 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-dev] [Dx-team] Handling merge requests that apply to Oneiric
On Wed, 2011-10-12 at 13:39 +0100, Neil Jagdish Patel wrote: For any branch you merge-propose into lp:unity/4.0, please make sure it was based on lp:unity/4.0 and not lp:unity, otherwise your merge request will bring in the rest of lp:unity, which is not what we want right now :) Great post, I just wanted to underline this, bold it, and highlight it. If you think that it *might* be an SRU start from the older branch. It's *way* easier to go forward than backwards. Also, I want to say, this applies to the indicators as well :-) --Ted signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~ayatana-dev Post to : ayatana-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-dev More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-740977 into lp:indicator-datetime
The proposal to merge lp:~jjardon/indicator-datetime/fix-740977 into lp:indicator-datetime has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/fix-740977/+merge/78342 -- https://code.launchpad.net/~jjardon/indicator-datetime/fix-740977/+merge/78342 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~kaijanmaki/indicator-datetime/lp-774071 into lp:indicator-datetime
Review: Disapprove Hey Antti, it seems that you made your branch off of the packaging branch instead of the development branch. Can you remake it on devel branch please? -- https://code.launchpad.net/~kaijanmaki/indicator-datetime/lp-774071/+merge/77599 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-session/lp_858798 into lp:indicator-session
The proposal to merge lp:~ken-vandine/indicator-session/lp_858798 into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/indicator-session/lp_858798/+merge/77952 -- https://code.launchpad.net/~ken-vandine/indicator-session/lp_858798/+merge/77952 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~kaijanmaki/indicator-datetime/lp-774071 into lp:indicator-datetime
The proposal to merge lp:~kaijanmaki/indicator-datetime/lp-774071 into lp:indicator-datetime has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~kaijanmaki/indicator-datetime/lp-774071/+merge/77599 -- https://code.launchpad.net/~kaijanmaki/indicator-datetime/lp-774071/+merge/77599 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-746176 into lp:indicator-datetime
The proposal to merge lp:~jjardon/indicator-datetime/fix-746176 into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/fix-746176/+merge/78347 -- https://code.launchpad.net/~jjardon/indicator-datetime/fix-746176/+merge/78347 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/indicator-session/lp864085 into lp:indicator-session
Oh, I hope that no one disables checks... that'd be a really bad idea. But, anyway, fixed. -- https://code.launchpad.net/~ted/indicator-session/lp864085/+merge/78733 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-session/gvariant_fixes into lp:indicator-session
Ted Gould has proposed merging lp:~ted/indicator-session/gvariant_fixes into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
Bug #863930 in Session Menu: indicator-session-service crashed with SIGABRT
(assertion failed: (0 = index index 24))
https://bugs.launchpad.net/indicator-session/+bug/863930
For more details, see:
https://code.launchpad.net/~ted/indicator-session/gvariant_fixes/+merge/78758
Fixing up some of our g_variant ref counting to hopefully fix a couple of bugs.
--
https://code.launchpad.net/~ted/indicator-session/gvariant_fixes/+merge/78758
Your team ayatana-commits is subscribed to branch lp:indicator-session.
=== modified file 'src/apt-transaction.c'
--- src/apt-transaction.c 2011-09-07 11:04:16 +
+++ src/apt-transaction.c 2011-10-09 14:45:27 +
@@ -232,7 +232,6 @@
0,
current_state);
}
- g_variant_unref (parameters);
}
static void
=== modified file 'src/apt-watcher.c'
--- src/apt-watcher.c 2011-09-19 20:47:59 +
+++ src/apt-watcher.c 2011-10-09 14:45:27 +
@@ -425,7 +425,7 @@
g_return_if_fail (APT_IS_WATCHER (user_data));
AptWatcher* self = APT_WATCHER (user_data);
- g_variant_ref (parameters);
+ g_variant_ref_sink (parameters);
GVariant *value = g_variant_get_child_value (parameters, 0);
if (g_strcmp0(signal_name, ActiveTransactionsChanged) == 0){
@@ -477,6 +477,7 @@
}
}
+ g_variant_unref (value);
g_variant_unref (parameters);
}
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-session/lp864085 into lp:indicator-session
Ted Gould has proposed merging lp:~ted/indicator-session/lp864085 into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
Bug #867926 in indicator-session (Ubuntu): gtk-logout-helper crashed with
SIGSEGV in g_variant_unref()
https://bugs.launchpad.net/ubuntu/+source/indicator-session/+bug/867926
For more details, see:
https://code.launchpad.net/~ted/indicator-session/lp864085/+merge/78733
Protect against the case where we can't get the settings for whatever reason.
--
https://code.launchpad.net/~ted/indicator-session/lp864085/+merge/78733
Your team ayatana-commits is subscribed to branch lp:indicator-session.
=== modified file 'src/settings-helper.c'
--- src/settings-helper.c 2011-09-06 15:52:08 +
+++ src/settings-helper.c 2011-10-08 19:54:23 +
@@ -38,41 +38,44 @@
static guint restart_notify = 0;
static guint shutdown_notify = 0;
-static void
+static gboolean
build_settings (void) {
- if(!settings) {
+ if (settings == NULL) {
settings = g_settings_new (SESSION_SCHEMA);
}
- return;
+ if (settings == NULL) {
+ return FALSE;
+ }
+ return TRUE;
}
gboolean
supress_confirmations (void) {
- build_settings();
+ g_return_val_if_fail(build_settings(), FALSE);
return g_settings_get_boolean (settings, SUPPRESS_KEY) ;
}
gboolean
should_show_user_menu (void) {
- build_settings();
+ g_return_val_if_fail(build_settings(), TRUE);
return g_settings_get_boolean (settings, SHOW_USER_MENU) ;
}
gboolean
show_logout (void) {
- build_settings();
+ g_return_val_if_fail(build_settings(), TRUE);
return !g_settings_get_boolean (settings, LOGOUT_KEY) ;
}
gboolean
show_restart (void) {
- build_settings();
+ g_return_val_if_fail(build_settings(), TRUE);
return !g_settings_get_boolean (settings, RESTART_KEY) ;
}
gboolean
show_shutdown (void) {
- build_settings();
+ g_return_val_if_fail(build_settings(), TRUE);
return !g_settings_get_boolean (settings, SHUTDOWN_KEY) ;
}
@@ -122,7 +125,7 @@
void
update_menu_entries(RestartShutdownLogoutMenuItems * restart_shutdown_logout_mi) {
/* If we don't have a client, build one. */
- build_settings();
+ g_return_if_fail(build_settings());
if (confirmation_notify != 0) {
g_signal_handler_disconnect (settings, confirmation_notify);
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/timer-fix-837440 into lp:indicator-datetime
Review: Disapprove Indicator-datetime needs to have all contributions be copyright Canonical. I'm guessing those contributors won't sign the CLA :-) -- https://code.launchpad.net/~jjardon/indicator-datetime/timer-fix-837440/+merge/77625 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/timer-fix-837440 into lp:indicator-datetime
The proposal to merge lp:~jjardon/indicator-datetime/timer-fix-837440 into lp:indicator-datetime has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/timer-fix-837440/+merge/77625 -- https://code.launchpad.net/~jjardon/indicator-datetime/timer-fix-837440/+merge/77625 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~robert-ancell/indicator-datetime/lp-861123 into lp:indicator-datetime
The proposal to merge lp:~robert-ancell/indicator-datetime/lp-861123 into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~robert-ancell/indicator-datetime/lp-861123/+merge/77275 -- https://code.launchpad.net/~robert-ancell/indicator-datetime/lp-861123/+merge/77275 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-session/lp740382 into lp:indicator-session
Ted Gould has proposed merging lp:~ted/indicator-session/lp740382 into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
Bug #740382 in Session Menu: gtk-logout-helper crashed with SIGABRT in
__libc_start_main()
https://bugs.launchpad.net/indicator-session/+bug/740382
For more details, see:
https://code.launchpad.net/~ted/indicator-session/lp740382/+merge/77176
Fixing and abort and adding an INVALID to the params so we have the proper
two so that we should get less errors that cause the abort.
--
https://code.launchpad.net/~ted/indicator-session/lp740382/+merge/77176
Your team ayatana-commits is subscribed to branch lp:indicator-session.
=== modified file 'src/gtk-logout-helper.c'
--- src/gtk-logout-helper.c 2011-09-08 03:09:01 +
+++ src/gtk-logout-helper.c 2011-09-27 14:58:23 +
@@ -55,6 +55,7 @@
dbus_g_proxy_call(proxy,
Stop,
error,
+ G_TYPE_INVALID,
G_TYPE_INVALID);
break;
case LOGOUT_DIALOG_TYPE_RESTART:
@@ -62,6 +63,7 @@
dbus_g_proxy_call(proxy,
Restart,
error,
+ G_TYPE_INVALID,
G_TYPE_INVALID);
break;
default:
@@ -72,7 +74,7 @@
g_object_unref(proxy);
if (error != NULL) {
- g_error(Unable to signal ConsoleKit);
+ g_warning(Unable to signal ConsoleKit);
g_error_free(error);
}
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-session/restart-icon-change into lp:indicator-session
Ted Gould has proposed merging lp:~ted/indicator-session/restart-icon-change
into lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
Bug #854292 in Session Menu: indicator-session power menu disappears after
running update-manager or apt-get
https://bugs.launchpad.net/indicator-session/+bug/854292
For more details, see:
https://code.launchpad.net/~ted/indicator-session/restart-icon-change/+merge/77090
Fixes the icon to update instead of replacing. This probably caused an
interesting race in the panel service making the panel service think it was
hidden in some cases. Depends on when it updated.
--
https://code.launchpad.net/~ted/indicator-session/restart-icon-change/+merge/77090
Your team ayatana-commits is subscribed to branch lp:indicator-session.
=== modified file 'src/indicator-session.c'
--- src/indicator-session.c 2011-09-08 17:40:07 +
+++ src/indicator-session.c 2011-09-27 04:33:18 +
@@ -509,11 +509,11 @@
}
else if (g_strcmp0(signal_name, RestartRequired) == 0) {
if (greeter_mode == TRUE){
- self-devices.image = indicator_image_helper (GREETER_ICON_RESTART);
+ indicator_image_helper_update(self-devices.image, GREETER_ICON_RESTART);
}
else{
g_debug (reboot required);
- self-devices.image = indicator_image_helper (ICON_RESTART);
+ indicator_image_helper_update(self-devices.image, ICON_RESTART);
}
}
}
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~kelemeng/indicator-datetime/bug853130 into lp:indicator-datetime
The proposal to merge lp:~kelemeng/indicator-datetime/bug853130 into lp:indicator-datetime has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~kelemeng/indicator-datetime/bug853130/+merge/75889 -- https://code.launchpad.net/~kelemeng/indicator-datetime/bug853130/+merge/75889 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~kelemeng/indicator-datetime/bug853130 into lp:indicator-datetime
The proposal to merge lp:~kelemeng/indicator-datetime/bug853130 into lp:indicator-datetime has been updated. Status: Merged = Approved For more details, see: https://code.launchpad.net/~kelemeng/indicator-datetime/bug853130/+merge/75889 -- https://code.launchpad.net/~kelemeng/indicator-datetime/bug853130/+merge/75889 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-dev] C++ memory allocation
On Tue, 2011-09-20 at 23:27 -0400, Jay Taoko wrote: On 9/20/2011 10:48 PM, Ted Gould wrote: On Wed, 2011-09-21 at 11:43 +1200, Tim Penhey wrote: We can see that calloc is faster only at small sizes. What's more, the overhead of using a std::vector decreases rapidly as the size gets larger. And aren't almost all allocations in most programs smaller in nature. Especially GUI programs and toolkits. The only place I could think we'd even come close to large allocations would be in buffer images, and there shouldn't be too many of those. I think that the old adage still holds: If you want something done right, do it yourself. But often times you're willing to take the penalty and outsource the work to the standard lib to make life easy in non-critical sections. So use the appropriate technology for the code in question. ;-) The section in question creates a buffer of data to load into and OpenGL texture. So the data can be large. However, in that location, we are doing 1 allocation and then we exit. Is one really better than the other in this case? I would say no. In general, I'd say any discussion over the style of one allocation is bike shedding. Who ever writes the code gets to decide :-) --Ted signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~ayatana-dev Post to : ayatana-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-dev More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-837440 into lp:indicator-datetime
The proposal to merge lp:~jjardon/indicator-datetime/fix-837440 into lp:indicator-datetime has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/fix-837440/+merge/75717 -- https://code.launchpad.net/~jjardon/indicator-datetime/fix-837440/+merge/75717 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/delay-apt-interaction into lp:indicator-session
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/delay-apt-interaction/+merge/75376 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/delay-apt-interaction into lp:indicator-session
The proposal to merge lp:~cjcurran/indicator-session/delay-apt-interaction into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/delay-apt-interaction/+merge/75376 -- https://code.launchpad.net/~cjcurran/indicator-session/delay-apt-interaction/+merge/75376 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-dev] Porting Unity to Arch Linux
On Thu, 2011-09-08 at 16:59 +0100, Javier Jardón wrote: On 7 September 2011 08:44, Devil505 devil505li...@gmail.com wrote: I'm porting Ayatana to Frugalware and it's not always easy, IMHO these ubuntu patches (especially the ones for glib2 and gtk2/3) should be accepted by upstream, some efforts must be done in that way if we want to see Unity and indicators available on non-ubuntu based distributions. AFAIK, No patches are propossed upstream Here's another: https://bugzilla.gnome.org/show_bug.cgi?id=654557 But, I think the more telling statistic is here is all the patches that are sitting in Bugzilla for GTK+ alone[1]. At the time of this writing there are 448 of them. Ayatana patches shouldn't get special treatment, all the GTK+ patches should looked at and either rejected or accepted. Now, I don't want to say we're perfect, we're not[2] -- but we're working on it! In the end, it is part of our process to submit all of these patches that are reasonable for upstream adoption upstream. If you find one that's not, please bring it to our attention and we will fix that. --Ted [1] https://bugzilla.gnome.org/buglist.cgi?type1-0-0=equals;type0-1-0=equals;field0-1-0=attachments.isobsolete;field0-0-0=attachments.ispatch;query_based_on=Patches%20%28Unreviewed%29;query_format=advanced;value0-2-0=none;value0-1-0=0;bug_status=UNCONFIRMED;bug_status=NEW;bug_status=ASSIGNED;bug_status=REOPENED;bug_status=NEEDINFO;value1-0-0=%25user%25;field0-2-0=attachments.status;type0-0-0=equals;value0-0-0=1;type0-2-0=anyexact;known_name=Patches%20%28Unreviewed%29product=gtk%2B [2] https://code.launchpad.net/ayatana/+patches signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~ayatana-dev Post to : ayatana-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-dev More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/optional-string-in-switch-item into lp:indicator-session
Review: Needs Information Why do we need a preference for this? Can we just use the check for guest function? -- https://code.launchpad.net/~cjcurran/indicator-session/optional-string-in-switch-item/+merge/74598 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/hide-real-name-on-panel-gsetting into lp:indicator-session
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/hide-real-name-on-panel-gsetting/+merge/74656 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/hide-real-name-on-panel-gsetting into lp:indicator-session
The proposal to merge lp:~cjcurran/indicator-session/hide-real-name-on-panel-gsetting into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/hide-real-name-on-panel-gsetting/+merge/74656 -- https://code.launchpad.net/~cjcurran/indicator-session/hide-real-name-on-panel-gsetting/+merge/74656 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/optional-string-in-switch-item into lp:indicator-session
The proposal to merge lp:~cjcurran/indicator-session/optional-string-in-switch-item into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/optional-string-in-switch-item/+merge/74598 -- https://code.launchpad.net/~cjcurran/indicator-session/optional-string-in-switch-item/+merge/74598 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/hasguestaccount-support into lp:indicator-session
Review: Approve You technically should have a g_value_unset() after using the value. But since it's a boolean we know that it shouldn't have any memory so it's not a big deal. -- https://code.launchpad.net/~cjcurran/indicator-session/hasguestaccount-support/+merge/74510 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/hasguestaccount-support into lp:indicator-session
The proposal to merge lp:~cjcurran/indicator-session/hasguestaccount-support into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/hasguestaccount-support/+merge/74510 -- https://code.launchpad.net/~cjcurran/indicator-session/hasguestaccount-support/+merge/74510 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/cancel-existing-apt-operations into lp:indicator-session
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/cancel-existing-apt-operations/+merge/74512 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/cancel-existing-apt-operations into lp:indicator-session
The proposal to merge lp:~cjcurran/indicator-session/cancel-existing-apt-operations into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/cancel-existing-apt-operations/+merge/74512 -- https://code.launchpad.net/~cjcurran/indicator-session/cancel-existing-apt-operations/+merge/74512 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-session/gtk-logout-debug-messages into lp:indicator-session
Ted Gould has proposed merging
lp:~ted/indicator-session/gtk-logout-debug-messages into lp:indicator-session.
Requested reviews:
Conor Curran (cjcurran)
For more details, see:
https://code.launchpad.net/~ted/indicator-session/gtk-logout-debug-messages/+merge/74541
Some debug messages, let's route out the bugs!
--
https://code.launchpad.net/~ted/indicator-session/gtk-logout-debug-messages/+merge/74541
Your team ayatana-commits is subscribed to branch lp:indicator-session.
=== modified file 'src/gtk-logout-helper.c'
--- src/gtk-logout-helper.c 2011-08-19 18:13:57 +
+++ src/gtk-logout-helper.c 2011-09-08 03:12:24 +
@@ -31,6 +31,8 @@
static void
consolekit_fallback (LogoutDialogType action)
{
+ g_debug(Falling back to using ConsoleKit for action);
+
DBusGConnection * sbus = dbus_g_bus_get(DBUS_BUS_SYSTEM, NULL);
g_return_if_fail(sbus != NULL); /* worst case */
DBusGProxy * proxy = dbus_g_proxy_new_for_name(sbus, org.freedesktop.ConsoleKit,
@@ -49,12 +51,14 @@
g_warning(Unable to fallback to ConsoleKit for logout as it's a session issue. We need some sort of session handler.);
break;
case LOGOUT_DIALOG_TYPE_SHUTDOWN:
+ g_debug(Telling ConsoleKit to 'Stop');
dbus_g_proxy_call(proxy,
Stop,
error,
G_TYPE_INVALID);
break;
case LOGOUT_DIALOG_TYPE_RESTART:
+ g_debug(Telling ConsoleKit to 'Restart');
dbus_g_proxy_call(proxy,
Restart,
error,
@@ -104,12 +108,15 @@
g_clear_error (error);
if (action == LOGOUT_DIALOG_TYPE_LOG_OUT) {
+ g_debug(Asking Session manager to 'Logout');
res = dbus_g_proxy_call_with_timeout (sm_proxy, Logout, INT_MAX, error,
G_TYPE_UINT, 1, G_TYPE_INVALID, G_TYPE_INVALID);
} else if (action == LOGOUT_DIALOG_TYPE_SHUTDOWN) {
+ g_debug(Asking Session manager to 'RequestShutdown');
res = dbus_g_proxy_call_with_timeout (sm_proxy, RequestShutdown, INT_MAX, error,
G_TYPE_INVALID, G_TYPE_INVALID);
} else if (action == LOGOUT_DIALOG_TYPE_RESTART) {
+ g_debug(Asking Session manager to 'RequestReboot');
res = dbus_g_proxy_call_with_timeout (sm_proxy, RequestReboot, INT_MAX, error,
G_TYPE_INVALID, G_TYPE_INVALID);
} else {
@@ -122,6 +129,8 @@
} else {
g_warning (SessionManager action failed: unknown error);
}
+
+ consolekit_fallback(action);
}
g_object_unref(sm_proxy);
@@ -139,6 +148,7 @@
option_logout (const gchar * arg, const gchar * value, gpointer data, GError * error)
{
type = LOGOUT_DIALOG_TYPE_LOG_OUT;
+ g_debug(Dialog type: logout);
return TRUE;
}
@@ -146,6 +156,7 @@
option_shutdown (const gchar * arg, const gchar * value, gpointer data, GError * error)
{
type = LOGOUT_DIALOG_TYPE_SHUTDOWN;
+ g_debug(Dialog type: shutdown);
return TRUE;
}
@@ -153,6 +164,7 @@
option_restart (const gchar * arg, const gchar * value, gpointer data, GError * error)
{
type = LOGOUT_DIALOG_TYPE_RESTART;
+ g_debug(Dialog type: restart);
return TRUE;
}
@@ -193,6 +205,7 @@
GtkWidget * dialog = NULL;
if (!supress_confirmations()) {
+ g_debug(Showing dialog to ask for user confirmation);
dialog = GTK_WIDGET(logout_dialog_new(type));
}
@@ -200,17 +213,27 @@
GtkResponseType response = gtk_dialog_run(GTK_DIALOG(dialog));
gtk_widget_hide(dialog);
+ if (response == GTK_RESPONSE_OK) {
+ g_debug(Dialog return response: 'okay');
+ } else if (response == GTK_RESPONSE_HELP) {
+ g_debug(Dialog return response: 'help');
+ } else {
+ g_debug(Dialog return response: %d, response);
+ }
+
if (response == GTK_RESPONSE_HELP) {
type = LOGOUT_DIALOG_TYPE_RESTART;
response = GTK_RESPONSE_OK;
}
if (response != GTK_RESPONSE_OK) {
+ g_debug(Final response was not okay, quiting);
return 0;
}
}
session_action(type);
+ g_debug(Finished action, quiting);
return 0;
}
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-dev] Introducing Stack Inspector
On Mon, 2011-09-05 at 16:44 +0800, Sam Spilsbury wrote: Q: What do you plan to do with this in the future A: We can probably use this as a test harness for the new stacking code to compare what's on the server with what the stacking code thinks the stack is to nip any problems in the bud. Also, I think it should be possible to record what's going on on a user's system, so if they have a reproducible bug they can just send us the log and this tool can play it back (albeit, with no pixmaps, only puke-colored rectangles). I also want to make it handle stuff like damage events so you have realtime thumbnails though I think that's more of a distraction than a help. Is there a way we can have the CLI tool output results the GUI tool could read? Would that make sense or do you need something more dynamic to do useful debugging? If we could do that, an apport hook could be easily devised to capture that data. --Ted signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~ayatana-dev Post to : ayatana-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-dev More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/hide-user-menu-via-gsettings-key into lp:indicator-session
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/hide-user-menu-via-gsettings-key/+merge/74262 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/hide-user-menu-via-gsettings-key into lp:indicator-session
The proposal to merge lp:~cjcurran/indicator-session/hide-user-menu-via-gsettings-key into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/hide-user-menu-via-gsettings-key/+merge/74262 -- https://code.launchpad.net/~cjcurran/indicator-session/hide-user-menu-via-gsettings-key/+merge/74262 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/null-error-user-dbus-mgr into lp:indicator-session
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/null-error-user-dbus-mgr/+merge/74080 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/null-error-user-dbus-mgr into lp:indicator-session
The proposal to merge lp:~cjcurran/indicator-session/null-error-user-dbus-mgr into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/null-error-user-dbus-mgr/+merge/74080 -- https://code.launchpad.net/~cjcurran/indicator-session/null-error-user-dbus-mgr/+merge/74080 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/checkforpow into lp:indicator-datetime
The proposal to merge lp:~jjardon/indicator-datetime/checkforpow into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/checkforpow/+merge/74224 -- https://code.launchpad.net/~jjardon/indicator-datetime/checkforpow/+merge/74224 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/checkforpow into lp:indicator-datetime
Review: Approve -- https://code.launchpad.net/~jjardon/indicator-datetime/checkforpow/+merge/74224 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/remove_death_code into lp:indicator-datetime
The proposal to merge lp:~jjardon/indicator-datetime/remove_death_code into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/remove_death_code/+merge/74227 -- https://code.launchpad.net/~jjardon/indicator-datetime/remove_death_code/+merge/74227 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/remove_death_code into lp:indicator-datetime
Review: Approve -- https://code.launchpad.net/~jjardon/indicator-datetime/remove_death_code/+merge/74227 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/optimizations into lp:indicator-datetime
Review: Approve -- https://code.launchpad.net/~jjardon/indicator-datetime/optimizations/+merge/74210 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/optimizations into lp:indicator-datetime
The proposal to merge lp:~jjardon/indicator-datetime/optimizations into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/optimizations/+merge/74210 -- https://code.launchpad.net/~jjardon/indicator-datetime/optimizations/+merge/74210 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-837440 into lp:indicator-datetime
Review: Needs Information It seems that the wall-clock isn't in 3.1.91 which is what is in Oneiric: http://packages.ubuntu.com/oneiric/amd64/libgnome-desktop-3-dev/filelist So that would mean the pkgconfig check is wrong there. Also, I'm a little uncomfortable using a schema that isn't in our package. I'd like to see if there isn't another way besides using GSettings to do that. The problem is that GSettings just aborts when the schema isn't there. It's such a high penalty to pay, I don't want to take that risk. If we have to, let's put that schema setting in the indicator not in the panel. -- https://code.launchpad.net/~jjardon/indicator-datetime/fix-837440/+merge/74123 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~sargentd/libindicate/opional-mono into lp:libindicate
The proposal to merge lp:~sargentd/libindicate/opional-mono into lp:libindicate has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~sargentd/libindicate/opional-mono/+merge/73989 -- https://code.launchpad.net/~sargentd/libindicate/opional-mono/+merge/73989 Your team ayatana-commits is subscribed to branch lp:libindicate. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~sargentd/libindicate/opional-mono into lp:libindicate
Review: Approve -- https://code.launchpad.net/~sargentd/libindicate/opional-mono/+merge/73989 Your team ayatana-commits is subscribed to branch lp:libindicate. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-775113 into lp:indicator-datetime
No currently a new enough version of GLib in Oneiric to test. Need to circle back when that gets updated. -- https://code.launchpad.net/~jjardon/indicator-datetime/fix-775113/+merge/73846 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-dev] Bugs with patches attached to them.
On Fri, 2011-09-02 at 11:40 -0400, Jorge O. Castro wrote: If a contributor has just attached a patch and not done a merge proposal in bzr then feel free to snag it, branch unity trunk, apply their patch, test it, and then propose it via Launchpad. (There could be some low hanging fruit there.) It would be great if people could help out here. One thing to note is make sure you set the author properly when you commit. So if I was committing a patch that was written by Jorge I would do: $ bzr commit --author Jorge O. Castro jo...@ubuntu.com Also it's useful if you tie it to the bug. You can do this like this: $ bzr commit --fixes lp:123456 And, of course, those can be used at the same time :-) Lastly, a quick helper that's in Bazaar is doing the merge proposal without having to wait for the WebUI. $ bzr lp-propose-merge --review unity-team Thanks, Ted signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~ayatana-dev Post to : ayatana-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-dev More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/greeter-icon into lp:indicator-session
The proposal to merge lp:~cjcurran/indicator-session/greeter-icon into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/greeter-icon/+merge/73705 -- https://code.launchpad.net/~cjcurran/indicator-session/greeter-icon/+merge/73705 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-793450 into lp:indicator-datetime
The proposal to merge lp:~jjardon/indicator-datetime/fix-793450 into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/fix-793450/+merge/72912 -- https://code.launchpad.net/~jjardon/indicator-datetime/fix-793450/+merge/72912 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/793450 into lp:indicator-datetime
Review: Needs Fixing This merge has a conflict in it, could you please update it to the latest version in that branch? Thanks! -- https://code.launchpad.net/~jjardon/indicator-datetime/793450/+merge/72910 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-dev] The return of the ellipsis
On Tue, 2011-08-30 at 18:38 +0100, Matthew Paul Thomas wrote: Conscious User wrote on 21/08/11 20:37: Wrong: ☑ Automatically shorten pasted URLs. Right: ☑ Automatically shorten pasted URLs Well, that looks familiar... :) There was an Inkscape example in there for Ted, too. ;-) Is there a single, 100% reliable place where all those rules are documented? ... Not that I know of. They should be in the HIG too. But having them in widely-used code would be much more effective than having them in the HIG. http://sourcefrog.net/weblog/software/aesthetics/interface-levels.html Meanwhile, Rodney Dawes has suggested including these tests in intltool. https://twitter.com/dohbee/status/106387128849674240 I don't know anything about intltool, I'm just passing the suggestion along. I was thinking Lintian, but apparently the only way to report bugs in Debian requires getting a mail server properly set up on your computer -- which I haven't managed to do yet. In a nutshell, we can't really do the context ones. But I was thinking perhaps we could write a GTK+/Qt patch to give warnings on them. Since those would only be command line it seems that real users would rarely see them. Though, developers may miss them as well. --Ted signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~ayatana-dev Post to : ayatana-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-dev More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/utf8-guest-fixes into lp:indicator-session
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/utf8-guest-fixes/+merge/73405 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-messages/gutter-fix into lp:indicator-messages
Ted Gould has proposed merging lp:~ted/indicator-messages/gutter-fix into
lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
For more details, see:
https://code.launchpad.net/~ted/indicator-messages/gutter-fix/+merge/72819
Make it so that we align the text with all the entires in the menu.
--
https://code.launchpad.net/~ted/indicator-messages/gutter-fix/+merge/72819
Your team ayatana-commits is subscribed to branch lp:indicator-messages.
=== modified file 'src/indicator-messages.c'
--- src/indicator-messages.c 2011-08-17 16:46:28 +
+++ src/indicator-messages.c 2011-08-25 02:41:17 +
@@ -581,11 +581,6 @@
GtkMenuItem * gmi = GTK_MENU_ITEM(gtk_image_menu_item_new());
gtk_image_menu_item_set_always_show_image(GTK_IMAGE_MENU_ITEM(gmi), TRUE);
- gint padding = 4;
- gtk_widget_style_get(GTK_WIDGET(gmi), horizontal-padding, padding, NULL);
-
- GtkWidget * hbox = gtk_hbox_new(FALSE, 0);
-
/* Set the minimum size, we always want it to take space */
gint width, height;
gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, width, height);
@@ -602,12 +597,10 @@
/* Application name in a label */
GtkWidget * label = gtk_label_new(dbusmenu_menuitem_property_get(newitem, APPLICATION_MENUITEM_PROP_NAME));
gtk_misc_set_alignment(GTK_MISC(label), 0.0, 0.5);
- gtk_box_pack_start(GTK_BOX(hbox), label, TRUE, TRUE, padding);
gtk_widget_show(label);
/* Insert the hbox */
- gtk_container_add(GTK_CONTAINER(gmi), hbox);
- gtk_widget_show(hbox);
+ gtk_container_add(GTK_CONTAINER(gmi), label);
/* Attach some of the standard GTK stuff */
dbusmenu_gtkclient_newitem_base(DBUSMENU_GTKCLIENT(client), newitem, gmi, parent);
@@ -698,9 +691,9 @@
gint padding = 4;
gint font_size = RIGHT_LABEL_FONT_SIZE;
- gtk_widget_style_get(GTK_WIDGET(gmi), horizontal-padding, padding, NULL);
+ gtk_widget_style_get(GTK_WIDGET(gmi), toggle-spacing, padding, NULL);
- GtkWidget * hbox = gtk_hbox_new(FALSE, 0);
+ GtkWidget * hbox = gtk_hbox_new(FALSE, padding);
/* Icon, probably someone's face or avatar on an IM */
mi_data-icon = gtk_image_new();
@@ -735,7 +728,7 @@
}
}
gtk_misc_set_alignment(GTK_MISC(mi_data-icon), 0.0, 0.5);
- gtk_box_pack_start(GTK_BOX(hbox), mi_data-icon, FALSE, FALSE, padding);
+ gtk_box_pack_start(GTK_BOX(hbox), mi_data-icon, FALSE, FALSE, 0);
if (pixbuf != NULL) {
gtk_widget_show(mi_data-icon);
@@ -744,7 +737,7 @@
/* Label, probably a username, chat room or mailbox name */
mi_data-label = gtk_label_new(dbusmenu_menuitem_property_get(newitem, INDICATOR_MENUITEM_PROP_LABEL));
gtk_misc_set_alignment(GTK_MISC(mi_data-label), 0.0, 0.5);
- gtk_box_pack_start(GTK_BOX(hbox), mi_data-label, TRUE, TRUE, padding);
+ gtk_box_pack_start(GTK_BOX(hbox), mi_data-label, TRUE, TRUE, 0);
gtk_widget_show(mi_data-label);
/* Usually either the time or the count on the individual
=== modified file 'src/messages-service.c'
--- src/messages-service.c 2011-08-19 18:36:27 +
+++ src/messages-service.c 2011-08-25 02:41:17 +
@@ -32,7 +32,6 @@
#include libdbusmenu-glib/client.h
#include libdbusmenu-glib/server.h
-#include libdbusmenu-glib/menuitem-proxy.h
#include im-menu-item.h
#include app-menu-item.h
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-session/activate-prototype into lp:indicator-session
Ted Gould has proposed merging lp:~ted/indicator-session/activate-prototype into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) For more details, see: https://code.launchpad.net/~ted/indicator-session/activate-prototype/+merge/72595 Fix for a prototype -- https://code.launchpad.net/~ted/indicator-session/activate-prototype/+merge/72595 Your team ayatana-commits is subscribed to branch lp:indicator-session. === modified file 'src/user-menu-mgr.c' --- src/user-menu-mgr.c 2011-08-23 11:51:51 + +++ src/user-menu-mgr.c 2011-08-23 15:33:34 + @@ -44,6 +44,9 @@ static void activate_user_session (DbusmenuMenuitem *mi, guint timestamp, gpointer user_data); +static void activate_user_accounts (DbusmenuMenuitem *mi, +guint timestamp, +gpointer user_data); static gint compare_users_by_username (const gchar *a, const gchar *b); static void activate_online_accounts (DbusmenuMenuitem *mi, ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/user-image-panel into lp:indicator-session
The proposal to merge lp:~cjcurran/indicator-session/user-image-panel into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/user-image-panel/+merge/72615 -- https://code.launchpad.net/~cjcurran/indicator-session/user-image-panel/+merge/72615 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/user-image-panel into lp:indicator-session
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/user-image-panel/+merge/72615 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/brand-the-attached-devices-labels into lp:indicator-session
Review: Needs Fixing The translation is wrong here. You want to have the _() around the format string. So _(%s scanner) that way the translator can move the name around appropriately for their language. -- https://code.launchpad.net/~cjcurran/indicator-session/brand-the-attached-devices-labels/+merge/72606 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/user-images into lp:indicator-session
The proposal to merge lp:~cjcurran/indicator-session/user-images into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/user-images/+merge/72493 -- https://code.launchpad.net/~cjcurran/indicator-session/user-images/+merge/72493 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/user-images into lp:indicator-session
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/user-images/+merge/72493 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-dev] The return of the ellipsis
Hello, So it seems regularly about this time in the cycle we start getting bugs about ... in our code instead of …. Seems that they always creep back in, and that's very annoying. How do we keep bugs out? Through testing! I've created a small test[1] to test for the presence of ... at the end of user visible strings in the code, and to fail if it finds any. The test is cleverly called test-ellipsis and it uses the POT file from gettext to look at all the user visible strings (since all user visible strings are translatable). I'm writing so that people know a bit about it when it fails, but also to ask if there's anything else that I should add with a similar methodology before I replicate this snippet across Ayatana projects. Thanks, Ted [1] http://bazaar.launchpad.net/~ted/indicator-session/ellipsis-test/view/head:/Makefile.am#L39 signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~ayatana-dev Post to : ayatana-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-dev More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-session/gsettings-port into lp:indicator-session
Ted Gould has proposed merging lp:~ted/indicator-session/gsettings-port into lp:indicator-session. Requested reviews: Conor Curran (cjcurran) For more details, see: https://code.launchpad.net/~ted/indicator-session/gsettings-port/+merge/72254 GSettings port. I've updated the ubuntu branch with this branch so it can be tested easier. -- https://code.launchpad.net/~ted/indicator-session/gsettings-port/+merge/72254 Your team ayatana-commits is subscribed to branch lp:indicator-session. === modified file '.bzrignore' --- .bzrignore 2011-08-10 17:11:27 + +++ .bzrignore 2011-08-19 20:18:25 + @@ -1,6 +1,6 @@ compile m4 -po +po/indicator-session.pot src/libmessaging.la src/libmessaging_la-indicator-messages.lo config.guess.cdbs-orig @@ -199,3 +199,6 @@ modified: .bzrignore src/libsession_la-user-widget.lo +consolekit-seat-client.h +data/com.canonical.indicator.session.gschema.valid +data/com.canonical.indicator.session.gschema.xml === modified file 'configure.ac' --- configure.ac 2011-08-10 18:15:18 + +++ configure.ac 2011-08-19 20:18:25 + @@ -8,6 +8,8 @@ AM_MAINTAINER_MODE +GLIB_GSETTINGS + IT_PROG_INTLTOOL([0.35.0]) AC_ISC_POSIX @@ -89,16 +91,6 @@ AC_SUBST(GTKLOGOUTHELPER_CFLAGS) AC_SUBST(GTKLOGOUTHELPER_LIBS) -AC_PATH_PROG(GCONFTOOL, gconftool-2) -dnl Specify the gconf configuration source, -dnl default to xml::$(sysconfdir)/gconf/gconf.xml.defaults - -AM_GCONF_SOURCE_2 - -PKG_CHECK_MODULES(GCONF, gconf-2.0 = 2.0) -AC_SUBST(GCONF_CFLAGS) -AC_SUBST(GCONF_LIBS) - ### # Check to see if we're local ### === modified file 'data/Makefile.am' --- data/Makefile.am 2011-05-11 22:22:21 + +++ data/Makefile.am 2011-08-19 20:18:25 + @@ -9,37 +9,22 @@ %.service: %.service.in sed -e s|\@libexecdir\@|$(libexecdir)| $ $@ -## -# GConf Schema -## - -schemadir = \ - $(GCONF_SCHEMA_FILE_DIR) - -schema_in_files =\ - indicator-session.schemas.in - -schema_DATA = \ - $(schema_in_files:.schemas.in=.schemas) - @INTLTOOL_SCHEMAS_RULE@ - - -#$(dbus_services_DATA): $(service_in_files) Makefile -# sed -e s|\@libexecdir\@|$(libexecdir)| $ $@ +@INTLTOOL_XML_NOMERGE_RULE@ + +@GSETTINGS_RULES@ +gsettings_SCHEMAS = com.canonical.indicator.session.gschema.xml + +convertdir = $(datadir)/GConf/gsettings +dist_convert_DATA = indicator-session.convert + EXTRA_DIST = \ $(service_in_files) \ - $(schema_in_files) + $(gsettings_SCHEMAS:.xml=.xml.in) + CLEANFILES = \ $(dbus_services_DATA) \ - $(schema_DATA) + $(gsettings_SCHEMAS) -if GCONF_SCHEMAS_INSTALL -install-data-local: - GCONF_CONFIG_SOURCE=$(GCONF_SCHEMA_CONFIG_SOURCE) \ - gconftool-2 --makefile-install-rule $(schema_DATA) -else -install-data-local: -endif === added file 'data/com.canonical.indicator.session.gschema.xml.in' --- data/com.canonical.indicator.session.gschema.xml.in 1970-01-01 00:00:00 + +++ data/com.canonical.indicator.session.gschema.xml.in 2011-08-19 20:18:25 + @@ -0,0 +1,24 @@ +schemalist + schema id=com.canonical.indicator.session path=/apps/indicator-session/ +key name=suppress-logout-restart-shutdown type=b + defaultfalse/default + _summarySuppress the dialog to confirm logout, restart and shutdown action/_summary + _descriptionWhether or not to show confirmation dialogs for logout, restart and shutdown actions./_description +/key +key name=suppress-logout-menuitem type=b + defaultfalse/default + _summaryRemove the Log Out item from the session menu/_summary + _descriptionMakes it so that the logout button doesn't show in the session menu./_description +/key +key name=suppress-restart-menuitem type=b + defaultfalse/default + _summaryRemove the Restart item from the session menu/_summary + _descriptionMakes it so that the restart button doesn't show in the session menu./_description +/key +key name=suppress-shutdown-menuitem type=b + defaultfalse/default + _summaryRemove the shutdown item from the session menu/_summary + _descriptionMakes it so that the shutdown button doesn't show in the session menu./_description +/key + /schema +/schemalist === added file 'data/indicator-session.convert' --- data/indicator-session.convert 1970-01-01 00:00:00 + +++ data/indicator-session.convert 2011-08-19 20:18:25 + @@ -0,0 +1,5 @@ +[com.canonical.indicator.session] +suppress_logout_restart_shutdown = /apps/indicator-session/suppress_logout_restart_shutdown +suppress_logout_menuitem = /apps/indicator-session/suppress_logout_menuitem +suppress_restart_menuitem = /apps/indicator-session/suppress_restart_menuitem +suppress_shutdown_menuitem = /apps/indicator-session/suppress_shutdown_menuitem === removed file 'data/indicator-session.schemas.in' --- data/indicator-session.schemas.in 2010-04-06 21:56:04 + +++ data/indicator-session.schemas.in 1970-01-01 00:00:00 + @@ -1,50
[Ayatana-commits] [Merge] lp:~ted/indicator-session/ellipsis-test into lp:indicator-session
Ted Gould has proposed merging lp:~ted/indicator-session/ellipsis-test into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
For more details, see:
https://code.launchpad.net/~ted/indicator-session/ellipsis-test/+merge/72281
Fix the last set of ellipsis and make a test to stop them from creeping back in.
--
https://code.launchpad.net/~ted/indicator-session/ellipsis-test/+merge/72281
Your team ayatana-commits is subscribed to branch lp:indicator-session.
=== modified file '.bzrignore'
--- .bzrignore 2011-08-10 17:11:27 +
+++ .bzrignore 2011-08-20 03:51:25 +
@@ -38,6 +38,7 @@
gtk-logout-helper
.deps
.libs
+test-ellipsis
src/libsession.la
src/libsession_la-indicator-session.lo
src/status-provider-pidgin-marshal.c
=== modified file 'Makefile.am'
--- Makefile.am 2010-09-21 21:14:43 +
+++ Makefile.am 2011-08-20 03:51:25 +
@@ -33,3 +33,15 @@
else \
echo Failed to generate AUTHORS: not a branch 2; \
fi
+
+TESTS = \
+ test-ellipsis
+
+test-ellipsis: po
+ @echo #!/bin/bash $@
+ @echo (cd po make $(GETTEXT_PACKAGE).pot) $@
+ @echo grep -c -e \^msgid.*\.\.\. po/$(GETTEXT_PACKAGE).pot /dev/null echo \Ellipsis found in user visible strings\ 2 exit 1 $@
+ @echo exit 0 $@
+ @chmod +x $@
+
+CLEANFILES = $(TESTS)
=== modified file 'src/device-menu-mgr.c'
=== modified file 'src/dialog.c'
--- src/dialog.c 2011-08-10 18:10:55 +
+++ src/dialog.c 2011-08-20 03:51:25 +
@@ -53,15 +53,15 @@
they are also going to get a password dialog to do the action. */
static const gchar * button_auth_strings[LOGOUT_DIALOG_TYPE_CNT] = {
/* LOGOUT_DIALOG_LOGOUT, */ NC_(button auth, Log Out),
- /* LOGOUT_DIALOG_RESTART, */ NC_(button auth, Restart...),
- /* LOGOUT_DIALOG_SHUTDOWN, */ NC_(button auth, Shut Down...)
+ /* LOGOUT_DIALOG_RESTART, */ NC_(button auth, Restartâ¦),
+ /* LOGOUT_DIALOG_SHUTDOWN, */ NC_(button auth, Shut Downâ¦)
};
/* TRANSLATORS: This button appears on the logout dialog when
there are updates that require restart. It will do a restart
in place of a log out. */
static const gchar * restart_updates = N_(Restart Instead);
-static const gchar * restart_auth = N_(Restart Instead...);
+static const gchar * restart_auth = N_(Restart Insteadâ¦);
static const gchar * body_logout_update = N_(Some software updates won't apply until the computer next restarts.);
static const gchar * icon_strings[LOGOUT_DIALOG_TYPE_CNT] = {
=== modified file 'src/indicator-session.c'
--- src/indicator-session.c 2011-08-12 12:23:35 +
+++ src/indicator-session.c 2011-08-20 03:51:25 +
@@ -527,7 +527,7 @@
if (variant == NULL || g_variant_get_string(variant, NULL) == NULL ||
g_variant_get_string(variant, NULL)[0] == '\0' || no_name_in_lang) {
-finalstring = _(Switch User...);
+finalstring = _(Switch Userâ¦);
set_ellipsize = FALSE;
}
@@ -554,7 +554,7 @@
gdouble ems = width / pixels_per_em;
g_debug(Username width %fem, ems);
-finalstring = g_strdup_printf(_(Switch From %s...), username);
+finalstring = g_strdup_printf(_(Switch From %sâ¦), username);
if (ems = 20.0f) {
set_ellipsize = TRUE;
} else {
=== modified file 'src/user-menu-mgr.c'
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to : ayatana-commits@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/apt-updates-bug into lp:indicator-session
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/apt-updates-bug/+merge/71348 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/apt-updates-bug into lp:indicator-session
The proposal to merge lp:~cjcurran/indicator-session/apt-updates-bug into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/apt-updates-bug/+merge/71348 -- https://code.launchpad.net/~cjcurran/indicator-session/apt-updates-bug/+merge/71348 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cimi/indicator-messages/fix-draw-gtk3 into lp:indicator-messages
Review: Approve -- https://code.launchpad.net/~cimi/indicator-messages/fix-draw-gtk3/+merge/71919 Your team ayatana-commits is subscribed to branch lp:indicator-messages. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cimi/indicator-messages/fix-draw-gtk3 into lp:indicator-messages
The proposal to merge lp:~cimi/indicator-messages/fix-draw-gtk3 into lp:indicator-messages has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cimi/indicator-messages/fix-draw-gtk3/+merge/71919 -- https://code.launchpad.net/~cimi/indicator-messages/fix-draw-gtk3/+merge/71919 Your team ayatana-commits is subscribed to branch lp:indicator-messages. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/bug-729056 into lp:indicator-datetime
The proposal to merge lp:~jjardon/indicator-datetime/bug-729056 into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/bug-729056/+merge/71680 -- https://code.launchpad.net/~jjardon/indicator-datetime/bug-729056/+merge/71680 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~sbte/indicator-messages/fix-817504 into lp:indicator-messages
The proposal to merge lp:~sbte/indicator-messages/fix-817504 into lp:indicator-messages has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~sbte/indicator-messages/fix-817504/+merge/69775 -- https://code.launchpad.net/~sbte/indicator-messages/fix-817504/+merge/69775 Your team ayatana-commits is subscribed to branch lp:indicator-messages. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/indicator-session/actually-get-sessions into lp:indicator-session
Ted Gould has proposed merging lp:~ted/indicator-session/actually-get-sessions into lp:indicator-session. Requested reviews: Conor Curran (cjcurran) For more details, see: https://code.launchpad.net/~ted/indicator-session/actually-get-sessions/+merge/71950 Makes it so that when we create the seat proxy we check to see if there are any existing sessions. A good idea really! -- https://code.launchpad.net/~ted/indicator-session/actually-get-sessions/+merge/71950 Your team ayatana-commits is subscribed to branch lp:indicator-session. === modified file 'src/Makefile.am' --- src/Makefile.am 2011-07-26 17:23:59 + +++ src/Makefile.am 2011-08-17 21:14:24 + @@ -25,19 +25,26 @@ libsession_la_LIBADD = $(APPLET_LIBS) libsession_la_LDFLAGS = -module -avoid-version -consolekit-manager-client.h: $(srcdir)/consolekit-manager.xml +consolekit-manager-client.h: $(srcdir)/org.freedesktop.ConsoleKit.Manager.xml dbus-binding-tool \ --prefix=_consolekit_manager_client \ --mode=glib-client \ --output=consolekit-manager-client.h \ - $(srcdir)/consolekit-manager.xml - -consolekit-session-client.h: $(srcdir)/consolekit-session.xml + $(srcdir)/org.freedesktop.ConsoleKit.Manager.xml + +consolekit-seat-client.h: $(srcdir)/org.freedesktop.ConsoleKit.Seat.xml + dbus-binding-tool \ + --prefix=_consolekit_seat_client \ + --mode=glib-client \ + --output=consolekit-seat-client.h \ + $(srcdir)/org.freedesktop.ConsoleKit.Seat.xml + +consolekit-session-client.h: $(srcdir)/org.freedesktop.ConsoleKit.Session.xml dbus-binding-tool \ --prefix=_consolekit_session_client \ --mode=glib-client \ --output=consolekit-session-client.h \ - $(srcdir)/consolekit-session.xml + $(srcdir)/org.freedesktop.ConsoleKit.Session.xml display-manager-client.h: $(srcdir)/display-manager.xml dbus-binding-tool \ @@ -143,6 +150,7 @@ BUILT_SOURCES = \ consolekit-manager-client.h \ + consolekit-seat-client.h \ consolekit-session-client.h \ display-manager-client.h \ gen-session-dbus.xml.c \ @@ -152,8 +160,9 @@ accounts-service-user-client.h EXTRA_DIST = \ - consolekit-manager.xml \ - consolekit-session.xml \ + org.freedesktop.ConsoleKit.Manager.xml \ + org.freedesktop.ConsoleKit.Seat.xml \ + org.freedesktop.ConsoleKit.Session.xml \ display-manager.xml \ session-dbus.xml \ upower.xml \ === renamed file 'src/consolekit-manager.xml' = 'src/org.freedesktop.ConsoleKit.Manager.xml' === added file 'src/org.freedesktop.ConsoleKit.Seat.xml' --- src/org.freedesktop.ConsoleKit.Seat.xml 1970-01-01 00:00:00 + +++ src/org.freedesktop.ConsoleKit.Seat.xml 2011-08-17 21:14:24 + @@ -0,0 +1,164 @@ +?xml version=1.0 encoding=UTF-8? +node xmlns:doc=http://www.freedesktop.org/dbus/1.0/doc.dtd; + + interface name=org.freedesktop.ConsoleKit.Seat +doc:doc + doc:description +doc:paraA seat is a collection of sessions and a set of hardware (usually at +least a keyboard and mouse). Only one session may be active on a +seat at a time./doc:para + /doc:description +/doc:doc + +method name=GetId + arg name=sid direction=out type=o +doc:doc + doc:summarySeat ID/doc:summary +/doc:doc + /arg + doc:doc +doc:description + doc:paraReturns the ID for Seat./doc:para +/doc:description + /doc:doc +/method + +method name=GetSessions + arg name=sessions direction=out type=ao +doc:doc + doc:summaryan array of Session IDs/doc:summary +/doc:doc + /arg + doc:doc +doc:description + doc:paraThis gets a list of all the doc:ref type=interface to=SessionSessions/doc:ref + that are currently attached to this seat./doc:para + doc:paraEach Session ID is an D-Bus object path for the object that implements the + doc:ref type=interface to=SessionSession/doc:ref interface./doc:para +/doc:description + /doc:doc +/method + +method name=GetDevices + arg name=devices direction=out type=a(ss) +doc:doc + doc:summaryan array of devices/doc:summary +/doc:doc + /arg + doc:doc +doc:description + doc:paraThis gets a list of all the devices + that are currently associated with this seat./doc:para + doc:paraEach device is an D-Bus structure that represents + the device type and the device id. + /doc:para +/doc:description + /doc:doc +/method + +method name=GetActiveSession + arg name=ssid direction=out type=o +doc:doc + doc:summarySession ID/doc:summary +/doc:doc + /arg + doc:doc +doc:description + doc:paraGets the Session ID that is currently active on this Seat./doc:para + doc:paraReturns NULL if there is no active session./doc:para +/doc:description + /doc:doc +/method + +method name=CanActivateSessions + arg name=can_activate direction=out type
Re: [Ayatana-dev] IdoScaleMenuItem in AppIndicator
On Mon, 2011-08-08 at 19:06 +0300, Romeo Calota wrote: I'm trying to add a slider to an AppIndicator similar to what the Sound Menu has. I've looked trough the code of the Sound Menu and found that I should be using libido-0.1 for that. Here's what I have so far and all I see is a '-' symbol in the menu. I've posted links to the SO and AskUbuntu questions as well as a link to the code. Unfortunately that's not possible today. It's been our intention to support custom menu items in dbusmenu so that you could do anything that your app needed for your application indicator (including using IDO) but I haven't found the time yet to complete it :-/ If that's something that you're interested in working on I'd be happy to share more of my thoughts on it. But, it would be some pretty nasty C hacking. --Ted signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~ayatana-dev Post to : ayatana-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-dev More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-dev] [SOLVED] Re: [Compiz] Unity failing to load
On Tue, 2011-08-02 at 17:02 +1200, Tim Penhey wrote:
function unity-env
{
export PATH=~/staging/bin:$PATH
export XDG_DATA_DIRS=~/staging/share
export LD_LIBRARY_PATH=~/staging/lib:$LD_LIBRARY_PATH
export LD_RUN_PATH=~/staging/lib:$LD_RUN_PATH
export PKG_CONFIG_PATH=~/staging/lib/pkgconfig
export PYTHONPATH=~/staging/lib/python2.7/site-packages
}
Anyone got any clues?
It was suggested that I change the exports to include the existing
directories
when there were some, so this was updated to:
Can I just say that since we're using UDD, it's *super* easy to make new
packages, so you really shouldn't have a staging build for 99.9% of your
testing. No, seriously.
It really is as simple as a merge of your development into the packaging
branch and a bzr builddeb in most cases. You can make it slighly more
complex to track the different tests (then you can switch between them)
by incrementing the packaging revision with dch -i.
Complex scripts with environment variables are a really bad idea. You
never really know what you've got installed at the end of the day, so
you can't report bugs effectively. And the package manager always
ensures you can get back a sane system if things go... less than
perfect :-)
--Ted
signature.asc
Description: This is a digitally signed message part
___
Mailing list: https://launchpad.net/~ayatana-dev
Post to : ayatana-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ayatana-dev
More help : https://help.launchpad.net/ListHelp
Re: [Ayatana] Middle Click Feature For Indicators
On Fri, 2011-08-05 at 20:15 +0200, Jo-Erlend Schinstad wrote: Those are very interesting ideas/proposals. I was actually a little worried when I read about this, but as long as its just a shortcut to the most frequently used menu item provided by an indicator, I think it's ok. However... How do we guarantee that this will be consistent between indicators? If it's only available for system indicators, then I think that creates an inconsistency itself. But if it's also available to appindicators, then how will the middle click action be governed? It is available for application indicators, and it's governed rather simply. The action has to be a visible menu item that is in the menu. If you hide it, it doesn't work. If you remove it, it doesn't work. This way the middle click always remains a power user feature, but not a hidden feature. And machines without middle click will never loose functionality. As far as which item is chosen, I'm happy to let application authors play with that. They know their applications better than I believe we ever will. In the end, I expect that OMG Ubuntu readers will know what every middle click will do and we'll never be able to do a usability study on it because no normal user will ever find it :-) --Ted signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~ayatana Post to : ayatana@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ted/libindicate/gtk3-and-stuff-like-that into lp:libindicate
Okay, updated. -- https://code.launchpad.net/~ted/libindicate/gtk3-and-stuff-like-that/+merge/69173 Your team ayatana-commits is subscribed to branch lp:libindicate. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ted/libindicate/gtk3-and-stuff-like-that into lp:libindicate
Ted Gould has proposed merging lp:~ted/libindicate/gtk3-and-stuff-like-that into lp:libindicate. Requested reviews: Ken VanDine (ken-vandine) For more details, see: https://code.launchpad.net/~ted/libindicate/gtk3-and-stuff-like-that/+merge/69173 Porting this to use GTK3 and having to bump the GTK API version to 0.6 -- https://code.launchpad.net/~ted/libindicate/gtk3-and-stuff-like-that/+merge/69173 Your team ayatana-commits is subscribed to branch lp:libindicate. === modified file 'bindings/python/indicate.override' --- bindings/python/indicate.override 2010-06-02 16:19:59 + +++ bindings/python/indicate.override 2011-07-25 22:14:32 + @@ -328,12 +328,12 @@ Py_INCREF(callback); Py_INCREF(user_data); - indicate_listener_get_property_icon( + indicate_gtk_listener_get_property_icon( INDICATE_LISTENER(self-obj), (IndicateListenerServer *)server-obj, (IndicateListenerIndicator *)indicator-obj, property, -(indicate_listener_get_property_icon_cb)_listener_get_property_cb, +(indicate_gtk_listener_get_property_icon_cb)_listener_get_property_cb, listener_property_cb_data); Py_INCREF(Py_None); === modified file 'configure.ac' --- configure.ac 2011-03-31 18:54:26 + +++ configure.ac 2011-07-25 22:14:32 + @@ -48,10 +48,9 @@ AC_SUBST(LIBINDICATEGTK_AGE) ### -# Dependencies +# Dependencies - GLib ### -GTK_REQUIRED_VERSION=2.12 DBUS_REQUIRED_VERSION=0.76 GLIB_REQUIRED_VERSION=2.18 GIO_REQUIRED_VERSION=2.18 @@ -64,17 +63,45 @@ AC_SUBST(LIBINDICATE_CFLAGS) AC_SUBST(LIBINDICATE_LIBS) +### +# Dependencies - GTK+ +### + +AC_ARG_WITH([gtk], + [AS_HELP_STRING([--with-gtk], +[Which version of gtk to use @:@default=3@:@])], + [], + [with_gtk=3]) + +GTK_REQUIRED_VERSION=2.12 +GTK3_REQUIRED_VERSION=3.0 GDK_PIXBUF_REQUIRED_VERSION=2.12 -PKG_CHECK_MODULES(LIBINDICATEGTK, glib-2.0 = $GLIB_REQUIRED_VERSION - gio-2.0 = $GIO_REQUIRED_VERSION - gdk-pixbuf-2.0 = $GDK_PIXBUF_REQUIRED_VERSION - gtk+-2.0 = $GTK_REQUIRED_VERSION - dbusmenu-glib-0.4 = $DBUSMENU_REQUIRED_VERSION - dbus-glib-1 = $DBUS_REQUIRED_VERSION) +AS_IF([test x$with_gtk = x3], + [PKG_CHECK_MODULES(LIBINDICATEGTK, glib-2.0 = $GLIB_REQUIRED_VERSION +gio-2.0 = $GIO_REQUIRED_VERSION +gdk-pixbuf-2.0 = $GDK_PIXBUF_REQUIRED_VERSION +gtk+-2.0 = $GTK_REQUIRED_VERSION +dbusmenu-glib-0.4 = $DBUSMENU_REQUIRED_VERSION +dbus-glib-1 = $DBUS_REQUIRED_VERSION) + AC_DEFINE(HAVE_GTK3, 1, [whether gtk3 is available]) +], + [test x$with_gtk = x2], + [PKG_CHECK_MODULES(LIBINDICATEGTK, glib-2.0 = $GLIB_REQUIRED_VERSION +gio-2.0 = $GIO_REQUIRED_VERSION +gdk-pixbuf-3.0 +gtk+-3.0 = $GTK3_REQUIRED_VERSION +dbusmenu-glib-0.4 = $DBUSMENU_REQUIRED_VERSION +dbus-glib-1 = $DBUS_REQUIRED_VERSION) +], + [AC_MSG_FAILURE([Value for --with-gtk was neither 2 nor 3])] +) + AC_SUBST(LIBINDICATEGTK_CFLAGS) AC_SUBST(LIBINDICATEGTK_LIBS) +AM_CONDITIONAL(USE_GTK3, [test x$with_gtk = x3]) + ### # GObject Introspection ### @@ -234,7 +261,8 @@ libindicate/Makefile libindicate/indicate-0.5.pc libindicate-gtk/Makefile -libindicate-gtk/indicate-gtk-0.5.pc +libindicate-gtk/indicate-gtk-0.6.pc +libindicate-gtk/indicate-gtk3-0.6.pc examples/Makefile examples/indicator-mono-example tests/Makefile @@ -264,4 +292,5 @@ Prefix: $prefix GObject Introspection: $enable_introspection + GTK+ Version: $with_gtk ]) === modified file 'examples/Makefile.am' --- examples/Makefile.am 2010-06-02 16:19:59 + +++ examples/Makefile.am 2011-07-25 22:14:32 + @@ -1,3 +1,9 @@ +if USE_GTK3 +VER=3 +else +VER= +endif + ASSEMBLY = IndicatorMonoExample.exe CSFILES = IndicatorMonoExample.cs CLEANFILES = $(ASSEMBLY) @@ -44,7 +50,7 @@ listen_and_print_LDADD = \ ../libindicate/libindicate.la \ - ../libindicate-gtk/libindicate-gtk.la \ + ../libindicate-gtk/libindicate-gtk$(VER).la \ $(LIBINDICATE_LIBS) \ $(LIBINDICATEGTK_LIBS) @@ -59,7 +65,7 @@ im_client_LDADD = \ ../libindicate/libindicate.la \ - ../libindicate-gtk/libindicate-gtk.la \ + ../libindicate-gtk/libindicate-gtk$(VER).la \ $(LIBINDICATE_LIBS) \ $(LIBINDICATEGTK_LIBS) === modified file 'examples/im-client.c' --- examples/im-client.c 2010-02
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/suspend-updates-in-progress into lp:indicator-session
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/suspend-updates-in-progress/+merge/68854 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~chrisccoulson/indicator-messages/dont-hardcode-evolution into lp:indicator-messages
I fixed a couple of little things including putting found as a condition for the for loop and using the G_N_ELEMENTS() macro. Then merged. Also, do you think we could do this for the other items in the menu at the distro level. Define types for them so people could set default IM and broadcast message apps? -- https://code.launchpad.net/~chrisccoulson/indicator-messages/dont-hardcode-evolution/+merge/68741 Your team ayatana-commits is subscribed to branch lp:indicator-messages. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/split-out-users into lp:indicator-session
The proposal to merge lp:~cjcurran/indicator-session/split-out-users into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/split-out-users/+merge/68110 -- https://code.launchpad.net/~cjcurran/indicator-session/split-out-users/+merge/68110 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/split-out-session into lp:indicator-session
Review: Approve Just a couple of comments that should be deletes. 726 +//#include gconf-helper.h 737 +//#include lock-helper.h -- https://code.launchpad.net/~cjcurran/indicator-session/split-out-session/+merge/68282 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-dev] libindicator API break
Hello, With the help of Trevino we've now dropped the multiple scroll signals in libindicator. This is a good thing, but it's forced an API break for libindicator. So those who are depending on it you'll need to use the 0.4 version of the API here shortly. No major change, just make sure you're using the right scroll function, I think that Trevino has provided patches for most of the users. Also, while I was breaking things I added a name hint to the entry object. This will be used so that the panel can identify the individual indicators in case it wants to do something special with them. --Ted ___ Mailing list: https://launchpad.net/~ayatana-dev Post to : ayatana-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-dev More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/remove_about_me into lp:indicator-me
The proposal to merge lp:~ken-vandine/indicator-me/remove_about_me into lp:indicator-me has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/indicator-me/remove_about_me/+merge/66023 -- https://code.launchpad.net/~ken-vandine/indicator-me/remove_about_me/+merge/66023 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/remove_about_me into lp:indicator-me
Review: Approve -- https://code.launchpad.net/~ken-vandine/indicator-me/remove_about_me/+merge/66023 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/gtk3 into lp:indicator-me
Review: Approve -- https://code.launchpad.net/~ken-vandine/indicator-me/gtk3/+merge/65543 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-dev] Unity Trunk Changes
On Thu, 2011-06-09 at 14:46 +0100, Neil Jagdish Patel wrote: **NOTE** I'd really like it if we used the --author flag when we merge branches for other people i.e.: bzr commit -msome applications always start with maximized windows --author=Marco Biscaro marcobiscaro2...@gmail.com I'd say that this needs to go from I'd like to you really need to as it explains who the creator of the code is. That person deserves credit but also if there were any legal issues there'd be a way to figure out who wrote it. --Ted signature.asc Description: This is a digitally signed message part ___ Mailing list: https://launchpad.net/~ayatana-dev Post to : ayatana-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-dev More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-session/gtk3 into lp:indicator-session
Review: Approve -- https://code.launchpad.net/~mterry/indicator-session/gtk3/+merge/62515 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~mterry/indicator-session/gtk3 into lp:indicator-session
The proposal to merge lp:~mterry/indicator-session/gtk3 into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mterry/indicator-session/gtk3/+merge/62515 -- https://code.launchpad.net/~mterry/indicator-session/gtk3/+merge/62515 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~sargentd/indicator-datetime/fix-spelling into lp:indicator-datetime
Review: Approve Wow, I'm a little scared that Lintian can catch spelling errors. Does not bode well for any software I write getting packaged for Debian/Ubuntu ;-) -- https://code.launchpad.net/~sargentd/indicator-datetime/fix-spelling/+merge/63499 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/gsettings into lp:indicator-me
The proposal to merge lp:~ken-vandine/indicator-me/gsettings into lp:indicator-me has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~ken-vandine/indicator-me/gsettings/+merge/58065 -- https://code.launchpad.net/~ken-vandine/indicator-me/gsettings/+merge/58065 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/gsettings into lp:indicator-me
The proposal to merge lp:~ken-vandine/indicator-me/gsettings into lp:indicator-me has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/indicator-me/gsettings/+merge/58065 -- https://code.launchpad.net/~ken-vandine/indicator-me/gsettings/+merge/58065 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/gsettings into lp:indicator-me
Review: Approve Looks good. -- https://code.launchpad.net/~ken-vandine/indicator-me/gsettings/+merge/58065 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to : ayatana-commits@lists.launchpad.net Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
