Re: [BackupPC-users] BUG & SOLUTION: Can't call method "getStats" on
On 2013-10-31 18:53, backu...@kosowsky.org wrote: > backu...@kosowsky.org wrote at about 21:08:33 -0400 on Thursday, > October 31, 2013: > > From: Rob Sheldon -2013-11-01 00:13 > > > Just ran into the bug described back in 2011 by Jeffrey > > > > Has the simple bug code fix that I suggested back in 2011 ever been > > implemented? > > To answer my own question, no it hasn't -- at least as of > BackupPC-3.3.0 And FYI, it does still seem to fix the problem on 3.3.0. Everything worked fine after I made that change. - R. -- [__ Robert Sheldon [__ No Problem [__ Information technology support and services [__ (530) 575-0278 -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk ___ BackupPC-users mailing list BackupPC-users@lists.sourceforge.net List:https://lists.sourceforge.net/lists/listinfo/backuppc-users Wiki:http://backuppc.wiki.sourceforge.net Project: http://backuppc.sourceforge.net/
Re: [BackupPC-users] BUG & SOLUTION: Can't call method "getStats" on
backu...@kosowsky.org wrote at about 21:08:33 -0400 on Thursday, October 31,
2013:
> From: Rob Sheldon - 2013-11-01 00:13
> > Just ran into the bug described back in 2011 by Jeffrey
> > (http://sourceforge.net/mailarchive/forum.php?thread_name=20017.43110.617411.92113%40consult.pretender&forum_name=backuppc-users).
> >
> > I had to reinstall BackupPC after an OS upgrade broke it (*sigh*)
> > and my quick glance at the situation matches Jeff's.
>
> Has the simple bug code fix that I suggested back in 2011 ever been
> implemented?
To answer my own question, no it hasn't -- at least as of
BackupPC-3.3.0
Hello Craig?
Here is the diff...
--- BackupPC_dump.orig 2013-10-31 21:51:57.269388705 -0400
+++ BackupPC_dump.new 2013-10-31 21:52:30.291387541 -0400
@@ -1156,7 +1156,7 @@
# only keep this backup if it has more files than the previous
# partial.
#
-if ( $type eq "full" ) {
+if ( $type eq "full" && defined($xfer)) {
if ( $nFilesTotal == 0 && $xfer->getStats->{fileCnt} == 0 ) {
#
# Xfer didn't report any files, but check in the new
--
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
___
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List:https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/
Re: [BackupPC-users] BUG & SOLUTION: Can't call method "getStats" on
From: Rob Sheldon - 2013-11-01 00:13 > Just ran into the bug described back in 2011 by Jeffrey > (http://sourceforge.net/mailarchive/forum.php?thread_name=20017.43110.617411.92113%40consult.pretender&forum_name=backuppc-users). > > I had to reinstall BackupPC after an OS upgrade broke it (*sigh*) > and my quick glance at the situation matches Jeff's. Has the simple bug code fix that I suggested back in 2011 ever been implemented? -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk ___ BackupPC-users mailing list BackupPC-users@lists.sourceforge.net List:https://lists.sourceforge.net/lists/listinfo/backuppc-users Wiki:http://backuppc.wiki.sourceforge.net Project: http://backuppc.sourceforge.net/
Re: [BackupPC-users] BUG & SOLUTION: Can't call method "getStats" on an undefined value
Just ran into the bug described back in 2011 by Jeffrey (http://sourceforge.net/mailarchive/forum.php?thread_name=20017.43110.617411.92113%40consult.pretender&forum_name=backuppc-users). I had to reinstall BackupPC after an OS upgrade broke it (*sigh*) and my quick glance at the situation matches Jeff's. Just a heads-up. Thanks, - R. -- [__ Robert Sheldon [__ No Problem [__ Information technology support and services [__ (530) 575-0278 -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators. Download this white paper to learn more about secure code signing practices that can help keep Android apps secure. http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk ___ BackupPC-users mailing list BackupPC-users@lists.sourceforge.net List:https://lists.sourceforge.net/lists/listinfo/backuppc-users Wiki:http://backuppc.wiki.sourceforge.net Project: http://backuppc.sourceforge.net/
Re: [BackupPC-users] BUG & SOLUTION: Can't call method "getStats" on an undefined value
Gail Hardmann wrote at about 12:24:00 +0300 on Saturday, October 1, 2011: > [BackupPC-users] BUG & SOLUTION: Can't call method "getStats" on an > undefined value > Jeffrey: I have encountered exactly the same problem. Thank you for your > bug solution. > > I am trying to run BackupPC on a DNS-323 NAS machine (it's a linux ARM > machine) usinf Rsync and an rsync daemon. > > But firstly, it seems to me I need to solve the famous "File::RsyncP - > module doesn't exist" problem, which crops up here. (BTW, can you direct me > to a good link in that respect)? > I have run BackupPC on a DNS-323 but I actually run it under debian -- if you look on the DNS-323 forum, you can see that I have posted on how one can reboot the machine into a debian kernel (not just a change root although that would work too). You can then use standard debian BackupPC packages. Note, however, that I found (and fixed) two bugs (in md5sum due to 32-bit alignment issues and also one in the Adler32 checksum computation in File::RsyncP) -- see the archives for the fixes. I would imagine that these bugs would also occur in the "native" DNS-323 kernel versions. The bugs are not fatal and don't destroy data but they do give the wrong md5sum names and checksums. -- All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 ___ BackupPC-users mailing list BackupPC-users@lists.sourceforge.net List:https://lists.sourceforge.net/lists/listinfo/backuppc-users Wiki:http://backuppc.wiki.sourceforge.net Project: http://backuppc.sourceforge.net/
[BackupPC-users] BUG & SOLUTION: Can't call method "getStats" on an undefined value
Whenever you are doing a full backup and DumpPreShareCmd fails, I get the
following error in my log:
Can't call method "getStats" on an undefined value at
/usr/share/BackupPC/bin/BackupPC_dump line 1160.
I posted a similar bug report back in December, but now I believe I
have figured out the problem.
IF DumpPreShareCmd or DumpPreUserCmd fails, then the routine
BackupFailCleanup is called. In the case of a *full* backup, the
routine checks to see if there is a partial backup that needs to be
saved. In particular, the following 'if' statement (line 1160) is
executed:
if ( $nFilesTotal == 0 && $xfer->getStats->{fileCnt} == 0 ) {
This gives the above error since $xfer is only defined *after* the pre
commands are executed and hence remains undefined when a pre command
fails.
A potential solution would be to change line 1159 from:
if ( $type eq "full" ) {
To
if ( $type eq "full" && defined($xfer)) {
I am actually surprised that no one else has encountered this bug
since it should be rather common since if my analysis is correct then
it will occur *every* time one of the pre user commands fails on a full
backup.
--
Got Input? Slashdot Needs You.
Take our quick survey online. Come on, we don't ask for help often.
Plus, you'll get a chance to win $100 to spend on ThinkGeek.
http://p.sf.net/sfu/slashdot-survey
___
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List:https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/
