Re: [BackupPC-users] Odd 'unexpected repeated share name error'
On Sun, Feb 14, 2010 at 01:39:23PM -0800, Craig Barratt wrote:
> If you want to try the two fixes, here's a patch against 3.2.0beta1
> (note: I haven't tested this yet - just did this sitting on a plane).
>
> Craig
>
> --- bin/BackupPC_dump 2010-01-24 17:30:43.0 -0800
> +++ bin/BackupPC_dump 2010-02-14 12:02:14.859375000 -0800
> @@ -623,6 +623,7 @@
> #
> # Now backup each of the shares
> #
> +my $shareDuplicate = {};
> for my $shareName ( @$ShareNames ) {
> local(*RH, *WH);
>
> @@ -632,11 +633,17 @@
> $shareName = encode("utf8", $shareName);
> $stat{xferOK} = $stat{hostAbort} = undef;
> $stat{hostError} = $stat{lastOutputLine} = undef;
> -if ( -d "$Dir/new/$shareName" ) {
> +if ( $shareName eq "" ) {
> +print(LOG $bpc->timeStamp,
> + "unexpected empty share name skipped\n");
> +next;
> +}
> +if ( $shareDuplicate->{$shareName} ) {
> print(LOG $bpc->timeStamp,
>"unexpected repeated share name $shareName skipped\n");
> next;
> }
> +$shareDuplicate->{$shareName} = 1;
>
> UserCommandRun("DumpPreShareCmd", $shareName);
> if ( $? && $Conf{UserCmdCheckStatus} ) {
> @@ -915,6 +922,10 @@
> #
> last;
> }
> +#
> +# Wait for any child processes to exit
> +#
> +1 while ( wait() >= 0 );
> }
>
> #
I hand applied the zombie fix around line 915 and that resulted in all
the backups reporting:
2010-02-18 14:25:57 DumpPreShareCmd returned error status -1... exiting
I rolled back the change. Any ideas?
--
-- rouilj
John Rouillard System Administrator
Renesys Corporation 603-244-9084 (cell) 603-643-9300 x 111
--
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
___
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List:https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/
Re: [BackupPC-users] Odd 'unexpected repeated share name error'
John writes:
> The reason for the current layout is to allow the existing critical
> backups to complete even if it takes days to backup the newer shares
> (filesystems). So it's a temporary thing, but I could see somebody
> wanting to put /home first to prioritize it's backup over say /.
> Is the bug going to be fixed for the beta3 or final release?
Yes.
> Also on another topic, is the elimination of zombie processes on the
> todo list for the 3.2 release?
Yes.
If you want to try the two fixes, here's a patch against 3.2.0beta1
(note: I haven't tested this yet - just did this sitting on a plane).
Craig
--- bin/BackupPC_dump 2010-01-24 17:30:43.0 -0800
+++ bin/BackupPC_dump 2010-02-14 12:02:14.859375000 -0800
@@ -623,6 +623,7 @@
#
# Now backup each of the shares
#
+my $shareDuplicate = {};
for my $shareName ( @$ShareNames ) {
local(*RH, *WH);
@@ -632,11 +633,17 @@
$shareName = encode("utf8", $shareName);
$stat{xferOK} = $stat{hostAbort} = undef;
$stat{hostError} = $stat{lastOutputLine} = undef;
-if ( -d "$Dir/new/$shareName" ) {
+if ( $shareName eq "" ) {
+print(LOG $bpc->timeStamp,
+ "unexpected empty share name skipped\n");
+next;
+}
+if ( $shareDuplicate->{$shareName} ) {
print(LOG $bpc->timeStamp,
"unexpected repeated share name $shareName skipped\n");
next;
}
+$shareDuplicate->{$shareName} = 1;
UserCommandRun("DumpPreShareCmd", $shareName);
if ( $? && $Conf{UserCmdCheckStatus} ) {
@@ -915,6 +922,10 @@
#
last;
}
+#
+# Wait for any child processes to exit
+#
+1 while ( wait() >= 0 );
}
#
--
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
___
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List:https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/
Re: [BackupPC-users] Odd 'unexpected repeated share name error'
On Fri, Feb 12, 2010 at 01:44:56PM -0800, Craig Barratt wrote: > John writes: > > > 2010-02-12 18:34:33 unexpected repeated share name / skipped > > It's a bug (also reported by Tim Connors) that I meant to fix > in 3.2.0beta1 but somehow overlooked. > > As a workaround, try putting "/" first in the list. The reason for the current layout is to allow the existing critical backups to complete even if it takes days to backup the newer shares (filesystems). So it's a temporary thing, but I could see somebody wanting to put /home first to prioritize it's backup over say /. Is the bug going to be fixed for the beta3 or final release? Also on another topic, is the elimination of zombie processes on the todo list for the 3.2 release? Thanks for the workaround. -- -- rouilj John Rouillard System Administrator Renesys Corporation 603-244-9084 (cell) 603-643-9300 x 111 -- SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev ___ BackupPC-users mailing list BackupPC-users@lists.sourceforge.net List:https://lists.sourceforge.net/lists/listinfo/backuppc-users Wiki:http://backuppc.wiki.sourceforge.net Project: http://backuppc.sourceforge.net/
Re: [BackupPC-users] Odd 'unexpected repeated share name error'
John writes: > 2010-02-12 18:34:33 unexpected repeated share name / skipped It's a bug (also reported by Tim Connors) that I meant to fix in 3.2.0beta1 but somehow overlooked. As a workaround, try putting "/" first in the list. Craig -- SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev ___ BackupPC-users mailing list BackupPC-users@lists.sourceforge.net List:https://lists.sourceforge.net/lists/listinfo/backuppc-users Wiki:http://backuppc.wiki.sourceforge.net Project: http://backuppc.sourceforge.net/
[BackupPC-users] Odd 'unexpected repeated share name error'
Hi all. I am backing up a system with the following pc/host.pl file:
$Conf{RsyncShareName} = [
'/etc',
'/var/bak',
'/var/log',
'/usr/local',
'/home/opssvn/backups',
'/home/svn/backups',
'/',
'/usr',
'/home',
'/var',
'/boot',
];
and here is what the backup log looks like:
2010-02-12 16:16:35 full backup started for directory /etc; updating
partial #307
2010-02-12 16:47:19 full backup started for directory /var/bak;
updating partial #307
2010-02-12 17:23:22 full backup started for directory /var/log;
updating partial #307
2010-02-12 17:58:34 full backup started for directory /usr/local;
updating partial #307
2010-02-12 17:58:37 full backup started for directory
/home/opssvn/backups; updating partial #307
2010-02-12 18:08:28 full backup started for directory
/home/svn/backups; updating partial #307
2010-02-12 18:34:33 unexpected repeated share name / skipped
2010-02-12 18:34:33 full backup started for directory /usr; updating
partial #307
2010-02-12 19:07:35 full backup started for directory /home; updating
partial #307
[...]
Except for the:
2010-02-12 18:34:33 unexpected repeated share name / skipped
this all looks normal and expected. Does anybody have any idea what is
happening with the / share? I don't see a repeated '/' share in my
spec for $Conf{RsyncShareName}.
Thanks.
--
-- rouilj
John Rouillard System Administrator
Renesys Corporation 603-244-9084 (cell) 603-643-9300 x 111
--
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
___
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List:https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/
