Re: [PATCH 7/7] commands: Add mdio_read and mdio_write
On Tue, Jan 26, 2016 at 06:09:00PM -0800, Andrey Smirnov wrote: > On Tue, Jan 26, 2016 at 1:55 PM, Sascha Hauer wrote: > > On Mon, Jan 25, 2016 at 09:55:58PM -0800, Andrey Smirnov wrote: > >> Add commands for low-level access to MDIO bus. > > > > Do we really need this? We can already read/write phy registers using > > /dev/phyx which imo is quite convenient since it can be accessed with > > regular md/mw commands. > > > > This of course is currently limited to the phys that are actually > > registered, you can't just bang on MDIO addresses on which no phys are > > registered. Maybe we could register all phys on a MDIO bus instead of > > only the used ones? > > Just to explain the purpose of this patch -- there are number of > reasons we might want to be able to access "unregistered" PHYs: > > - Not all MDIO attached devices would have PHYSID1,2 registers > available which might cause mdiobus_scan() to not detect those PHYs > > - MDIO bus troubleshooting > > As for registering all PHYs on a bus, correct me if I am wrong but > that would result in 32*N number of entries in /dev, where N is number > of MDIO buses in the system. The device I am working with right now > has 3 MDIO buses which would mean that I'd end up with 96 additional > entries in /dev, which might be a little bit overwhelming from UI > point of view. The other UI problem with that approach is that > /dev/phy's are numbered linearly so in order to figure out how to > access device on bus N at address M, user would have to perform N*32 + > M in their head. We could register the phys with name like: "mdio%d-phy%02x", dev->bus->dev.id, mdev->addr That would make it clear which phy belongs to which bus. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 7/7] commands: Add mdio_read and mdio_write
On Wed, Jan 27, 2016 at 02:29:47AM +, Trent Piepho wrote: > On Tue, 2016-01-26 at 18:09 -0800, Andrey Smirnov wrote: > > On Tue, Jan 26, 2016 at 1:55 PM, Sascha Hauer > > wrote: > > > On Mon, Jan 25, 2016 at 09:55:58PM -0800, Andrey Smirnov wrote: > > >> Add commands for low-level access to MDIO bus. > > > > > > Do we really need this? We can already read/write phy registers using > > > /dev/phyx which imo is quite convenient since it can be accessed with > > > regular md/mw commands. > > > > > > Just to explain the purpose of this patch -- there are number of > > reasons we might want to be able to access "unregistered" PHYs: > > > > - Not all MDIO attached devices would have PHYSID1,2 registers > > available which might cause mdiobus_scan() to not detect those PHYs > > > > - MDIO bus troubleshooting > > Maybe instead have a command that adds a phydev to a mdio bus? Or maybe even add an option to the existing miitool to do that. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 7/7] commands: Add mdio_read and mdio_write
On Tue, 2016-01-26 at 18:09 -0800, Andrey Smirnov wrote: > On Tue, Jan 26, 2016 at 1:55 PM, Sascha Hauer wrote: > > On Mon, Jan 25, 2016 at 09:55:58PM -0800, Andrey Smirnov wrote: > >> Add commands for low-level access to MDIO bus. > > > > Do we really need this? We can already read/write phy registers using > > /dev/phyx which imo is quite convenient since it can be accessed with > > regular md/mw commands. > > > Just to explain the purpose of this patch -- there are number of > reasons we might want to be able to access "unregistered" PHYs: > > - Not all MDIO attached devices would have PHYSID1,2 registers > available which might cause mdiobus_scan() to not detect those PHYs > > - MDIO bus troubleshooting Maybe instead have a command that adds a phydev to a mdio bus? So if you wanted to issue commands to some address that doesn't have a phy detected you could add a dummy phy using this command and then use standard md/mw and so on commands with it. There is still a new command but it does not have to duplicate existing functionality this way. ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 7/7] commands: Add mdio_read and mdio_write
On Tue, Jan 26, 2016 at 1:55 PM, Sascha Hauer wrote: > On Mon, Jan 25, 2016 at 09:55:58PM -0800, Andrey Smirnov wrote: >> Add commands for low-level access to MDIO bus. > > Do we really need this? We can already read/write phy registers using > /dev/phyx which imo is quite convenient since it can be accessed with > regular md/mw commands. > > This of course is currently limited to the phys that are actually > registered, you can't just bang on MDIO addresses on which no phys are > registered. Maybe we could register all phys on a MDIO bus instead of > only the used ones? Just to explain the purpose of this patch -- there are number of reasons we might want to be able to access "unregistered" PHYs: - Not all MDIO attached devices would have PHYSID1,2 registers available which might cause mdiobus_scan() to not detect those PHYs - MDIO bus troubleshooting As for registering all PHYs on a bus, correct me if I am wrong but that would result in 32*N number of entries in /dev, where N is number of MDIO buses in the system. The device I am working with right now has 3 MDIO buses which would mean that I'd end up with 96 additional entries in /dev, which might be a little bit overwhelming from UI point of view. The other UI problem with that approach is that /dev/phy's are numbered linearly so in order to figure out how to access device on bus N at address M, user would have to perform N*32 + M in their head. Andrey ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/3] fs: move struct timespec to include/linux/time.h
On Tue, Jan 26, 2016 at 11:38:35AM +0100, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > Signed-off-by: Yegor Yefremov > --- > fs/ubifs/ubifs.h | 7 --- > include/linux/time.h | 5 + > 2 files changed, 5 insertions(+), 7 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 7/7] commands: Add mdio_read and mdio_write
On Mon, Jan 25, 2016 at 09:55:58PM -0800, Andrey Smirnov wrote: > Add commands for low-level access to MDIO bus. Do we really need this? We can already read/write phy registers using /dev/phyx which imo is quite convenient since it can be accessed with regular md/mw commands. This of course is currently limited to the phys that are actually registered, you can't just bang on MDIO addresses on which no phys are registered. Maybe we could register all phys on a MDIO bus instead of only the used ones? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: Linux headers
Hi Yegor, On Tue, Jan 26, 2016 at 04:17:39PM +0100, Yegor Yefremov wrote: > AFAIK include/linux/barebox-wrapper.h was introduced to simplify Linux > driver porting. During my current effort to port SquashFS driver I had > to repeatedly remove such includes like: > > #include > #include > #include > #include > #include > #include > > and so on. > > Would it be better to provide such headers even if they would almost > always include dummy code? Though it would pollute the include folder > somehow, but it will be easier to port/sync Linux drivers and it will > help to preserve the structure of this drivers. > > What do you think about this? What would you add to these header files? I mean for spinlock.h it's clear, it would contain dummy spinlocks. For other files I'm not sure how much useful stuff we can put in there. For example wait.h contains much stuff that - when it's used in the code you are porting - cannot simply be replaced with dummy code but must be handled somehow. So if we create the Linux header files there should be more gain than only the ability to keep the include list untouched. I don't know for how many files this is the case. Porting over Linux code to barebox is often a balancing act. We can put much effort into creating header files which make it possible to (almost) blindly copy over code or we can keenly modify the Linux code to fit into barebox. One extreme leads to easily portable but probably inefficient code, the other leads to hard to update but probably better understandable code. The truth is probably somewhere between both extremes. Anyway, to put it short, I think it makes sense to at least move the stuff we already have in barebox-wrapper.h to their original places. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] bootm: add missing curly brace
On Tue, Jan 26, 2016 at 10:55:07AM +0100, yegorsli...@googlemail.com wrote:
> From: Yegor Yefremov
>
> Signed-off-by: Yegor Yefremov
> ---
> common/bootm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Squashed into the original commit breaking it.
Sascha
>
> diff --git a/common/bootm.c b/common/bootm.c
> index 7e7d2a9..79833e0 100644
> --- a/common/bootm.c
> +++ b/common/bootm.c
> @@ -528,7 +528,7 @@ int bootm_boot(struct bootm_data *bootm_data)
> goto err_out;
> }
>
> - if (IS_ENABLED(CONFIG_BOOTM_FORCE_SIGNED_IMAGES))
> + if (IS_ENABLED(CONFIG_BOOTM_FORCE_SIGNED_IMAGES)) {
> data->verify = BOOTM_VERIFY_SIGNATURE;
>
> /*
> --
> 2.1.4
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
Linux headers
AFAIK include/linux/barebox-wrapper.h was introduced to simplify Linux driver porting. During my current effort to port SquashFS driver I had to repeatedly remove such includes like: #include #include #include #include #include #include and so on. Would it be better to provide such headers even if they would almost always include dummy code? Though it would pollute the include folder somehow, but it will be easier to port/sync Linux drivers and it will help to preserve the structure of this drivers. What do you think about this? Yegor ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: scripts/remote: make clean leftovers
On Di, 2016-01-26 at 11:04 +0100, Yegor Yefremov wrote: > After performing make distclean I've discovered following files being removed: > > Changes not staged for commit: > (use "git add/rm ..." to update what will be committed) > (use "git checkout -- ..." to discard changes in working directory) > > deleted:scripts/remote/__init__.py > deleted:scripts/serial/tools/__init__.py > deleted:scripts/serial/urlhandler/__init__.py > > What should actually happen to these files? Python uses these files to recognize the directory as containing a module, so we need to keep them. Regards, Jan -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH 2/3] fs: introduce include/linux/fs.h
From: Yegor Yefremov
Move Linux file system structs from UBIFS to central place.
Signed-off-by: Yegor Yefremov
---
fs/ubifs/ubifs.h | 128 +--
include/linux/fs.h | 133 +
2 files changed, 134 insertions(+), 127 deletions(-)
create mode 100644 include/linux/fs.h
diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h
index 6b7139c..2d0cd4c 100644
--- a/fs/ubifs/ubifs.h
+++ b/fs/ubifs/ubifs.h
@@ -34,8 +34,8 @@
#include
#include
#include
+#include
#include
-#include
#include
#include
#include
@@ -92,132 +92,6 @@ struct qstr {
const char *name;
};
-struct inode {
- struct hlist_node i_hash;
- struct list_headi_list;
- struct list_headi_sb_list;
- struct list_headi_dentry;
- unsigned long i_ino;
- unsigned inti_nlink;
- uid_t i_uid;
- gid_t i_gid;
- dev_t i_rdev;
- u64 i_version;
- loff_t i_size;
-#ifdef __NEED_I_SIZE_ORDERED
- seqcount_t i_size_seqcount;
-#endif
- struct timespec i_atime;
- struct timespec i_mtime;
- struct timespec i_ctime;
- unsigned inti_blkbits;
- unsigned short i_bytes;
- umode_t i_mode;
- spinlock_t i_lock; /* i_blocks, i_bytes, maybe i_size */
- struct mutexi_mutex;
- struct rw_semaphore i_alloc_sem;
- const struct inode_operations *i_op;
- const struct file_operations*i_fop; /* former
->i_op->default_file_ops */
- struct super_block *i_sb;
- struct file_lock*i_flock;
-#ifdef CONFIG_QUOTA
- struct dquot*i_dquot[MAXQUOTAS];
-#endif
- struct list_headi_devices;
- int i_cindex;
-
- __u32 i_generation;
-
-#ifdef CONFIG_DNOTIFY
- unsigned long i_dnotify_mask; /* Directory notify events */
- struct dnotify_struct *i_dnotify; /* for directory notifications */
-#endif
-
-#ifdef CONFIG_INOTIFY
- struct list_headinotify_watches; /* watches on this inode */
- struct mutexinotify_mutex; /* protects the watches list */
-#endif
-
- unsigned long i_state;
- unsigned long dirtied_when; /* jiffies of first dirtying */
-
- unsigned inti_flags;
-
-#ifdef CONFIG_SECURITY
- void*i_security;
-#endif
- void*i_private; /* fs or device private pointer */
-};
-
-struct super_block {
- struct list_heads_list; /* Keep this first */
- dev_t s_dev; /* search index; _not_ kdev_t */
- unsigned long s_blocksize;
- unsigned char s_blocksize_bits;
- unsigned char s_dirt;
- unsigned long long s_maxbytes; /* Max file size */
- struct file_system_type *s_type;
- const struct super_operations *s_op;
- struct dquot_operations *dq_op;
- struct quotactl_ops *s_qcop;
- const struct export_operations *s_export_op;
- unsigned long s_flags;
- unsigned long s_magic;
- struct dentry *s_root;
- struct rw_semaphore s_umount;
- struct mutexs_lock;
- int s_count;
- int s_syncing;
- int s_need_sync_fs;
-#ifdef CONFIG_SECURITY
- void*s_security;
-#endif
- struct xattr_handler**s_xattr;
-
- struct list_heads_inodes; /* all inodes */
- struct list_heads_dirty;/* dirty inodes */
- struct list_heads_io; /* parked for writeback */
- struct list_heads_more_io; /* parked for more writeback */
- struct hlist_head s_anon; /* anonymous dentries for (nfs)
exporting */
- struct list_heads_files;
- /* s_dentry_lru and s_nr_dentry_unused are protected by dcache_lock */
- struct list_heads_dentry_lru; /* unused dentry lru */
- int s_nr_dentry_unused; /* # of dentry on lru */
-
- struct block_device *s_bdev;
- struct mtd_info *s_mtd;
- struct list_heads_instances;
-
- int s_frozen;
- wait_queue_head_t s_wait_unfrozen;
-
- char s_id[32]; /* Informational name */
-
- void*s_fs_info; /* Filesystem private info */
-
- /*
-* The next field is for VFS *only*. No filesystems have any business
-* even looking at it. You had been
[PATCH 3/3] fs: import magic.h from Linux kernel
From: Yegor Yefremov
include/linux/magic.h provides MAGIC numbers for various
file systems.
Signed-off-by: Yegor Yefremov
---
fs/cramfs/cramfs.c | 1 +
fs/ext4/ext4_common.c | 3 +-
fs/ext4/ext_common.h | 2 --
include/cramfs/cramfs_fs.h | 1 -
include/linux/magic.h | 82 ++
5 files changed, 85 insertions(+), 4 deletions(-)
create mode 100644 include/linux/magic.h
diff --git a/fs/cramfs/cramfs.c b/fs/cramfs/cramfs.c
index 97f028a..988fa7e 100644
--- a/fs/cramfs/cramfs.c
+++ b/fs/cramfs/cramfs.c
@@ -34,6 +34,7 @@
#include
#include
+#include
#include
/* These two macros may change in future, to provide better st_ino
diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c
index 04b1915..590f54d 100644
--- a/fs/ext4/ext4_common.c
+++ b/fs/ext4/ext4_common.c
@@ -32,6 +32,7 @@
#include
#include
#include
+#include
#include
#include
@@ -499,7 +500,7 @@ int ext4fs_mount(struct ext_filesystem *fs)
goto fail;
/* Make sure this is an ext2 filesystem. */
- if (__le16_to_cpu(data->sblock.magic) != EXT2_MAGIC) {
+ if (__le16_to_cpu(data->sblock.magic) != EXT2_SUPER_MAGIC) {
ret = -EINVAL;
goto fail;
}
diff --git a/fs/ext4/ext_common.h b/fs/ext4/ext_common.h
index 517a1c1..704d8e6 100644
--- a/fs/ext4/ext_common.h
+++ b/fs/ext4/ext_common.h
@@ -33,8 +33,6 @@
#define SECTOR_SIZE0x200
#define SECTOR_BITS9
-/* Magic value used to identify an ext2 filesystem. */
-#defineEXT2_MAGIC 0xEF53
/* Amount of indirect blocks in an inode. */
#define INDIRECT_BLOCKS12
/* Maximum lenght of a pathname. */
diff --git a/include/cramfs/cramfs_fs.h b/include/cramfs/cramfs_fs.h
index 8c53fc7..d2b67c5 100644
--- a/include/cramfs/cramfs_fs.h
+++ b/include/cramfs/cramfs_fs.h
@@ -1,7 +1,6 @@
#ifndef __CRAMFS_H
#define __CRAMFS_H
-#define CRAMFS_MAGIC 0x28cd3d45 /* some random number */
#define CRAMFS_SIGNATURE "Compressed ROMFS"
/*
diff --git a/include/linux/magic.h b/include/linux/magic.h
new file mode 100644
index 000..0de181a
--- /dev/null
+++ b/include/linux/magic.h
@@ -0,0 +1,82 @@
+#ifndef __LINUX_MAGIC_H__
+#define __LINUX_MAGIC_H__
+
+#define ADFS_SUPER_MAGIC 0xadf5
+#define AFFS_SUPER_MAGIC 0xadff
+#define AFS_SUPER_MAGIC0x5346414F
+#define AUTOFS_SUPER_MAGIC 0x0187
+#define CODA_SUPER_MAGIC 0x73757245
+#define CRAMFS_MAGIC 0x28cd3d45 /* some random number */
+#define CRAMFS_MAGIC_WEND 0x453dcd28 /* magic number with the wrong
endianess */
+#define DEBUGFS_MAGIC 0x64626720
+#define SECURITYFS_MAGIC 0x73636673
+#define SELINUX_MAGIC 0xf97cff8c
+#define SMACK_MAGIC0x43415d53 /* "SMAC" */
+#define RAMFS_MAGIC0x858458f6 /* some random number */
+#define TMPFS_MAGIC0x01021994
+#define HUGETLBFS_MAGIC0x958458f6 /* some random number */
+#define SQUASHFS_MAGIC 0x73717368
+#define ECRYPTFS_SUPER_MAGIC 0xf15f
+#define EFS_SUPER_MAGIC0x414A53
+#define EXT2_SUPER_MAGIC 0xEF53
+#define EXT3_SUPER_MAGIC 0xEF53
+#define XENFS_SUPER_MAGIC 0xabba1974
+#define EXT4_SUPER_MAGIC 0xEF53
+#define BTRFS_SUPER_MAGIC 0x9123683E
+#define NILFS_SUPER_MAGIC 0x3434
+#define F2FS_SUPER_MAGIC 0xF2F52010
+#define HPFS_SUPER_MAGIC 0xf995e849
+#define ISOFS_SUPER_MAGIC 0x9660
+#define JFFS2_SUPER_MAGIC 0x72b6
+#define PSTOREFS_MAGIC 0x6165676C
+#define EFIVARFS_MAGIC 0xde5e81e4
+#define HOSTFS_SUPER_MAGIC 0x00c0ffee
+#define OVERLAYFS_SUPER_MAGIC 0x794c7630
+
+#define MINIX_SUPER_MAGIC 0x137F /* minix v1 fs, 14 char names */
+#define MINIX_SUPER_MAGIC2 0x138F /* minix v1 fs, 30 char names */
+#define MINIX2_SUPER_MAGIC 0x2468 /* minix v2 fs, 14 char names */
+#define MINIX2_SUPER_MAGIC20x2478 /* minix v2 fs, 30 char names */
+#define MINIX3_SUPER_MAGIC 0x4d5a /* minix v3 fs, 60 char names */
+
+#define MSDOS_SUPER_MAGIC 0x4d44 /* MD */
+#define NCP_SUPER_MAGIC0x564c /* Guess, what 0x564c
is :-) */
+#define NFS_SUPER_MAGIC0x6969
+#define OPENPROM_SUPER_MAGIC 0x9fa1
+#define QNX4_SUPER_MAGIC 0x002f /* qnx4 fs detection */
+#define QNX6_SUPER_MAGIC 0x68191122 /* qnx6 fs detection */
+
+#define REISERFS_SUPER_MAGIC 0x52654973 /* used by gcc */
+ /* used by file system utilities that
+ look at the superblock, etc. */
+#define REISERFS_SUPER_MAGIC_STRING"ReIsErFs"
+#define REISER2FS_SUPER_MAGIC_STRING "ReIsEr2Fs"
+#define REISER2FS_JR_SUPER_MAGIC_STRING"ReIsEr3Fs"
+
+#define SMB_SUPER_MA
[PATCH 1/3] fs: move struct timespec to include/linux/time.h
From: Yegor Yefremov
Signed-off-by: Yegor Yefremov
---
fs/ubifs/ubifs.h | 7 ---
include/linux/time.h | 5 +
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h
index c025d34..6b7139c 100644
--- a/fs/ubifs/ubifs.h
+++ b/fs/ubifs/ubifs.h
@@ -77,13 +77,6 @@ void iput(struct inode *inode);
#define atomic_long_dec(a)
#defineatomic_long_sub(a, b)
-/* linux/include/time.h */
-
-struct timespec {
- time_t tv_sec; /* seconds */
- longtv_nsec;/* nanoseconds */
-};
-
/* linux/include/dcache.h */
/*
diff --git a/include/linux/time.h b/include/linux/time.h
index 3942e82..3a1bb50 100644
--- a/include/linux/time.h
+++ b/include/linux/time.h
@@ -5,4 +5,9 @@
#define NSEC_PER_SEC 10L
+struct timespec {
+ time_t tv_sec; /* seconds */
+ longtv_nsec;/* nanoseconds */
+};
+
#endif
--
2.1.4
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
scripts/remote: make clean leftovers
After performing make distclean I've discovered following files being removed: Changes not staged for commit: (use "git add/rm ..." to update what will be committed) (use "git checkout -- ..." to discard changes in working directory) deleted:scripts/remote/__init__.py deleted:scripts/serial/tools/__init__.py deleted:scripts/serial/urlhandler/__init__.py What should actually happen to these files? Yegor ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH] bootm: add missing curly brace
From: Yegor Yefremov
Signed-off-by: Yegor Yefremov
---
common/bootm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/bootm.c b/common/bootm.c
index 7e7d2a9..79833e0 100644
--- a/common/bootm.c
+++ b/common/bootm.c
@@ -528,7 +528,7 @@ int bootm_boot(struct bootm_data *bootm_data)
goto err_out;
}
- if (IS_ENABLED(CONFIG_BOOTM_FORCE_SIGNED_IMAGES))
+ if (IS_ENABLED(CONFIG_BOOTM_FORCE_SIGNED_IMAGES)) {
data->verify = BOOTM_VERIFY_SIGNATURE;
/*
--
2.1.4
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
