Re: [PATCH 0/4] Some updates for arm/mvebu
On Thu, Sep 15, 2016 at 12:38:13PM +0200, Uwe Kleine-König wrote: > Hello, > > these are the first few patches I did while creating a port for a Netgear > RN2120. > > Best regards > Uwe > > Uwe Kleine-König (4): > ARM: mvebu_defconfig: oldconfig > ARM: mvebu_defconfig: enable all machines, AEABI, nand and net driver > ARM: mvebu: select HAVE_DEFAULT_ENVIRONMENT_NEW > net: mvneta: clean txdesc before usage > > arch/arm/Kconfig | 1 + > arch/arm/configs/mvebu_defconfig | 18 -- > drivers/net/mvneta.c | 1 + > 3 files changed, 14 insertions(+), 6 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] commands: exit on invalid option
On Mon, Sep 12, 2016 at 12:20:56PM +0200, Enrico Jorns wrote: > Barebox commands should not perform any action and return 0 if an > invalid parameter was given. This might cause undetected unintended > behvaior when calling commands with wrong options, either manually or > from a script. > > Signed-off-by: Enrico Jorns Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH v2 1/3] state: copy backend of_path string
On Fri, Sep 16, 2016 at 08:43:38AM +0200, Michael Olbrich wrote:
> Caching pointers to device tree nodes or names is not save. The barebox
> internal device tree may be changed by loading a new device tree or through
> fixup handlers. As a result, the string may be deleted.
> Use local copies of the full path instead.
>
> Signed-off-by: Michael Olbrich
> ---
> Changes since v1:
> - First patch split into two patches
Applied, thanks
Sascha
>
> common/state/backend.c | 3 ++-
> common/state/state.h | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/common/state/backend.c b/common/state/backend.c
> index 2f2e6dfd32d1..5235bb0283dd 100644
> --- a/common/state/backend.c
> +++ b/common/state/backend.c
> @@ -164,7 +164,7 @@ int state_backend_init(struct state_backend *backend,
> struct device_d *dev,
> if (ret)
> goto out_free_format;
>
> - backend->of_path = of_path;
> + backend->of_path = xstrdup(of_path);
>
> return 0;
>
> @@ -185,4 +185,5 @@ void state_backend_free(struct state_backend *backend)
> state_storage_free(&backend->storage);
> if (backend->format)
> state_format_free(backend->format);
> + free(backend->of_path);
> }
> diff --git a/common/state/state.h b/common/state/state.h
> index 32146ca1bbc7..f930d06195b2 100644
> --- a/common/state/state.h
> +++ b/common/state/state.h
> @@ -87,7 +87,7 @@ struct state_backend_storage {
> struct state_backend {
> struct state_backend_format *format;
> struct state_backend_storage storage;
> - const char *of_path;
> + char *of_path;
> };
>
> struct state {
> --
> 2.8.1
>
>
> ___
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/3] ARM: imx6: split out IPU QoS setup
On Thu, Sep 15, 2016 at 01:10:21PM +0200, Lucas Stach wrote:
> Split into separate function and only call it after the chip type
> and revision is known.
>
> Signed-off-by: Lucas Stach
> ---
> arch/arm/mach-imx/imx6.c | 11 +--
> 1 file changed, 9 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/mach-imx/imx6.c b/arch/arm/mach-imx/imx6.c
> index ba8fb8964ac8..07d3f57d8dcc 100644
> --- a/arch/arm/mach-imx/imx6.c
> +++ b/arch/arm/mach-imx/imx6.c
> @@ -31,10 +31,8 @@ void imx6_init_lowlevel(void)
> {
> void __iomem *aips1 = (void *)MX6_AIPS1_ON_BASE_ADDR;
> void __iomem *aips2 = (void *)MX6_AIPS2_ON_BASE_ADDR;
> - void __iomem *iomux = (void *)MX6_IOMUXC_BASE_ADDR;
> bool is_imx6q = __imx6_cpu_type() == IMX6_CPUTYPE_IMX6Q;
> bool is_imx6d = __imx6_cpu_type() == IMX6_CPUTYPE_IMX6D;
> - uint32_t val;
>
> /*
>* Set all MPROTx to be non-bufferable, trusted for R/W,
> @@ -94,6 +92,13 @@ void imx6_init_lowlevel(void)
> MX6_ANATOP_BASE_ADDR + HW_ANADIG_PFD_528_CLR);
> }
>
> +}
> +
> +void imx6_setup_ipu_qos(void)
> +{
> + void __iomem *iomux = (void *)MX6_IOMUXC_BASE_ADDR;
> + uint32_t val;
> +
> val = readl(iomux + IOMUXC_GPR4);
> val |= IMX6Q_GPR4_VPU_WR_CACHE_SEL | IMX6Q_GPR4_VPU_RD_CACHE_SEL |
> IMX6Q_GPR4_VPU_P_WR_CACHE_VAL |
> IMX6Q_GPR4_VPU_P_RD_CACHE_VAL_MASK |
> @@ -186,6 +191,8 @@ int imx6_init(void)
>
> imx_set_silicon_revision(cputypestr, mx6_silicon_revision);
>
> + imx6_setup_ipu_qos();
> +
> return 0;
> }
>
> --
> 2.8.1
>
>
> ___
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] mtd: make sure address-cells/size-cells are set when adding partition nodes
On Thu, Sep 15, 2016 at 08:03:26AM +0200, Michael Olbrich wrote: > address-cells/size-cells can either be set to 1 or 2 for 32 or 63 bit > addresses respectively. Barebox currently writes 32 bit addresses. > This makes sure that address-cells/size-cells are both set and have the > correct value. > > Signed-off-by: Michael Olbrich > --- > > Hi, > > this is just a minor fix. What is really needed it support for 64 bit > addressing. Looking at the code this is already implemented. It already creates the reg property using of_write_number() and honouring of_n_addr_cells() / of_n_size_cells(). This of course only works when the target device tree already has the #address-cells and #size-cells properties with the correct values. So instead of just setting them to hardcoded '1' you should set them to the desired value, the loop below should do the rest correctly. > Also, the bindings documentation says that all partitions > should be in a 'partitions' sub node. The main question here is probably > which kernel version introduced these features and what should be supported > by barebox. The partitions subnode was introduced with 4.4, so we better do not rely on the kernel being able to handle it. What we can and probably should do is to look into the target device tree if it already has a partitions subnode with compatible = "fixed-partitions" and if does, use it. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH v2 1/3] state: copy backend of_path string
On Fri, 16 Sep 2016 08:43:38 +0200 Michael Olbrich wrote: > Caching pointers to device tree nodes or names is not save. The barebox safe? > internal device tree may be changed by loading a new device tree or through > fixup handlers. As a result, the string may be deleted. > Use local copies of the full path instead. > > Signed-off-by: Michael Olbrich -- Best regards, Antony Pavlov ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
