[PATCH] MIPS: Makefile: minor codingstyle fix
From: Du Huanpeng Signed-off-by: Du Huanpeng --- arch/mips/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/mips/Makefile b/arch/mips/Makefile index ee465dc..1c10db5 100644 --- a/arch/mips/Makefile +++ b/arch/mips/Makefile @@ -52,9 +52,7 @@ cflags-$(CONFIG_CPU_MIPS32_R1) += $(call cc-option,-march=mips32,-mips32 -U_MIPS cflags-$(CONFIG_CPU_MIPS32_R2) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap cflags-$(CONFIG_CPU_MIPS64_R1) += $(call cc-option,-march=mips64,-mips64 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64 -Wa,--trap cflags-$(CONFIG_CPU_MIPS64_R2) += $(call cc-option,-march=mips64r2,-mips64r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64r2 -Wa,--trap -cflags-$(CONFIG_CPU_LOONGSON1) += \ - $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \ - -Wa,-mips32r2 -Wa,--trap +cflags-$(CONFIG_CPU_LOONGSON1) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap CPPFLAGS += -DTEXT_BASE=$(CONFIG_TEXT_BASE) -- 2.7.4 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] MIPS: Makefile: minor codingstyle fix
Hi, it is a bit more then just minor codingstyle fix. Can you please describe what was wrong and why the change makes it better. Am 22.11.19 um 09:34 schrieb Du Huanpeng: > From: Du Huanpeng > > Signed-off-by: Du Huanpeng > --- > arch/mips/Makefile | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/mips/Makefile b/arch/mips/Makefile > index ee465dc..1c10db5 100644 > --- a/arch/mips/Makefile > +++ b/arch/mips/Makefile > @@ -52,9 +52,7 @@ cflags-$(CONFIG_CPU_MIPS32_R1) += $(call > cc-option,-march=mips32,-mips32 -U_MIPS > cflags-$(CONFIG_CPU_MIPS32_R2) += $(call cc-option,-march=mips32r2,-mips32r2 > -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap > cflags-$(CONFIG_CPU_MIPS64_R1) += $(call cc-option,-march=mips64,-mips64 > -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64 -Wa,--trap > cflags-$(CONFIG_CPU_MIPS64_R2) += $(call cc-option,-march=mips64r2,-mips64r2 > -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64r2 -Wa,--trap > -cflags-$(CONFIG_CPU_LOONGSON1) += \ > - $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA > -D_MIPS_ISA=_MIPS_ISA_MIPS32) \ > - -Wa,-mips32r2 -Wa,--trap > +cflags-$(CONFIG_CPU_LOONGSON1) += $(call cc-option,-march=mips32r2,-mips32r2 > -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap > > CPPFLAGS += -DTEXT_BASE=$(CONFIG_TEXT_BASE) > > -- Regards, Oleksij ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] MIPS: Makefile: minor codingstyle fix
On Fri, Nov 22, 2019 at 10:08:55AM +0100, Oleksij Rempel wrote: > Hi, > > it is a bit more then just minor codingstyle fix. Can you please describe > what was wrong and why the > change makes it better. There is nothing wrong with it. :) I am going to add one more after this line.I didn't know which codingstyle to follow. so I send this patch to make this line's codingstyle the same with previously lines. Regards, duhuanpeng ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] MIPS: Makefile: minor codingstyle fix
Am 22.11.19 um 10:46 schrieb Tim Williams: > On Fri, Nov 22, 2019 at 10:08:55AM +0100, Oleksij Rempel wrote: >> Hi, >> >> it is a bit more then just minor codingstyle fix. Can you please describe >> what was wrong and why the >> change makes it better. > There is nothing wrong with it. :) > I am going to add one more after this line.I didn't know which codingstyle > to follow. so I send this patch to make this line's codingstyle the same > with previously lines. Ah.. i see now. Actually all of this lines haw incorrect coding style. It should be 80 char width style. -- Regards, Oleksij ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] MIPS: Makefile: minor codingstyle fix
Hi. > Actually all of this lines haw incorrect coding style. It should be 80 > char width style. I see this, but it is more practical here. the editor will automatic warp lines. I can write a better description and send a v2 patch. Regards, Du Huanpeng ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH] watchdog: stm32_iwdg: explicitly set .running to UNSUPPORTED
I've spent some time trying to get the ONF (Watchdog enable status)
bit in the IWDG_SR register to read as something other than zero.
It has since been confirmed to be non-functional[1]. To avoid someone
else spending time on this, document that running status is unsupported
on this hardware explicitly.
No functional change as UNSUPPORTED is already the default.
[1]: https://www.spinics.net/lists/arm-kernel/msg770527.html
Signed-off-by: Ahmad Fatoum
---
drivers/watchdog/stm32_iwdg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
index 808d7c83720e..c7a5cb9caaf4 100644
--- a/drivers/watchdog/stm32_iwdg.c
+++ b/drivers/watchdog/stm32_iwdg.c
@@ -256,6 +256,7 @@ static int stm32_iwdg_probe(struct device_d *dev)
wdd->set_timeout = stm32_iwdg_set_timeout;
wdd->timeout_max = (RLR_MAX + 1) * data->max_prescaler * 1000;
wdd->timeout_max /= wd->rate * 1000;
+ wdd->running = WDOG_HW_RUNNING_UNSUPPORTED; /* ONF bit not present in
IP */
ret = watchdog_register(wdd);
if (ret) {
--
2.24.0
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
[PATCH] mtd: spi-nor: Add support for is25lp01g
Add ISSI 128Mb nor flash.
---
drivers/mtd/spi-nor/spi-nor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index b25103598..1e1b69626 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -677,6 +677,8 @@ static const struct spi_device_id spi_nor_ids[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "is25lp016d", INFO(0x9d6015, 0, 64 * 1024, 32,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+ { "is25lp01g", INFO(0x9d601b, 0, 64 * 1024, 2048,
+SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "is25lp080d", INFO(0x9d6014, 0, 64 * 1024, 16,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "is25lp032", INFO(0x9d6016, 0, 64 * 1024, 64,
--
2.15.0.276.g89ea799
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
[PATCH] mtd: spi-nor: Add support for is25lp01g
Add ISSI 128Mb nor flash.
Signed-off-by: Clement Leger
---
- Add missing Signed-off-by
drivers/mtd/spi-nor/spi-nor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index b25103598..1e1b69626 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -677,6 +677,8 @@ static const struct spi_device_id spi_nor_ids[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "is25lp016d", INFO(0x9d6015, 0, 64 * 1024, 32,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+ { "is25lp01g", INFO(0x9d601b, 0, 64 * 1024, 2048,
+SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "is25lp080d", INFO(0x9d6014, 0, 64 * 1024, 16,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "is25lp032", INFO(0x9d6016, 0, 64 * 1024, 64,
--
2.15.0.276.g89ea799
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
