[PATCH] MIPS: Makefile: minor codingstyle fix
exceed 80 characters in a line, but more readble and agree with upper lines. Signed-off-by: Du Huanpeng --- arch/mips/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/mips/Makefile b/arch/mips/Makefile index ee465dc..1c10db5 100644 --- a/arch/mips/Makefile +++ b/arch/mips/Makefile @@ -52,9 +52,7 @@ cflags-$(CONFIG_CPU_MIPS32_R1) += $(call cc-option,-march=mips32,-mips32 -U_MIPS cflags-$(CONFIG_CPU_MIPS32_R2) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap cflags-$(CONFIG_CPU_MIPS64_R1) += $(call cc-option,-march=mips64,-mips64 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64 -Wa,--trap cflags-$(CONFIG_CPU_MIPS64_R2) += $(call cc-option,-march=mips64r2,-mips64r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64r2 -Wa,--trap -cflags-$(CONFIG_CPU_LOONGSON1) += \ - $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \ - -Wa,-mips32r2 -Wa,--trap +cflags-$(CONFIG_CPU_LOONGSON1) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap CPPFLAGS += -DTEXT_BASE=$(CONFIG_TEXT_BASE) -- 2.7.4 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 3/3] remoteproc: add .stop device parameter for stopping remote processor
On 11/25/19 9:28 AM, Sascha Hauer wrote: > On Thu, Nov 21, 2019 at 09:40:05AM +0100, Ahmad Fatoum wrote: >> Both the STM32 and i.MX7 remote proc drivers populate the .stop member >> in the struct rproc, but it's not used anywhere. > > The .stop member in struct rproc is introduced in this patch. Indeed. I was referring to the stop member in the ops struct, which is a so-far unused function pointer. >> ret = rproc_start(rproc, &fw); >> +if (ret == 0) >> +rproc->stop = PARAM_TRISTATE_FALSE; > > Can we use positive logic here? "Status Stopped is false" is harder to > read than just "running" or "started". Naming it .stop emphasizes the fact that it's only meant to stop execution, not start it. See below. >> +return stop(rproc); >> +} > > I would assume that when I can stop the remote processor with this > parameter I should be able to start it here as well, no? Which firmware would the processor execute when started via parameter? I see no benefit in powering up the co-processor without specifying a firmware image. Thoughts? Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] MIPS: Makefile: minor codingstyle fix
On Fri, Nov 22, 2019 at 07:57:03PM +0800, Du Huanpeng wrote: > Hi. > > > Actually all of this lines haw incorrect coding style. It should be 80 > > char width style. > I see this, but it is more practical here. the editor will automatic warp > lines. > > I can write a better description and send a v2 patch. Please do so. Please don't take 80 chars as a hard limit. While I think the lines we are talking about here are a bit long, forcing it to 80 chars doesn't really improve readability. i.e the following looks good, eventhough it's longer than 80 chars: cflags-$(CONFIG_CPU_LOONGSON1) += \ $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \ -Wa,-mips32r2 -Wa,--trap Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] mtd: spi-nor: Add support for is25lp01g
On Fri, Nov 22, 2019 at 08:04:27PM +0100, Clement Leger wrote: > Add ISSI 128Mb nor flash. > > Signed-off-by: Clement Leger > --- > - Add missing Signed-off-by > > drivers/mtd/spi-nor/spi-nor.c | 2 ++ > 1 file changed, 2 insertions(+) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] watchdog: stm32_iwdg: explicitly set .running to UNSUPPORTED
On Fri, Nov 22, 2019 at 02:39:29PM +0100, Ahmad Fatoum wrote: > I've spent some time trying to get the ONF (Watchdog enable status) > bit in the IWDG_SR register to read as something other than zero. > > It has since been confirmed to be non-functional[1]. To avoid someone > else spending time on this, document that running status is unsupported > on this hardware explicitly. > No functional change as UNSUPPORTED is already the default. > > [1]: https://www.spinics.net/lists/arm-kernel/msg770527.html > > Signed-off-by: Ahmad Fatoum > --- > drivers/watchdog/stm32_iwdg.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] mfd: da9053: fix typo in variable name
On Thu, Nov 21, 2019 at 03:08:01PM +0100, Lucas Stach wrote: > Fixes: 06928c7d1758 (mfd: da9053: use new reset_source_set_device) > Signed-off-by: Lucas Stach > --- > drivers/mfd/da9053.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 3/3] remoteproc: add .stop device parameter for stopping remote processor
On Thu, Nov 21, 2019 at 09:40:05AM +0100, Ahmad Fatoum wrote:
> Both the STM32 and i.MX7 remote proc drivers populate the .stop member
> in the struct rproc, but it's not used anywhere.
The .stop member in struct rproc is introduced in this patch.
> The firmware API is not
> really fitting to 'unload' firmware. Add instead a device parameter to
> stop a remote processor, e.g. remoteproc0.stop=1. This is similar to the
> probe command used with MMCs.
>
> Signed-off-by: Ahmad Fatoum
> ---
> drivers/remoteproc/remoteproc_core.c | 30 +++-
> include/linux/remoteproc.h | 2 ++
> 2 files changed, 27 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c
> b/drivers/remoteproc/remoteproc_core.c
> index 8a28c1bafc1b..e031640bc7a0 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -101,6 +101,8 @@ static int rproc_firmware_finish(struct firmware_handler
> *fh)
> fw.size = rproc->fw_buf_ofs;
>
> ret = rproc_start(rproc, &fw);
> + if (ret == 0)
> + rproc->stop = PARAM_TRISTATE_FALSE;
Can we use positive logic here? "Status Stopped is false" is harder to
read than just "running" or "started".
> kfree(rproc->fw_buf);
>
> @@ -120,6 +122,19 @@ static int rproc_register_dev(struct rproc *rproc, const
> char *alias)
> return register_device(&rproc->dev);
> }
>
> +static int rproc_set_stop(struct param_d *param, void *priv)
> +{
> + struct rproc *rproc = priv;
> + int (*stop)(struct rproc *);
> +
> + stop = rproc->ops->stop;
> +
> + if (!stop)
> + return -ENOSYS;
> +
> + return stop(rproc);
> +}
I would assume that when I can stop the remote processor with this
parameter I should be able to start it here as well, no?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH 1/2] remoteproc: register a device for new remoteproc instances
On Wed, Nov 20, 2019 at 09:35:36AM +0100, Ahmad Fatoum wrote: > struct rproc has a device_d dev field, but so far it was unregistered. > The implementation had a few downsides: > > - dev_printf prints NULL, because the unique_name of the device is NULL > - The name used by firmwareload is the device tree node's name, which > might be unnecessarily verbose, e.g. mlahb:m...@1000.of > - All remoteproc devices are given the same (unused) name and index > > Fix these by registering a device for the remoteproc and using it where > appropriate. While at it, allow the remoteproc name to come from a > device tree alias as well. > > This breaks user behavior in that firmwareload now uses the alias or > remoteprocN to reference the remoteproc instance. This is probably > acceptable as the driver is a very recent addition. > > Cc: Oleksij Rempel > Signed-off-by: Ahmad Fatoum > --- > drivers/remoteproc/remoteproc_core.c | 29 ++-- > include/linux/remoteproc.h | 1 - > 2 files changed, 23 insertions(+), 7 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] ARM: cpu: dtb: remove unused declaration
On Wed, Nov 20, 2019 at 08:41:39AM +0100, Ahmad Fatoum wrote: > We no longer use __dtb_start on ARM and the declaration is unused in the > file. Drop it. > No functional change. > > Signed-off-by: Ahmad Fatoum > --- > arch/arm/cpu/dtb.c | 2 -- > 1 file changed, 2 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH] mci: dove: fix dereference of nullable pointer
On Wed, Nov 20, 2019 at 08:38:16AM +0100, Ahmad Fatoum wrote:
> data->{blocks, blocksize, flags} are all used outside of the if clause
> checking whether data is not NULL.
> Fix this to avoid dereferencing null pointers.
>
> Fixes: bdcf89d274 ("mci: add Marvell Dove SDHCI driver")
> Cc: Michael Grzeschik
> Signed-off-by: Ahmad Fatoum
> ---
> drivers/mci/dove-sdhci.c | 15 ---
> 1 file changed, 8 insertions(+), 7 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- |
___
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
